appreciated/demo-helper-view

Component collection to create visually appealing Vaadin addon demos

demo-helper-view's Issues

Customizing JavaCodeReader

I really like the idea of JavaCodeReader and using it often in the demo of my last addon. Are there any plans to customize the output? For example, i'd like to strip most but not all Annotations. Sometimes i have a public method which is only there for integration and not to document something which can be removed.

Currently i am using a customized Reader which strips Annotations by a defined list. Stripping by some regular expression should be easy implementable too. I have no real idea how to implement the method stripping. Maybe some external libs like http://javaparser.org/ can be useful. I'd like to contribute my work but wanted to hear your opinion first.

Allow CodeExample to pass a DependecyReader

Regression: Version 2.0.7 throws UnsupportedOperationException with a single Textcomponent inside DeviceView.

Works with Version 2.0.5

Testview:

public class MainView extends DemoHelperView {

  public MainView() {
    withDevice(new LaptopView(new Text("test")));
  }

Stacktrace:

Caused by: java.lang.UnsupportedOperationException: This instance is immutable
	at com.vaadin.flow.dom.impl.ImmutableEmptyStyle.set(ImmutableEmptyStyle.java:39) ~[flow-server-1.2.4.jar:1.2.4]
	at com.github.appreciated.demo.helper.view.devices.Device.<init>(Device.java:17) ~[demo-helper-view-2.0.7.jar:2.0.7]
	at com.github.appreciated.demo.helper.view.devices.LaptopView.<init>(LaptopView.java:8) ~[demo-helper-view-2.0.7.jar:2.0.7]
	at de.wathoserver.vaadin.MainView.<init>(MainView.java:15) ~[classes/:na]

Paragraph without description is not visible

Paragraph is set non-visible in constructor of ParagraphView if description is null.

public ParagraphView(String header, String description) {
        this();
        getHeaderLabel().setText(header);
        add(headerLabel);
        if (description != null) {
            getDescriptionLabel().setText(description);
            add(descriptionLabel);
        } else {
            setVisible(false);
        }
        setAlignItems(Alignment.CENTER);
    }

If this is intended than the following constructors doesn't make sense

 public ParagraphView(String header) {
        this(header, (String) null);
    }

    public ParagraphView(String header, Component[] components) {
        this(header, null, components);
    }

Adjust font sizes

Some Views are using too large font sizes in comparison with the overall header

Add a navigation Stack to the Browser component

And make the back / forward button behave correctly

Allow DeviceSwitchView and DemoParagraphView to switch Theme

Add a Switch to top right to allow switching the theme.
See here f.e.

Allow TextContentView to contain Links

Increase the Size of the LaptopView

The LaptopView is in comparison with the TabletView too small

Vaadin 23.x support

vaadin-app-layout currently doesn't work with vaadin v23.x

Additional context

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  21.038 s
[INFO] Finished at: 2022-12-06T13:19:28+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.vaadin:vaadin-maven-plugin:23.2.10:build-frontend (default) on project myapp: Execution default of goal com.vaadin:vaadin-maven-plugin:23.2.10:build-frontend failed: Vite process exited with non-zero exit code.
[ERROR] Stderr: 'vite v3.1.0 building for production...
[ERROR] transforming...
[ERROR] ✓ 501 modules transformed.
[ERROR] [vite]: Rollup failed to resolve import "@vaadin/vaadin-button/theme/lumo/vaadin-button-styles.js" from "node_modules/@appreciated/color-picker/theme/lumo/components/color-picker-responsive-canvas-styles.js".
[ERROR] This is most likely unintended because it can break your application at runtime.
[ERROR] If you do want to externalize this module explicitly add it to
[ERROR] `build.rollupOptions.external`
[ERROR] error during build:
[ERROR] Error: [vite]: Rollup failed to resolve import "@vaadin/vaadin-button/theme/lumo/vaadin-button-styles.js" from "node_modules/@appreciated/color-picker/theme/lumo/components/color-picker-responsive-canvas-styles.js".
[ERROR] This is most likely unintended because it can break your application at runtime.
[ERROR] If you do want to externalize this module explicitly add it to
[ERROR] `build.rollupOptions.external`
[ERROR]     at onRollupWarning (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/dist/node/chunks/dep-665b0112.js:45824:19)
[ERROR]     at onwarn (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/dist/node/chunks/dep-665b0112.js:45622:13)
[ERROR]     at Object.onwarn (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/node_modules/rollup/dist/es/shared/rollup.js:23225:13)
[ERROR]     at ModuleLoader.handleResolveId (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/node_modules/rollup/dist/es/shared/rollup.js:22352:26)
[ERROR]     at file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/node_modules/rollup/dist/es/shared/rollup.js:22313:26
[ERROR] ': Unexpected exit value: 1, allowed exit values: [0], executed command [/home/ususer/.vaadin/node/node, /home/ususer/Documentos/my-app (1)/node_modules/vite/bin/vite.js, build] in directory /home/ususer/Documentos/my-app (1) with environment {PATH=/home/ususer/.vaadin/node:/home/ususer/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin:/home/ususer/Documentos/CursosUdemy/kafka/code/0-start-kafka/linux/kafka_2.12-2.8.0/bin, INVOCATION_ID=bb7cbefe54a04b4fa2b4163c8593d232, XAUTHORITY=/run/user/1000/.mutter-Xwaylandauth.KNU6V1, XMODIFIERS=@im=ibus, GDMSESSION=ubuntu, XDG_DATA_DIRS=/usr/share/ubuntu:/usr/local/share/:/usr/share/:/var/lib/snapd/desktop, QT_IM_MODULE=ibus, XDG_CONFIG_DIRS=/etc/xdg/xdg-ubuntu:/etc/xdg, DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus, LANG=es_ES.UTF-8, XDG_SESSION_TYPE=wayland, XDG_CURRENT_DESKTOP=ubuntu:GNOME, JOURNAL_STREAM=8:87528, DISPLAY=:0, WAYLAND_DISPLAY=wayland-0, USERNAME=ususer, SESSION_MANAGER=local/ususer:@/tmp/.ICE-unix/3021,unix/ususer:/tmp/.ICE-unix/3021, LOGNAME=ususer, MANAGERPID=2884, PWD=/home/ususer/Documentos/my-app (1), IM_CONFIG_PHASE=1, _=/usr/bin/gnome-session, XDG_SESSION_CLASS=user, GJS_DEBUG_TOPICS=JS ERROR;JS LOG, SHELL=/bin/bash, GIO_LAUNCHED_DESKTOP_FILE=/home/ususer/.local/share/applications/IntelliJ.desktop, DESKTOP_SESSION=ubuntu, USER=ususer, XDG_MENU_PREFIX=gnome-, GIO_LAUNCHED_DESKTOP_FILE_PID=207465, QT_ACCESSIBILITY=1, GNOME_DESKTOP_SESSION_ID=this-is-deprecated, GJS_DEBUG_OUTPUT=stderr, GTK_MODULES=gail:atk-bridge, SSH_AUTH_SOCK=/run/user/1000/keyring/ssh, GNOME_SHELL_SESSION_MODE=ubuntu, SYSTEMD_EXEC_PID=3039, XDG_RUNTIME_DIR=/run/user/1000, GNOME_SETUP_DISPLAY=:1, XDG_SESSION_DESKTOP=ubuntu, SSH_AGENT_LAUNCHER=gnome-keyring, SHLVL=0, HOME=/home/ususer}, output was 1534 bytes:
[ERROR] vite v3.1.0 building for production...
[ERROR] transforming...
[ERROR] ✓ 501 modules transformed.
[ERROR] [vite]: Rollup failed to resolve import "@vaadin/vaadin-button/theme/lumo/vaadin-button-styles.js" from "node_modules/@appreciated/color-picker/theme/lumo/components/color-picker-responsive-canvas-styles.js".
[ERROR] This is most likely unintended because it can break your application at runtime.
[ERROR] If you do want to externalize this module explicitly add it to
[ERROR] `build.rollupOptions.external`
[ERROR] error during build:
[ERROR] Error: [vite]: Rollup failed to resolve import "@vaadin/vaadin-button/theme/lumo/vaadin-button-styles.js" from "node_modules/@appreciated/color-picker/theme/lumo/components/color-picker-responsive-canvas-styles.js".
[ERROR] This is most likely unintended because it can break your application at runtime.
[ERROR] If you do want to externalize this module explicitly add it to
[ERROR] `build.rollupOptions.external`
[ERROR]     at onRollupWarning (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/dist/node/chunks/dep-665b0112.js:45824:19)
[ERROR]     at onwarn (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/dist/node/chunks/dep-665b0112.js:45622:13)
[ERROR]     at Object.onwarn (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/node_modules/rollup/dist/es/shared/rollup.js:23225:13)
[ERROR]     at ModuleLoader.handleResolveId (file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/node_modules/rollup/dist/es/shared/rollup.js:22352:26)
[ERROR]     at file:///home/ususer/Documentos/my-app%20(1)/node_modules/vite/node_modules/rollup/dist/es/shared/rollup.js:22313:26
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

Process finished with exit code 1

Target Version
23.2.10

Allow additional spacing to be added by using a builder method withTextContentView

or improve the general styling that it isn't necessary anymore