appsmithorg/react-icon-emoji-picker

Search and select from 2300+ emojis and icons

react-icon-emoji-picker's Issues

Emoji Icon selector component discussion.

Hey, I added a basic emoji icon selector component.

Few thoughts:

• Currently, I added the popup in form of the modal. Did the requirement mean something like opening a panel like in slack keyboard?
• How is this icon component is supposed to be used? Will it be used inline in sentences? Right now, Every component renders the modal individually. Another approach is adding it on the global level for all the EmojiIconSelector, that would require us to use redux or context. Although, there is no performance difference because if the popup is not opened it does not hide rather it returns null.
• Right now I abstracted to the picker behavior in EmojiSelectorLayout. So this same layout is rendered in the modal and app. You think, there should be another one for modal?

Here is the link to the behavior:
https://www.loom.com/share/943b5d2e8eb347d5ababa9e4222d0a10