aquazus/d1proxy

A simple yet powerful Java 11 TCP MITM proxy for Dofus 1.29.1

d1proxy's Issues

Fix "identical-code" issue in src/main/java/fr/aquazus/d1proxy/handlers/GPHandler.java

Identical blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/Aquazus/D1Proxy/src/main/java/fr/aquazus/d1proxy/handlers/GPHandler.java#issue_5bee28dbef1c59000100002c

java.io.FileNotFoundException: d1proxy.properties

Steps:

1. Clone repo
2. mvn package
3. java -jar {name.jar}

java.nio.channels.ShutdownChannelGroupException

Exception in thread "Thread-10" java.nio.channels.ShutdownChannelGroupException
	at java.base/sun.nio.ch.Invoker.invokeIndirectly(Invoker.java:223)
	at java.base/sun.nio.ch.Invoker.invoke(Invoker.java:189)
	at java.base/sun.nio.ch.Invoker.invoke(Invoker.java:298)
	at java.base/sun.nio.ch.WindowsAsynchronousSocketChannelImpl$ReadTask.failed(WindowsAsynchronousSocketChannelImpl.java:602)
	at java.base/sun.nio.ch.Iocp$EventHandlerTask.run(Iocp.java:389)
	at java.base/java.lang.Thread.run(Thread.java:834)

GP bug

04:41:10 DEBUG f.a.d.n.ProxyClient - [127.0.0.1 - Aquazus-Arc] --> GP*
Exception in thread "Thread-1" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
at fr.aquazus.d1proxy.network.ProxyCipher.decodeGP(ProxyCipher.java:49)
at fr.aquazus.d1proxy.handlers.GPHandler.shouldForward(GPHandler.java:22)
at fr.aquazus.d1proxy.network.ProxyClient.shouldForward(ProxyClient.java:135)
at fr.aquazus.d1proxy.network.ProxyClient.lambda$handleClient$4(ProxyClient.java:81)
at simplenet.Client.lambda$readByteAlways$3(Client.java:489)
at simplenet.Client$2.accept(Client.java:442)
at simplenet.Client$2.accept(Client.java:439)
at simplenet.Client.read(Client.java:418)
at simplenet.Client$2.accept(Client.java:443)
at simplenet.Client$2.accept(Client.java:439)
at simplenet.Client.read(Client.java:418)
at simplenet.Client$2.accept(Client.java:443)
at simplenet.Client$2.accept(Client.java:439)
at simplenet.Client.read(Client.java:418)
at simplenet.Client$2.accept(Client.java:443)
at simplenet.Client$2.accept(Client.java:439)
at simplenet.Client.read(Client.java:418)
at simplenet.Client$2.accept(Client.java:443)
at simplenet.Client$2.accept(Client.java:439)
at simplenet.Client$Listener.completed(Client.java:95)
at simplenet.Client$Listener.completed(Client.java:45)
at java.base/sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:127)
at java.base/sun.nio.ch.Invoker$2.run(Invoker.java:219)
at java.base/sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)

Fix "identical-code" issue in src/main/java/fr/aquazus/d1proxy/handlers/AXKHandler.java

Identical blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/Aquazus/D1Proxy/src/main/java/fr/aquazus/d1proxy/handlers/AXKHandler.java#issue_5bee28dbef1c59000100002b

StringIndexOutOfBoundsException: begin 0, end -1, length 0

14:48:31 INFO f.a.d.n.ProxyClient - [77.XX.XX.XX] auth tunnel opened!
Exception in thread "Thread-1" java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 0
	at java.base/java.lang.String.checkBoundsBeginEnd(String.java:3319)
	at java.base/java.lang.String.substring(String.java:1874)
	at fr.aquazus.d1proxy.network.ProxyClient.lambda$handleClient$4(ProxyClient.java:87)
	at simplenet.Client.lambda$readByteAlways$3(Client.java:489)
	at simplenet.Client$2.accept(Client.java:442)
	at simplenet.Client$2.accept(Client.java:439)
	at simplenet.Client.read(Client.java:418)
	at simplenet.Client$2.accept(Client.java:443)
	at simplenet.Client$2.accept(Client.java:439)
	at simplenet.Client.read(Client.java:418)
	at simplenet.Client$2.accept(Client.java:443)
	at simplenet.Client$2.accept(Client.java:439)
	at simplenet.Client$Listener.completed(Client.java:95)
	at simplenet.Client$Listener.completed(Client.java:45)
	at java.base/sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:127)
	at java.base/sun.nio.ch.Invoker.invokeDirect(Invoker.java:158)
	at java.base/sun.nio.ch.UnixAsynchronousSocketChannelImpl.implRead(UnixAsynchronousSocketChannelImpl.java:560)
	at java.base/sun.nio.ch.AsynchronousSocketChannelImpl.read(AsynchronousSocketChannelImpl.java:277)
	at java.base/sun.nio.ch.AsynchronousSocketChannelImpl.read(AsynchronousSocketChannelImpl.java:298)
	at java.base/java.nio.channels.AsynchronousSocketChannel.read(AsynchronousSocketChannel.java:425)
	at simplenet.Server$2.completed(Server.java:103)
	at simplenet.Server$2.completed(Server.java:97)
	at java.base/sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:127)
	at java.base/sun.nio.ch.Invoker$2.run(Invoker.java:219)
	at java.base/sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Fix "similar-code" issue in src/main/java/fr/aquazus/d1proxy/commands/ProfileCommand.java

Similar blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/Aquazus/D1Proxy/src/main/java/fr/aquazus/d1proxy/commands/ProfileCommand.java#issue_5bee28dbef1c590001000032

ProxyClient.currentMap ne se met pas à jour lorsque le sniffing est désactivé

En essayant de faire un plugin je m’aperçois que ProxyClient.currentMap est toujours à 0.
Le problème est dans le GDMHandler qui met à jour la valeur de currentMap uniquement si le sniffing est activé.
Avec la possibilité de faire des plugins j'imagine que ce comportement n'est pas intentionnel.