araluce/calendlyr

✨ Ruby bindings for Calendly API.

Hi there 👋 I'm araluce

Senior RoR developer

• 🌍 I'm based in Sevilla (Spain)
• ✉️ You can contact me at [email protected]
• 🚀 I'm currently working as RoR developer at Crisalix

Skills

calendlyr's Issues

Caching me and organizations responses

Some methods like client.me and client.organization generates a response that probably don't change in the future. Maybe it's a good point caching those responses. Add a reload method for User model to fetch an updated response.

DRY handle_response method

@araluce If you are not planning to add something specific for each response code, this code can be much DRYer 👌🏼

calendlyr/lib/calendlyr/resource.rb

Lines 48 to 68 in 6ca2aad

	def handle_response(response)
	body = JSON.parse(response.read_body)
	case response.code
	when 400
	raise Error, "#{body["title"]}. #{body["message"]}"
	when 401
	raise Error, "#{body["title"]}. #{body["message"]}"
	when 403
	raise Error, "#{body["title"]}. #{body["message"]}"
	when 404
	raise Error, "#{body["title"]}. #{body["message"]}"
	when 429
	raise Error, "#{body["title"]}. #{body["message"]}"
	when 500
	raise Error, "#{body["title"]}. #{body["message"]}"
	when 503
	raise Error, "#{body["title"]}. #{body["message"]}"
	else
	body
	end
	end

make code coverage 100%