react-test's People
react-test's Issues
Don't use one line statements
react-test/src/actions/listActions.js
Line 25 in 74ca7fe
I would suggest to always use braces after if
statements, even when there is only one line after it.
Import libraries first then local packages
react-test/src/components/App.js
Line 2 in 74ca7fe
I would suggest to import libraries first then import local packages (linters usually requests it).
Import specific functions instead of whole file
react-test/src/components/List.js
Line 3 in 74ca7fe
I would suggest to use following instead
import { fetchList } from '../actions/listActions';
Use constants for action names
react-test/src/actions/listActions.js
Line 5 in 74ca7fe
Would suggest to use constants instead of strings in cases when you will have to reuse string values. It will decrease the chance to make a mistake in action name.
Move URL's to separate file
react-test/src/actions/listActions.js
Line 27 in 74ca7fe
Would suggest create a module which will build urls, example:
export function nasaUrl(search) {
return `https://images-api.nasa.gov/search?year_start=2017&media_type=image&q=${search}`;
}
Also would suggest to concatenate strings as in example above, in case it is not compiled (by Babel for example) it is much faster.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.