arcalot/arcaflow-plugin-sysbench

arcaflow-plugin-sysbench's Issues

Make sysbench plugin more generic

Please describe what you would like to see in this project

The existing plugin is opinionated about the use case for sysbench, breaking down functions as cpu and memory workloads into separate plugin steps. This causes some redundancy in code and in the schemas, and it limits the possible functionality of the plugin for user-described workloads. Can we rebuild this with a less-opinionated approach?

Please describe your use case

As a sysbench expert user, I want to be able to bring any workload I may normally run by hand or through existing automation to the Arcaflow workflow. The plugin should enable me to use any parameters to run sysbench as I choose.

Output validates against P95 results as hard-coded, breaking any other percentile settings.

Describe the bug

The output schema validation looks specifically for P95 results. If the user passes a different percentile parameter to the input, then the output will match that requested by the input, and this will result in a plugin failure due to output validation.

To reproduce

Run the plugin with a percentile configuration other than 95:

echo '{"threads": 1, "time": 20, "percentile":99, "cpu-max-prime":500000}' | podman run -i --rm quay.io/arcalot/arcaflow-plugin-sysbench:0.3.0 -s sysbenchcpu -f -

Additional context

The problem in the schema is here. We need to make this flexible to any percentile.

arcaflow-plugin-sysbench/arcaflow_plugin_sysbench/sysbench_schema.py

Lines 379 to 383 in 3f3d332

	P95thpercentile: typing.Annotated[
	float,
	schema.name("95th Percentile"),
	schema.description("95th percentile latency"),
	]

Sysbench plugin should support all workload types

Please describe what you would like to see in this project

Currently the sysbench plugin supports only the CPU, I/O, and memory workloads. The plugin should be extended to support the other workloads from sysbench.

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: None
Error type: Invalid gitAuthor
Message: gitAuthor is not parsed as valid RFC5322 format: Platform Engineering Bot

Change sysbench installer from upstream github to EPEL

Please describe what you would like to see in this project

The upstream sysbench project has been unmaintained for a couple of years. This introduces risks for security, dependency, and rot. The tool is maintained in EPEL as an RPM package, so it would be preferable to change the Dockerfile to install from the package instead of the upstream.

[Chaos] Add support to fileio test

Please describe what you would like to see in this project

Add support to fileio options in the input schema, add related commandline arguments to the plugin, parse the output of the fileio test.

Please describe your use case

Create disk io hog scenario using arcaflow