archer884/annatar

The Lord of Gifs! ...Hahahaha shut up.

annatar's Issues

Default output path is incorrect

Another documentation issue. The default output path is given as <image path>/<image name>.ann.<ext>. This couldn't be more wrong; in fact, the output goes to <pwd>/<image name>-annotated.png. Or should. I don't know if it actually does that or not.

• Verify that output is given a png extension by default.
• Correct default path given in documentation.

Compatibility with British/EU copyright law

Annatar permits users to create derivative works, which is just not cool. Create a --british mode that replaces input images with plain black or plain white pixels.

Help claims jpg is the default output type

Help claims that jpg is the default output type. This is a filthy, filthy lie. Jpg makes our text look miserable, so the default was changed to png a while back.

Borders look terrible

They look about as good as the average border on the average meme builder, I guess, but I'm really annoyed by how they stack up against what you might get out of photoshop or whatever. I mean, my name isn't Adobe or anything, but I think I can do better than what I've got at the moment.

Right now, the only solution that comes to mind is...

Brute force anti-aliasing

You remember how AA used to work, right? They'd render your scene at four times your actual resolution and then downsample. This should probably work; I'm just not really sure how. I can get the text size and quadruple that bounding box, but will I be able to scale the text appropriately? Hopefully, multiplying the scaling value by four would work there, too; we'll just have to see. Anyway, that would significantly reduce aliasing in the border, and it would basically allow us to hand off the job of making it smooth to the image library.

Unknowns: this requires us to build up the text as basically a sticker that gets pasted on top of the original image. That's trivial with layers in pretty much any image editor, but I have no idea how to do it using these libraries.

Consider use of circles instead of boxes

Boxes look wonky in places. Maybe circles would look better?

Paths and file types may not match

Annatar accepts an explicit path, but this path is not used (as far as I know) in detecting the output file type. Maybe we should, by default, detect the output type by the extension of the output path. Additionally, we should probably print a warning in the event that the selected filetype (via configuration flag) does not match the output filename.

...Honestly, this may not even be a bug, but I'm worried it is, so just validate this behavior and, if it's wrong, fix it.

Broken on macOS Catalina

Looks like the system fonts have been moved.

Maybe it's time to embed the default font into the binary? Otherwise, I guess maybe just check multiple font locations on mac.