ardenthq/arkvault

arkvault's Issues

[Exchange] Correct dropdown size in exchange form on mobile

Describe the refactor you'd like to request

Increase the size of dropdown in mobile to use full width.

Additionally adjust dropdown colors as below:

[Votes] Mobile header to narrow when there are no wallets

Describe the refactor you'd like to request

[General] divider lines between content and buttons

Describe the refactor you'd like to request

The use of the divider line is currently incosistent and should be reviewed. An example of a missing divider line would be the Select Network page.

[Exchange] modal is not centered on `md` breakpoint

Describe the refactor you'd like to request

The exchange modal is currently not vertically centered on the md breakpoint. It should be centered and the vertical padding around the modal needs be reduced instead.

Disable input focus on dropdowns for mobile

Describe the refactor you'd like to request

The virtual keyboard is triggered in mobile for Select dropdowns when the user clicks and focuses on the input area of the dropdown. It is unnecessary, especially for dropdowns that don't have many options. The input focus can be prevented for tablet/mobile devices.

Example:
https://user-images.githubusercontent.com/22020168/175042296-1c2b20a8-6e6a-44a7-ae97-6d05c68a42e4.mp4

[Wallet Import] The wrong network is selected when profile has only one enabled network

Describe the Bug

If the profile has only one network enabled, a random network is selected when importing a wallet instead of the enabled one. See video below.

Expected Behavior

It should select the enabled network and move to the import form step.

To Reproduce

Screen.Recording.2022-06-13.at.09.06.25.1.mov

What operating system are you using?

Linux

What browser are you using?

Chrome

What version of Node.js are you using?

16

[Profile Export] Color Accent not respected

Describe the Bug

When importing a profile that uses the Green accent color, the color defaults back to blue. It appears the setting is not respected during export.

Expected Behavior

Respect the accent color

To Reproduce

• Create profile
• Change color to green
• Export profile
• Import profile

What operating system are you using?

macOS

What browser are you using?

Chrome

What version of Node.js are you using?

No response

[Dashboard] show only wallet group skeleton while syncing wallets

Describe the refactor you'd like to request

Upon entering a profile, the dashboard briefly displays the wallet group skeleton, the empty block, and the wallet group placeholder. It should display only the skeleton while the wallets are synced the first time.

[Networks] prioritize default networks over custom ones

Describe the refactor you'd like to request

The UI should prioritize the default networks over any custom ones. That is, default networks should always be shown first (network cards / network dropdowns). With all default networks enabled, and multiple custom networks available, it could make sense to group the networks inside the dropdowns.

[Ledger import] Handle case no wallets

When you import some wallets with a Ledger device after importing all of them (meaning there are no more wallets to add), it shows an empty table.

Will be better to show some empty state with a message like "There are no new wallets to add."

Also, I think we can change the message in the alerts that show the progress so instead of saying "2 wallets found," it can say something like "2 new wallet founds" (only when you try to import more wallets in the second time)

Also, I suppose it is possible to not have wallets at all, even in the first import so the same empty state but the message should be different like "No wallets found"

[Network Selection] Implement new UI

Implement the new network selection UI in wallet creation and import steps.
See https://www.figma.com/file/o6b1tEMOdUtHv7ijVs6pMX/ARKVault?node-id=9173%3A143376

[Fees] fee calculation invalidates amount

Describe the refactor you'd like to request

The fee calculation invalidates the amount input when the amount is calculated while the Send All toggle is on.

fees.mov

[General] Ensure network names are updated

Describe the Bug

When a user updates the name of their custom network, the change of the new name isn't reflected throughout the whole wallet. Some areas of the wallet continue to state the old network name, but other areas show the updated network name. See video here: https://cryptoarkproject.slack.com/archives/CJFKZSV61/p1655457089617319

Expected Behavior

All network names should update

To Reproduce

1. Add custom networks
2. Add wallets for the custom networks
3. Change the name of custom network
4. Browse different areas of the wallet as shown in the linked video.

What operating system are you using?

macOS

What browser are you using?

Chrome

What version of Node.js are you using?

No response

[Profile Import] apply accent color during profile import

Something like:

	useEffect(() => {
		setProfileAccentColor(profile);
	}, []);

in https://github.com/ArdentHQ/arkvault/blob/develop/src/domains/profile/pages/ImportProfile/ProfileFormStep.tsx#L32

Originally posted by @goga-m in #55 (comment)

Ledger wallet, not able to withdraw

Describe the Bug

Not able to withdraw from a ledger wallet. I can load the wallet from the ledger, but when I try to withdraw nothing happens. Just the cursor spinning. This is on Mint/Linux, and I tried Brave, Chromium and Vivaldi. Same behavior, the app first connect to the ledger, so I can see the balance, but I am not able to withdraw.
I tried to change my delegate-vote, and that worked.
Last time I was able to withdraw was 10. December.

I also tried on Windows, Firefox and Edge browser. There I get an error-message: 'e.openConnected is not a function'.

I have used two ledger devices, first a Ledger Nano S, and than a Ledger Nano X. Same behavior, both on Linux and Windows.

Update:
I am still not able to withdraw from the Ledger-wallet to any 'outside' wallet. However I created a new wallet in the vault-app, using the code-words from Ledger. and I was able to transfer from the Ledger-wallet to the new wallet, and from that wallet and out to an external wallet, using the mnemonic words.

Expected Behavior

Expect to be able to withdraw funds.

To Reproduce

Go to 'Send Ark'-page.
Enter sender and recipient addresses. Enter amount.
No Memo. Average Average transaction fee.
Click Continue.
Sent to 'Transaction review' page.
Click Continue.
Sent to the 'Ledger Wallet' page.
Sees a spinning circle, and the message 'Open the ARK app on your device.
But it never connects.

What operating system are you using?

Linux

What browser are you using?

Brave, Chromium, and Vivaldi

What version of Node.js are you using?

Using the web-version.

[Dashboard / Wallets] border in wallet group headers visible on some breakpoints

Describe the refactor you'd like to request

On smaller breakpoints the wallet group headers do not show all elements, the border styling of the elements did not account for this, for instance:

[General] wallet labels missing after importing and logging out

When you import a wallet it gets given a default name (e.g. ARK #1). If you close the wallet after importing, these default labels tend to disappear. To reproduce:

1. Create a new wallet (not import) and it will get a default label (ARK #1). Save this and move on
2. Import a wallet, and it will get a default label (ARK #2). Do not change anything, save it and move on
3. Dashboard will show 2 wallets now, both with labels
4. Sign out of the profile
5. Sign in to the profile again
6. Now the imported wallet has no label anymore

[Ledger Import] missing divider line

Describe the refactor you'd like to request

[Settings] exchange currency after settings reset

Describe the refactor you'd like to request

When resetting the profile, the exchange currency is set to BTC, as that is the default currency defined in the SDK. The currency should be set to the one corresponding to the users locale if available, and USD otherwise, instead, as is done during the profile creation.

[Exchange] wrong paddings and offest in exchange form

On the md breakpoint the page does not utilize all the available height, on all breakpoints >= md the form buttons have a bottom margin that shouldn't be there.

[pwa] loading screen white on some devices

It appears that on some devices the loading screen does not show the logo and color, but simply a white screen.

Noticed on iPhone 13 with iOS 15.5 by Reece. Worked fine on Android 12. Video can be seen here: https://cryptoarkproject.slack.com/archives/CJFKZSV61/p1655895709033939

[Exchange] rendering the exchange rate skeleton causes a layout jump

exchange-rate.mov

[Import/create wallet]: when we have custom networks is skipping select network step

When we have 1 default network + 1 custom network is skipping the first step for selecting networks when importing or creating a wallet and probably other parts whose logic changes when we only have one network.

[Dashboard] portfolio breakdown skeleton has wrong styles

Describe the refactor you'd like to request

The portfolio breakdown is not styled correctly on the smaller breadkpoints.

Import Network Custom Host

Describe the refactor you'd like to request

im building blockchain using ARKLauncher. i enabled ssl with cloudflare registered the domain there and when i tried to install ssl with certbot and re-enabled ssl cloudflare i couldn't get the information from the seed in arkvault and i tried to generate ssl manually as the documentation explained but still the domain can't be accessed

Error
Cannot obtain network data. Check Seed Server.