ardielle/ardielle-java

ardielle-java's Issues

generated models do not have a hashcode that is consistent with equals

.. which means suffering if someone tried to stick these into sets and map keys.

$ cat x.rdl
type Foo struct {
	String bar;
	String baz;
}
$ rdl -ps generate java-model x.rdl

produces

//
// This file generated by rdl 1.4.13. Do not modify!
//

import com.yahoo.rdl.*;

//
// Foo -
//
public class Foo {
    public String bar;
    public String baz;

    public Foo bar(String bar) {
        this.bar = bar;
        return this;
    }
    public Foo baz(String baz) {
        this.baz = baz;
        return this;
    }

    @Override
    public boolean equals(Object another) {
        if (this != another) {
            if (another == null || another.getClass() != Foo.class) {
                return false;
            }
            Foo a = (Foo) another;
            if (bar == null ? a.bar != null : !bar.equals(a.bar)) {
                return false;
            }
            if (baz == null ? a.baz != null : !baz.equals(a.baz)) {
                return false;
            }
        }
        return true;
    }
}

Validator does not work if entry has Struct fields

I have the following definition:

type Entity Struct {
EntityName name; //name of the entity object
Struct value; //value of the entity
}

    Entity e = new Entity().setName("test.entity").setValue(new Struct().with("key", "test"));
    result = validator.validate(e, "Entity");

I get back failure: Not a valid Struct, com.yahoo.rdl.Struct in data.value expected

Support for consuming multipart_form_data

Hello,

I want to use RDL for writing a java webservice that accepts File input from user via POST call. i.e. support for Consuming MediaType.MULTIPART_FORM_DATA during post call. It seems that RDL currently supports only JSON data consumption. Is there a plan to add this feature?

Thanks,
Milan

Missing name() method on SchemaBuilder.ResourceBuilder

Needed if the name is actually set on the schema.

Validator does not validate correctly if object has multiple Array fields

If I have the following rdl:

type DomainTemplate Struct {
Array templateNames;
Array params (optional);
}

When validating this object against its schema, it only validates the templateNames array and just ignores params array. Quick look at the code shows that it returns the value of the first array validation rather than only returning if there is a failure and continuing with the other fields.

No license found in rdl-java

Our oss license checker warns this library because rdl-java is not licensed, please add a license.