Game crashes if the player fails a mission with no "no_ships" line set in the data

[elasota]

Game crashes if the player fails a mission with no "no_ships" line set in the data

[elasota]

Looks potentially valid. srtm.pn doesn't define any "no_ships" string, so I guess it can be uninitialized if you fail it?

[sfiera]

Hmm. In practice, the replay shouldn’t get that far, because the key input stream ends before the last ship dies, and that’s supposed to stop the replay. Somehow, pausing (do you mean ESC or CAPS?) must allow the game time to advance further.

(It would also be good to not crash when no_ships is empty, because that could happen in real levels)

[elasota]

I mean like suspending the process with the debugger attached. Not 100% sure if this is reproducible in a real-world scenario yet, but should probably test to see what happens in Space Race, The Musical if you game over from ship loss.

[sfiera]

I see, that makes more sense. If the process is suspended and resumed, it will probably attempt to catch up by running the clock through that whole time, before the replay end check.

The corresponding real-world scenario would be a very slow computer that can't effectively keep up, though that computer is not going to have a good time anyway.