Message typing sound is loud and disruptive to gameplay flow

[kael131]

Message typing sound is loud and disruptive to gameplay flow

[kael131]

Briefly looking through the code, I would increase the number of ticks between teletype sounds for messages, but I couldn't see exactly where the on-UI highlight messages that appear during tutorials are drawn.

Edit: I think I found where you were unsure of the correct timings yourself - Line 149 of labels.cpp. I wouldn't worry about staying faithful to the original, this is one of those QoL changes that will make the game more accessible for newcomers.

 if (!label->text().done()) {
            // TODO(sfiera): get data on the original rate here.  It looks like the rate of
            // printing was tied to the frame rate before: 3 per frame.  Here, we've switched to 1
            // per tick, so this would be equivalent to the old code at 20 FPS.  The question is,
            // does it feel equivalent?  It only comes up in the tutorial.
            for (size_t i = 0; i < units_done.count(); ++i) {
                label->text().advance();
            }
            if (!label->text().done()) {
                sys.sound.teletype();
            }
        }