Comments (6)
update
conda-forge/hera-workflows-feedstock
PR for v1.0.1 merged:
conda-forge/hera-workflows-feedstock#3
@flaviuvadan - I've added the tests to run as part of the feedstock ci pipelines [ previously only imports
tests ran there ]:
https://github.com/conda-forge/hera-workflows-feedstock/blob/master/recipe/meta.yaml#L39
hera-workflows=1.0.1
is now available in conda-forge
:
https://anaconda.org/conda-forge/hera-workflows
from hera.
Hey @harelwa! Thank you for submitting this. I will take a look soon!
from hera.
Please see: #52
from hera.
@harelwa I just installed 1.0.1 in a virtual environment through pip install hera-workflows==1.0.1
. Unfortunately 1.0.0 will remain broken on PyPi 🙁 What's the best way to help conda-forge in a case like this?
I must apologize for not catching this earlier... It's evident that Hera needs a step that publishes it to Test PyPi prior to the official PyPi index. Submitted a new issue for this.
from hera.
Hi @flaviuvadan
Thank you very much for the [so]fast reply and fix!
as for conda-forge
--
no worries. it did not publish due to the tests failure. I will update the recipe to look at v1.0.1
.
please note that this err was caught by conda-forge
ci, as conda build
runs tests of the built package. you can see more here - https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#test-section
As for hera
s CI, you can indeed check this too, prior to publishing, by adding a step of test-pkg
step between build
+ and publish
.
This test-pkg
will do something like -
- install the local built
.whl
in a new venv [ "test env" ] - install additional pkgs required for testing, e.g.
pytest
- run tests [
pytest tests
]
In this context -- make sure to not fall intopytest
PYTHONPATH pitfalls - https://docs.pytest.org/en/6.2.x/pythonpath.html
hth,
harel
from hera.
@harelwa that's great! Thank you for submitting this issue, giving suggestions on how to improve the safety of Hera's releases, and your documentation PR 🙂 I am going to close this issue but feel free to submit other issues, or reopen this one if there's more to discuss.
from hera.
Related Issues (20)
- Help needed: logo for Hera! 🚀 HOT 2
- Examples are not working properly HOT 1
- Support Optional/Union types in script runner
- Allow `get_parameter` usage on `TemplateRef` steps/tasks
- Hera's token handling feels a bit awkward HOT 2
- Script decorator breaks type hints
- Add LocalVolume to supported volume types HOT 2
- Incompatible with pydantic 1.10.15 HOT 2
- Dependabot commits making commit history noisy HOT 2
- Runner IO (RunnerOutput) misbehaves for artifacts HOT 2
- with_param has reverted back to ignoring kwargs HOT 1
- HEP0001 - new script decorator
- HEP0001 - new DAG decorator
- HEP0001 - new Steps decorator
- HEP0001 - TemplateSets
- Allowing extra information to Parameter/Artifact HOT 2
- Add governance and membership pathway documentation
- HEP0001 - new container decorator
- HEP0001 documentation
- Workflow parameter interpolation issue in WorkflowTemplates HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hera.