Giter Site home page Giter Site logo

logos-iter's People

Contributors

ark0f avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar

Forkers

icodein

logos-iter's Issues

`PeekableLexer::span` changes after a peek

Thanks for creating this crate! It has been very useful.

I have a minor bug, best understood with an example-

let mut l = Token::lexer("1+2").peekable_lexer();
assert_eq!(l.next(), Some(Token::I32Literal(1)));
assert_eq!(l.span(), 0..1);
assert_eq!(l.peek(), Some(&Token::Plus));
// since the lexer hasn't progressed, its span should be the same
assert_eq!(l.span(), 0..1);

Currently, the last assert fails and span gives 1..2 instead.

I guess the fix would be to use prev_span here instead of span-

Some(Peeked { span, .. }) => span.clone(),

Would be happy to raise a PR if needed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.