arkecosystemarchive/ark-java

Library for interacting with an Ark Ecosystem Blockchain using the JVM.

ark-java's Issues

Network.warmup() crashes on gradle/android app

Caused by: groovy.lang.MissingPropertyException: No such property: ip for class: io.ark.core.Peer
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
at org.codehaus.groovy.runtime.callsite.ConstructorSite$NoParamSite.callConstructor(ConstructorSite.java:127)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:60)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:235)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:247)
at io.ark.core.Peer.create(Peer.groovy:24)

Recompile for Java 7

Recompile using 1.7 for greater compatibility with older projects.

For example, this library doesn't work on Android right now.

createSecondSignature Transaction problem

Have problem with setting up second passphrase:
Transaction.createSecondSignature("passphrase2", "passphrase")
Get message:

Transaction not accepted by network:
[success:false, message:Invalid transaction detected, error:TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object.]

Checked `Transaction.class:
static Transaction createSecondSignature(secondPassphrase, passphrase){
def tx = new Transaction(type:1, amount:0, fee:500000000)
tx.asset.signature = BaseEncoding.base16().lowerCase().encode(Crypto.getKeys(secondPassphrase).getPubKey())
tx.timestamp = Slot.getTime()
tx.sign(passphrase)
tx.id = Crypto.getId(tx)
return tx
}

We haven't data types set for parameters, set to String but got same message.

gradle build failing with wrapper script

I was attempting to run ./gradlew build with the packaged wrapper script when i encountered this error:

The following model rules are unbound:
  model.components
    Mutable:
      - components (java.lang.Object)

Create stub node for integration tests

Tests currently uses live networks to test, eg:

def result = peer << transaction
  then:
  result.error == "Account does not have enough ARK: AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC balance: 0"

sending some Ark to that address will cause a lot of tests to fail.

result.get("success") == true
result.get("count").equals("2") //Count doesnt include filtering from api call
(result.get("transactions") as List).size() == 2

or sending a tx to this address will cause this to fail.

We should create a stub node with the same validation on ark-node, but provide controlled variables (balance, votes, transactions, etc) and replace affected tests to use that instead.

Rename maven group & artifactid

<groupId>io.ark.lite</groupId>
<artifactId>client</artifactId>

Doesn't seem right. The artifact does not describe the package, and will appear as "client-0.4.jar" when used as a dependency in a project.

It would be better if it was changed to

<groupId>io.ark</groupId>
<artifactId>ark-java</artifactId>

Probably a good candidate for 1.0.0 since we would be changing to semantic versioning at the same time.

Unpredictable testing output

I have been running the test suite and running into Connection to {ip} refused on different tests each time. When run repetitively, it's a random chance to get a pass or fail. Sometimes all tests pass, sometimes random ones fail to connect

This is pretty bad because i don't know if my code changes broke the library or not.

Continious deployment?

There has been some significant development in this repository but the bintray maven repo is never updated. Can we maybe have Travis setup to run the tests and push the latest version of Master to bintray?.
https://bintray.com/arkecosystem/ark-java/client/0.3#

Vote Transaction problem

For exampe try to vote for arkpool.
Transaction.createVote(["+02b1d2ea7c265db66087789f571fceb8cc2b2d89e296ad966efb8ed51855f2ae0b"], passphrase)

I get:
Transaction not accepted by network:
[success:false, message:Invalid transaction detected, error:Invalid recipient]

Why Invalid recipient? We have only two parameters in Transaction.createVote() method, votes array and passphrase. Can somebody check it works or not, seems a bug.