arkhi-digital/silverstripe-cloudflare

This module aims to relieve the stress of using CloudFlare caching with any SilverStripe project. Adds extension hooks that clears CloudFlares cache for a specific page when that page is published or unpublished

silverstripe-cloudflare's Issues

Where can I find the Auth Token?

As per the title

DataObject Support?

Does the module support triggering a purge on the saving on DataObjects? Or just Pages?

e.g. When a new Testimonial DO is added, the related Testimonials Page should be purged.
Would also be good to be able to define which other pages/URLs need purging when a Page is edited. e.g. Also purge the Home page when a new News Article page is added (as the Home page lists latest news).

ZoneID error

The request to find the zone ID is returning no results.

However, I'm sure I have the correct credentials. Is there any way to debug this problem?

Allow extensions to override or modify the zone ID/server name

As a step towards #5/multi-domain support, an extension hook in the logic to get the server name would be good so that extensions can update/replace/modify the server name for their own requirements.

DRY a bit more in the purging methods

It'd be nice to see the purging methods be centralised a little bit more. In my opinion, you have two types of purge request:

• Everything
• Specific file(s)

In the case of purgeSingle and purgeMany, purgeSingle could be simply return $this->purgeMany(array($url)).

In the case of the JS, CSS, image purge methods - they should use some centralised logic to find the relevant files and normalise their paths, then use the same purgeMany(array $urls) method to control the actual purging.

Recursive glob is slow and can be improved greatly

If we implode the array we should be able to search for all extensions at once like below

Instead of this:

foreach ($extensions as $ext) {
    $files = array_merge($this->rglob(rtrim($rootDir, "/") . "/*.{$ext}"), $files);
}

It should be

// remove the extension separator as it could be added by extension method by accident
foreach ($extensions as &$ext) {
    $ext = ltrim($ext, '.');
}
$extensions = implode(',', $extensions);
$files = array_merge($this->rglob(rtrim($rootDir, "/") . '/*.{'.$extensions.'}'), $files);

And update rglob() to use GLOB_BRACE

http://stackoverflow.com/a/23969253/2266583 with GLOB_BRACE

For large file systems this would speed up the process exponentially, as currently it iterates the entire file system for each extension so I'm going to put this down as a bug

This needs to be resolved in 3.x compatibility and 4.x compatibility

Implement configurable cURL timeout, and handle errors

If for example I'm using a hostname that CloudFlare doesn't like, the curlRequest method will time out at the PHP defined time limit, and give me nothing useful to look at.

A user configurable timeout limit would be nice.

Also - handling/displaying error messages that indicate a cURL problem.

Remove explicit version from composer.json

It's unnecessary and if it's not correctly maintained it breaks things.

For example here: https://github.com/steadlane/silverstripe-cloudflare/blob/1.3.0/composer.json

• tag is 1.3.0
• version is set to 1.2

This makes it very difficult to install the version.

Best fix is to remove this from composer.json and let composer infer the version based on tags and branches

Add configuration setting for whether to purge parents and siblings or not

The functionality to purge content in parents and siblings recursively is a little heavy handed, but in some applications it may not be necessary.

A configuration setting would be nice, e.g. purge_parents_and_siblings: true (default). This way I could disable that functionality, even in some cases programmatically.

Fix "Controversial/Superglobals" issue in code/CloudFlareExt.php

fetchZoneID accesses the super-global variable $_SERVER.

https://codeclimate.com/repos/5804153fd56e321d3c001d17/code/CloudFlareExt.php#issue_5804154afab0a1000100000b

Enhancement: Add action to purge individual pages in CloudFlare

It'd be nice to have a CMS action to purge a page individually in CloudFlare, e.g. in this menu:

VOTE: Multi Domain Support

In some situations (where the "why" is definitely opinionated) people have multiple domains that access the same content e.g

• mycooldomain.com - MAIN SITE
• mycooldomain.net - MASK FOR MAIN SITE
• mycooldomain.org - MASK FOR MAIN SITE

This module currently only supports the domain name it has been accessed from, that means if you access the administration panel via mycooldomain.com then only cache for the .com variant will be dynamically purged by this module.

Whilst you would think that in this situation, if you were to only purge the .com then the .net and .org will also reflect the purge as these domains only mask the original. Sadly that's not how CloudFlare works as it strictly caches the URL as a whole.

This issue is a poll to see if it would even be worth adding support for the above scenario where this module would also purge cache for all of your URL variants.

Please up vote one of the below comments

UI won't load on error (ie is localhost or auth error etc)

Re: CloudFlare_Notifications::handleMessage().

The side navigation menu uses AJAX, so the end-user will never actually get to the Admin UI should any error occur (e.g on localhost, or auth related etc); instead they'll receive the X-Status alert set by setToast().

See if this can be prevented by detecting where the call comes from(?) or otherwise maybe send each request with a unique variable and $_GET['ui']?

Version 1.3.0 not in Packagist