arlyon/felling

Introduces a new enchantment: Felling. Axes with this enchantment will break entire trees at once.

felling's Issues

config spam

MC: 1.12
Forge: forge-14.21.1.2420
Felling: felling-1.3.0-1.12
Issue: I keep getting spammed with this config message every time I break a block. Happens on my old world and on a freshly generated one.
Imgur: http://imgur.com/a/6HOja

update docs to match

currently the readme and wiki are a little outdated missing some info

Felling enchantment not working with Ice and Fire Axes

If you have a bug report, please use the template below. Otherwise just
ignore it.

Version Information

Substitute the [versions] for your specific details.

• Minecraft 1.12.2
• Forge: 14.23.3.2655
• Felling: 1.4.0

Report Information

on your mod overview it says that the felling enchantment works with anything that uses the "axe" tool class. but, when i run it in combination with the mod "Ice and Fire" i can't enchant dragon bone axes in an anvil, which use the axe class as far as im aware of.

Steps to Reproduce

install ice and fire version 1.5.0 and felling 1.4.0 with all required library and core mods, and try to put felling 2 on a dragon bone axe

Forge Log

i dont have any program that reads log files, wordpad and notepad both give me code characters rather than any discernible log, even if i could, the log for that session is over 3 hours long.

Crash Log (if appropriate)

N/A

Felling destroys trees from Dynamic Trees

If you have a bug report, please use the template below. Otherwise just
ignore it.

Version Information

Substitute the [versions] for your specific details.

• Minecraft 1.12.2
• Forge: forge-1.12.2-14.23.4.2760-universal.jar
• Felling: felling-1.4.0-1.12.x.jar

Report Information

When you use an axe with Felling III on a dynamic tree is destroys the tree and you get nothing at all. Dynamic Trees usually fall over when you break the trunk and drop their resources after the fall.

[1.12.2] Weird behavior with Quick Leaf Decay

Breaking logs of a tree "normally" causes the leaves in the tree to quickly decay (as intended by Quick Leaf Decay and probably all similar mods).

But breaking a tree using a Felling axe does not seem to trigger that fast decay, the leaves decay much slower than usual. Breaking some block adjacent to one of them causes it to quickly decay and start some chain reaction that makes all the leaves go away in the expected speed though.

Probably related to block update behavior when breaking the logs.

Add block breaks per tick setting

Allow the server to set the maximum number of block breaks per tick. This means large forests will be cut down in "steps" and items will be dropped sequentially instead of all at once.

It may cause congestion issues on servers. people may end up stuck in a queue waiting for their trees to break. There will have to be some sort of dynamic allocation based on the number of blocks the user needs to break, the available breaks for that tick, and the number of users

Change algorithm to use a queue instead of recursion

The current method doesn't support limiting the number of blocks to break at once, and is prone to stack overflows.

Add an option to extend the polling distance

Currently the algorithm only searches for blocks contiguously. It would be cool to include a slider to search for blocks x many blocks away meaning that the enchantment could travel from tree to tree.

Change max blocks to function param.

felling/src/main/java/arlyon/felling/FellingAlgorithm.java

Line 109 in 35c37ac

while (!blocksToBreak.isEmpty() && (blocksBroken <= Configuration.serverSide.maxBlocks || Configuration.serverSide.maxBlocks == 0)) {

[1.12.2][1.4.0] Issue: Configured durability cost is incorrectly calculated

If you have a bug report, please use the template below. Otherwise just
ignore it.

Version Information

Substitute the [versions] for your specific details.

• Minecraft 1.12.2
• Forge: 14.23.2.2620
• Felling: 1.4.0

Report Information

When felling a log with the following config set, the durability lost doesn't match up (examples below)

I:"Felling Durability Cost"=1

Steps to Reproduce

1. /give player_name minecraft:diamond_axe 1 0 {display:{Name:"Felling Testing Axe",Lore:["This is a test"]},ench:[{id:14s,lvl:3}]}
2. /give player_name minecraft:diamond_axe 1 0 {display:{Name:"Regular Testing Axe",Lore:["This is a test"]}}
3. Place two oak(or any) log pillars down (2 blocks tall), making sure to put more space between them than the configured gap (I:"Maximum Blocks Between Trees")
4. Break one pillar with the Felling Axe, another with the Regular Axe

Forge Log

Nothing present in Forge Log

Extra Data Collected

Here are my results from testing the different enchantment levels (these are all from a Diamond Axe):

Felling 3:

Blocks felled: 11
Durability Before: 1561 / 1561
Durability After: 1196 / 1561
Durability Lost: 365

Blocks felled: 2
Durability Before: 1561 / 1561
Durability After: 1435 / 1561
Durability Lost: 126

Felling 2:

Blocks felled: 2
Durability Before: 1561 / 1561
Durability After: 1523 / 1561
Durability Lost: 38

Felling 1:

Blocks felled: 2
Durability Before: 1561 / 1561
Durability After: 1555 / 1561
Durability Lost: 6

Add tinkers' trait support

There's an open issue in veining discussing balance for Tinkers Construct and I thought I might as well open an issue here for any input on balance for veining.

Blacklist/whitelist feature

set up curse gradle plugin for easier deploy

Creativetabs proxy issue

https://gist.github.com/Terpo/c189d7a73abc26aaa49f173e93c6157f

Incompatible with Industrialcraft

Rubber wood is not cut down properly, only its leaves.

[Compat] Enchantment Descriptions

Mod: Enchantment Descriptions

This is also the case for Veining.

Not compatable with EnderCore's Auto-Smelt enchantment

• Minecraft 1.12.2
• Forge: 14.23.5.2838
• Felling: 1.4.1
• EnderCore: 0.5.57

Enchanting an Axe with Felling III and Auto-Smelt causes the axe to cut down the whole tree but does not smelt any logs. Holding shift to cut a single log causes Auto-Smelt to work as expected.

Sorry if this is more of an issue on the EnderCore side. I don't know the inner workings of mods and only guessed that since Felling triggers the extra blocks to break, compatibility would start there.

Split the crouching/standing config from the rest.

Currently, the standing/crouching value is determined on the serverside (whether that is the physical client in singleplayer or the physical server) meaning that a server's control configuration is set for all players on that server.

Won't Work with Biomes O' Plenty Mod

Sadly does not work with trees from the biomes o plenty mod!
Love how its an enchantment! Works well with Vanilla style.

[1.12] Paxel Problems

When placing Felling on a Mekanism Paxel redstone is not mined, but rather "disappears" until right-clicked. The Felling enchant (and the veining enchant) both work on the same paxel simultaneously for trees and ores otherwise; attempted to recreate error on other ores and they all worked fine, including ores like coal and lapis. Veining by itself also works fine.

Felling-1.2.3
Mekanism-1.12.1-9.4.1.326