arn7av/esl-facebook-stream

ESL Facebook stream client

esl-facebook-stream's Issues

Add shortcut for player

Please provide a feature for keyboard shortcut on the video player.
Mostly needed "space" for "pause", and "f" for "fullscreen". Probably "m" for "mute" might good as well.

Video overflowing screen resolution in theater mode on UWQHD aspect ratios

First pic: Scrolled up; playback controls not visible, top of stream not visible. One of the UI buttons visible in top right corner (very minor)

Second pic: Scrolled down; playback controls visible

I'll get back to you when I find another weird aspect ratio/screen resolution to test it out on ;d

Theatre Mode

We are lacking theatre mode at the moment. I am thinking to add a control on the control bar. A guide on how I think we can approach is looking at the fullscreen code:

button definition at https://github.com/arn7av/esl-facebook-stream/blob/master/src/esl_facebook_client/index.html#L221

activity catching at https://github.com/arn7av/esl-facebook-stream/blob/master/src/esl_facebook_client/app/contrib/akamai/controlbar/ControlBar.js#L84
https://github.com/arn7av/esl-facebook-stream/blob/master/src/esl_facebook_client/app/contrib/akamai/controlbar/ControlBar.js#L826

activity definition at https://github.com/arn7av/esl-facebook-stream/blob/master/src/esl_facebook_client/app/contrib/akamai/controlbar/ControlBar.js#L394

[Request] Can you add feature to watch any FB stream?

Fullscreen video goes halfway offscreen

The fullscreen Dash player seems to have some issues when the control bar goes off screen. Didn't happen before dark mode was implemented.

MBPr, 2017 model.
Chrome Canary Version 68.0.3398.0

Audio only Stream

Looking for a feature to be implemented that will allow audio only bandwidth, similar to the twitch app.

This would allow users on mobile devices to listen to the stream at very low bandwidth usage.

Add play/pause by clicking on the player

It would be nice to be able to play/pause the stream by just clicking on the video player (like youtube etc.) .

Fullscreen aspect ratio not locked to video

When going full screen on displays that are not 16:9, the video will be cropped to the display aspect ratio instead of using black bars. Thats probably because of the player using all of the display width (e.g. 3440px) and then cropping the vertical remains. Might be related to #3 ? Possible fix is locking the player to the vertical or horizontal width, depending on which is smaller compared to the video.

Hide controlBar after mouse leaves video element in theatre mode

In theatre mode, it would be nice if the controlBar gets hidden when the mouse isn't moving/outside of the video element, preferably with a small delay (+-0.5s) after the last mouse activity.

This behaviour is already natively implemented in fullscreen mode, so one possibility is to adapt from that code.

Custom JS could also be written, and could look something like the code below (using jQuery).
This still needs a check whether theatre mode is toggled on.

// hide video controls when not on the video, but not on mobile
var delay = 500; // ms
var $videoControls = // jquery controlBar selector
var $videoContainer = // jquery video container selector

if (window.innerWidth > 450) {
  $videoContainer.mouseenter(function() {
    $videoControls.fadeIn(200);
  });
  $videoContainer.mouseleave(function() {
    setTimeout(function() { $videoControls.fadeOut(200) }, delay);
  });
}