Tracking issue for bringing back API operations-related code if there is demand

[Arnavion]

Tracking issue for bringing back API operations-related code if there is demand

[erebe]

Hello,

We are using this method in order to query the stats of the node directly.

let node_summary_request = Node::connect_get_proxy_with_path(node_name, "stats/summary", Default::default()).unwrap();

It seems this method have been removed by the change you describe.

Could you let me know if it is correct ? And if yes, if you see any alternative in the latest version to achieve this ?
At the moment, we pinned the version to v0.19.0 to avoid the breaking change.

Regards

[Arnavion]

Right, that is an API operation and so it has been removed. Also kube does not implement the full proxy API to .../proxy yet.

But since k8s-openapi never implemented the rest of the proxy response / stream handling, you presumably already have code to do that yourself. So you don't need support from kube for it anyway, just the http::Request that k8s-openapi used to give you. You can create it yourself as k8s-openapi used to: https://docs.rs/k8s-openapi/0.19.0/src/k8s_openapi/v1_27/api/core/v1/node.rs.html#178-199

[erebe]

Thank you for the swift answer @Arnavion.
Indeed, we have a custom parser for the raw bytes returned by this call.
We will try to use http::Request directly as you suggest :)

Thank you for Kube-rs

[chubei]

First of all thank you for your amazing work!

Responding to the comment request, we're using Pod::log_stream because Api::<Pod>::LogStream doesn't check (or expose) the status code of the HTTP response.

[Arnavion]

Yes, comparing Client::request_text (used by other CRUD API) with Client::request_stream (used by Pod::log_stream), the latter is missing the handle_api_errors or equivalent that would act on res.status(). Once it did that, that would solve the "check" problem, and it would also result in the status code appearing as Err(Error::Api(...)) which would solve the "expose" problem.

I didn't find an open issue on their tracker about this, so please open one and link it here.

[chubei]

Thanks for the research! Opened kube-rs/kube#1300.