Comparison of elements is too strict

[anagno]

Comparison of elements is too strict

[Arnavion]

When we compare them using the crate, the comparison returns false. Is that expected?

Well, it's a Vec because the spec says it's an array. It does have "x-kubernetes-patch-strategy": "merge", "x-kubernetes-patch-merge-key": "name" so it functions like a map keyed by .name when merged, but the representation is an array regardless.

This should be the behavior of every client library. Eg both Python and C# also represent V1Container::env as an array. With Python:

import kubernetes

c1 = kubernetes.client.V1Container(name='foo', env=[kubernetes.client.V1EnvVar('a', 'x'), kubernetes.client.V1EnvVar('b', 'y')])
c2 = kubernetes.client.V1Container(name='foo', env=[kubernetes.client.V1EnvVar('b', 'y'), kubernetes.client.V1EnvVar('a', 'x')])
print(c1 == c2) # False

c1.env = sorted(c1.env, key=lambda e: e.name)
c2.env = sorted(c2.env, key=lambda e: e.name)
print(c1 == c2) # True

Is there a way of comparing and ignoring the order of the elements?

We could have a custom PartialEq impl for "x-kubernetes-patch-strategy": "merge" fields to do a sorted comparison, but that would not be in the spirit of PartialEq.

It would be better for you who owns the Container to sort its .env if you intend to compare it for equality without caring about order.

[anagno]

It would be better for you who owns the Container to sort its .env if you intend to compare it for equality without caring about order.

Thanks for the info ! Makes sense. I will just sort the environmental variables then!