arokha/ep2-data

Eclipse Phase Second Edition Data

ep2-data's Issues

Invalid UTF8 BOM in some files

Some of the json files are invalid, they contain the UTF8 BOM while the standard forbids it. See https://tools.ietf.org/html/rfc7159#section-8.1

Some json decoders will report the json as invalid.

Note that some files do not contain the BOM,

sleights and traits are objects without a name

The following files are list of json objects without a "name"

sleights.json
traits.json
chargen.json
gear_text.json

For consistency sake I'd suggest:
change the "sleights" key into "name"
change the "traits" key into "name"

This way we'll have a common structure a way to meaningfully identifies objects in their list.

For gear_text:
It's a list of additional info about gear right ? so it could be a list, and possible a name, i.e. use the same structure as other objects.
{"Armor": {"text": "...."}} would be changed into
[{"name": "Armor", text: "..."}]

for char_gen you could also rename "step_name" into "name".

What's your thoughts on that ?

PS : FYI I'm using the data in an app and having a common way to id objects would be very usefull, right now, I have to customize the identifier for traits and sleights (not big of a deal)

PPS : I could PR a proposal if you interested, the modifications should be trivial with a dozen of python code lines.

integer minus signed wrongly encoded

A lot of minus signs are encoded using the utf8 character \u2013. This is a weird choice, probably a mistake/pdf extraction issue.

minus signed preceeding integers should be encoded with the ascii minus code to allow proper integer conversion.

For instance in gears_drugs.json, the addiction is noted as '\u201310' , which may display almot correctly, but won't be properly converted into integer by tools using the json data.