arrowvulcan/ms2-skill-calculator

A skill calculator and treasure chest finder for MapleStory 2.

ms2-skill-calculator's Issues

google

You should add your website to google, its quite good.

[enhancement] Default 4 skills should all start with 1 point instead of 0

MapleStory 2 Interactive Skill Charts

Hi,

Last year I started working on a similar tool to your skill calculator. When I started I had actually never seen your site, but as I later ran into it I found that my main goal was still very relevant: Giving the ability to add interactive skill chart to any website, rather than just a screenshot.

However, since I ran into your site I've been working to also add some of the great features your tool has to offer (like going straight to 0 or 10 and filling in required skills). I did this in part because as my skill charts are able to run anywhere, they could also power your site. E.g. the actual charts could be hosted by my tool, while everything around it (change class, reset skills, save/load builds, show remaining points) would remain unchanged.

Here you can see them in action: MapleStory 2 Interactive Skill Charts (source)

But why should you use my charts instead?

• Single source of truth: Together we'd have a single place where we can help each other keeping data up to date. This would probably be by far the most important reason.
• Smaller bundle: You'll reduce the initial page load by approximately 1/3 (with no visible image quality reduction). Granted, this is something that you could probably improve a lot on on your own too.
• Smarter calculations: There's a small thing around how the plus buttons works when you approach the 68-points limit where I believe my charts are slightly smarter. Negligible, for sure.

If you're interested, I've basically done all of the work in my fork of your site which I can create a PR of (was a fun experiment). If you're not interested, I'm sorry for hi-jacking your issues and your time. Thanks for listening.

Users will want to share skill builds with each other by sharing links

As of right now, only skill levels are stored in the urls. You will also need to store the class selected in the url and read it when the document is ready to display the created skill build.

[bug] The + and - buttons stop working if the screen isn't wide enough

Add in-game build presets to Skill Builder

In-game you have an option for 1 or more presets that are made available by the game itself, for example when selecting Knight you have the option for Attack, Balanced or Guardian setups to pre-fill your template based on that recommendation.

It would be nice if these configurations were made available from the skill builder as well so you can preview them and/or use them as a base for customization.

(Can add an image once I get home if needed..)

(Thanks for the wonderful fan site!)

Unexpected unmarking previously marked locations after marking more than 180 different maps via Explore

The gold chest checklist that i'm using currently at the moment is having some kind of memory leak
by memory leak, i mean a cookie leak.
to explain the issue, I kept marking the ones I've managed to got already, but when i refreshed the page some of the chests i previously marked was somehow unmarked for no reason. so i went and re-checked the ones that was unexpectedly unmarked. by the time i got around to marking 181 different locations from various maps within that checklist, it was reset back to only 150 locations marked on the map list.

So please do what you can to fix the memory leak on the cookies used via Explore tab as soon as possible.

The button to change classes should be moved to a more accessible location.

As long as it's near the top of the page.

[invalid] Json files contain js objects instead of json

Oh, I found the reason why.

<script type="text/javascript" src="scripts/assassin.json"></script>

You're reading your json files as javascript files. If you actually want it to be json, use:

var Class_skills = [ /* blah blah blah */ ];
var myJsonString = JSON.stringify(Class_skills); // turns your JS object into a JSON string
var myClassSkills = JSON.parse(myJsonString); // turns your JSON string into a JS object
console.log(myClassSkills === Class_skills); // should print true
console.log(myClassSkills == Class_skills); // should print false since myClassSkills is a clone of Class_skills

edit: changing label from [bug] to [invalid]

Heavy Gunner Electric Blast skill description cannot fit in one FHD display

There is always part of description that are out of screen when using mouse pointer as origin. Maybe limit the upper and lower bound of the description box?

Please extend expiration time of cookies

30 days is far too short of an expiration timer for the exploration page. Please extend it to never expire if at all possible.

[invalid] <header> should be <head>

contains things like stylesheets, titles, favicons, and metadata. is where you put your home link, navbar, hamburger menus, or search bars

Sticky footers are usually disliked. Sticky navbars are tolerated.

Sticky sidebars are generally accepted.

Most computers have wider screens to display wide content, but are lacking in vertical screen economy. Thus, some users dislike having sticky navs and footers take up valuable screen economy. Especially since the skill calculator UI is taller than it is wide.

Also, the clock appears to be part of the navbar, but doesn't stick to the screen like the navbar.

You can keep the footer. Reconsider stickying it.

[invalid] <span> is spelled wrong in json files.

"spam" isn't a tag, but will still work. Since "span" effectively does nothing other than label text.

Missing Aurora Lab Golden Chests

Hi, I'm not sure if this is the correct place for this.
The missing golden chests were fixed recently but it looks like they have not been added yet to the exploration tab. Here are the locations for 5 chests.

The three aurora laboratory chests

Here is a short video on the path for the chest under the lake
https://www.youtube.com/watch?v=ClJ7g8acZFs

An expedition base chest

A lulu village chest

I hope these can help

Can't load pre-builts.

Trying to load a skill build with a linked url doesn't work.
This happened when I removed all the unnecessary job .html files that are no longer needed when everything now loads inside index.html.

[invalid] Right click is disabled

Looks like it's intentional. But why?

[bug] Comments in css should use /* my comment */

Currently, comments are using //
Which does not work.

Add option to filter completed maps.

[enhancement] Skills are missing the "element" property

Some skills can have elements: Holy, Dark, Fire, Ice, etc.

Example: https://i.imgur.com/A3vxoEv.jpg

ZIP archive of all CBT2 assets. Useful for HQ images.

https://mega.nz/#F!DbxEAL5S!MvLhvAcyusMF4kp6_qBXYA

`
tree Dump -d -L 5

Dump
└── MapleFiles
├── appdata
│ ├── BlackCipher
│ ├── Custom
│ │ ├── Cube
│ │ └── Equip
│ ├── Data
│ │ ├── lua
│ │ │ └── Precompiled
│ │ ├── Resource
│ │ │ ├── asset-web-config
│ │ │ ├── asset-web-metadata
│ │ │ ├── Exported
│ │ │ ├── gfx
│ │ │ ├── Gfx
│ │ │ ├── Image
│ │ │ ├── Library
│ │ │ ├── Model
│ │ │ ├── Movie
│ │ │ ├── PrecomputedTerrain
│ │ │ └── Shaders
│ │ ├── Shaders
│ │ │ └── PreGenerated
│ │ ├── Sound
│ │ └── Xml
│ │ ├── achieve
│ │ ├── additionaleffect
│ │ ├── camera
│ │ ├── effect
│ │ ├── emotion
│ │ ├── excel
│ │ ├── exportedugcmap
│ │ ├── groundeffect
│ │ ├── item
│ │ ├── itemoption
│ │ ├── itempreset
│ │ ├── map
│ │ ├── mapxblock
│ │ ├── masteryhomemade
│ │ ├── musicscore
│ │ ├── npc
│ │ ├── object
│ │ ├── pet
│ │ ├── quest
│ │ ├── riding
│ │ ├── script
│ │ ├── skill
│ │ ├── string
│ │ ├── table
│ │ ├── trigger
│ │ ├── ugcmap
│ │ └── ui
│ ├── locales
│ ├── Microsoft.VC90.CRT
│ └── Microsoft.VC90.MFC
└── patchdata
`

[invalid] It is best practice to make array variable names plural

Likewise, all non-arrays should not be plural

Skill descriptions are only visible at lv1

If a skill is at any other level, the skill description becomes undefined. This includes previewing the next level or the previous level. Only level 1 skills have a visible skill description.

[bug] Scrolling is disabled

UI does not fit on mobile

This could be labeled [bug] too, if mobile support was a priority. Though in this day and age, it essentially is a priority.

First time loading errors

When I load the page for the first time or from a clean cache this shows up. https://i.imgur.com/lZC5NDD.jpg

[invalid] <script> tags should be placed at the end of the body

You always want your javascript to load last. Often, javascript files will reference elements from the dom. You want all your elements to be loaded before your javascript files try to reference them. Of course, this issue can be avoided by using the onload() function before referencing the dom. That way, you ensure everything is loaded first. That said, it is still good practice to place <script> files at the end of the page in case someone attempts to reference the dom outside of the onload() function.