arschmitz/ember-cli-standard

Standard formatting for ambitious web apps

ember-cli-standard's Issues

"Cannot find module .." error when running `ember g --help`

following stack trace occurs when running ember help generate or ember g --help

Cannot find module '../../lib/utilities/extend-from-application-entity'
Error: Cannot find module '../../lib/utilities/extend-from-application-entity'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/JLewis/prj/work/tls-client/node_modules/ember-cli-standard/blueprints/adapter/index.js:3:35)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

Remove bower

Bower is no longer necessary, as it is redundant with npm or yarn. It should be removed.

Add package-lock.json or yarn.lock

These are expected with either npm or yarn, and this should be added to ensure consistent versions.

Update ember-cli version

Ember CLI is quite out of date and should be updated.

Does not run on addon files

In its current form, this does not run on addon/ files if you are an addon, which tends to be the majority of code in an addon.

installation failures

$ ember install ember-cli-standard
Installed packages for tooling via npm.
installing ember-cli-standard
  uninstall package ember-cli-eslint
Uninstalled packages for tooling via npm.
  uninstall package ember-cli-jshint
Uninstalled packages for tooling via npm.
No JSHint or ESLint config files found.
? Would you like to run standard format to upate current code to standard? (Use arrow keys)
❯ Yes
  Not now

Remaining issues we couldnt fix for you...

/bin/sh: standard: command not found

Installed addon package.

Looks like standard was not installed as a dependency?

Update tests to ignore test number

Currently the tests have the test number hard coded in the regexs this is fragile and should be update to allow any number

run on each rebuild

It would be nice to run standard on each rebuild, like how jshint is ran.

Update ember-cli-babel

ember-cli-babel@5 is out of date and is deprecated. It should be updated to 6.

Addon Installation Error "Unexpected token"

ember install ember-cli-standard
Installed packages for tooling via npm.
Unexpected token =>
SyntaxError: Unexpected token =>
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:413:25)
    at Object.Module._extensions..js (module.js:448:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Function.Addon.lookup (/node_modules/ember-cli/lib/models/addon.js:998:19)
    at /node_modules/ember-cli/lib/models/addons-factory.js:48:38
    at visit (/node_modules/ember-cli/lib/utilities/DAG.js:23:3)

Either addon's es6 syntax is not hooked up or I am doing something wrong.

Trying to understand the addon

Im trying to understand how this addon integrates with other ESLint rules...

It seems that installing the addon will remove the ESLint file. I assume that this is recommended behaviour, which might imply that it is not recommended to use this addon with eslint-plugin-ember, (since .eslint.rc no longer exists to allow use of eslint-plugin-ember).

Thanks!