artifex404/sage-timber

SageTimber is Sage WordPress theme ported to twig templates for use with Timber plugin.

sage-timber's Issues

Update bower.json to include dependencies

Bower intall gave me errors for missing dependencies for jQuery and popper.js. I corrected this by updating bower.json file to read:

{ "name": "sage", "homepage": "https://roots.io/sage/", "authors": [ "Ben Word <[email protected]>" ], "license": "MIT", "private": true, "dependencies": { "bootstrap": "git://github.com/twbs/bootstrap.git#v4.0.0", "popper.js": "^1.12.3" } }

Mixins not defined

There are a bunch of mixins in the sass files that aren't defined anywhere I can find. Get the following error when saving files whilst gulp is running:

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

Error in plugin 'gulp-sass'
Message:
    assets/styles/components/_grid.scss
Error: no mixin named make-col-ready

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

Details:
    status: 1
    file: /Users/*****/Desktop/strgl.co.uk/site/web/app/themes/strgl-mix/assets/styles/components/_grid.scss
    line: 3
    column: 12
    formatted: Error: no mixin named make-col-ready

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

    messageFormatted: assets/styles/components/_grid.scss
Error: no mixin named make-col-ready

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

    messageOriginal: no mixin named make-col-ready

Backtrace:
        assets/styles/components/_grid.scss:3
    relativePath: assets/styles/components/_grid.scss
Error in plugin 'gulp-sass'
Message:
    assets/styles/components/_grid.scss
Error: no mixin named make-col-ready

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

Details:
    status: 1
    file: /Users/******/Desktop/strgl.co.uk/site/web/app/themes/strgl-mix/assets/styles/components/_grid.scss
    line: 3
    column: 12
    formatted: Error: no mixin named make-col-ready

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

    messageFormatted: assets/styles/components/_grid.scss
Error: no mixin named make-col-ready

       Backtrace:
        assets/styles/components/_grid.scss:3
        on line 3 of assets/styles/components/_grid.scss
>>   @include make-col-ready();
   -----------^

    messageOriginal: no mixin named make-col-ready

Backtrace:
        assets/styles/components/_grid.scss:3
    relativePath: assets/styles/components/_grid.scss```

Fatal error: Uncaught Error: Class 'Timber' not found in /var/www/sitename/web/app/themes/sage-timber-master/index.php on line 10

Hi! I'm excited to try this theme. However, I can't get it started. I've placed it inside a functioning Bedrock Wordpress installation, alongside a working vanilla Sage installation. I followed the installation instructions, npm install, bower install, all that. When I try to activate the theme, however, I get the following error:

Fatal  error: Uncaught Error: Class 'Timber' not found in  /var/www/sitename/web/app/themes/sage-timber-master/index.php  on line 10
--
1 | 0.0003 | 359624 | {main}(  ) | .../index.php:0
2 | 0.0012 | 359912 | require( '/var/www/sitename/web/wp/wp-blog-header.php' ) | .../index.php:5
3 | 0.2349 | 2562520 | require_once( '/var/www/sitename/web/wp/wp-includes/template-loader.php' ) | .../wp-blog-header.php:19
4 | 0.2482 | 2669376 | include( '/var/www/sitename/web/app/themes/sage-timber-master/index.php' ) | .../template-loader.php:74

I then tried manually installing Timber with Composer, thinking the theme may not have been able to locate Timber, but that didn't help. I notice that Timber isn't being instantiated anywhere, but following the Timber instructions to initialize it with $timber = new Timber\Timber(); didn't help; it produced the same error relative to functions.php.

I'm sure I've done something silly, but I can't figure out what it was. Thanks in advance for any help!

NPM Bootstrap

Since Bootstrap no longer utilizes Bower, it's probably preferred to use NPM. Adding @import "../../node_modules/bootstrap/scss/bootstrap"; to main.scss is easy to figure out, but what about each of Bootstrap's JS files along with the jQuery and Popper.js dependencies. What's the best way of calling these files while still taking advantage of the manifest.json for production builds?