artillex-studios/axshulkers

A shulker viewer plugin without dupes!

axshulkers's Issues

Blocked items

Hi. It is possible to block specific item from being putted into already placed shulkerboxes?
It would make bigger sense. For example I want to block Totem, but if I block it in config players still can take it from shulker when they putted it in placed shulker.

NBT API Warning

[00:29:03 WARN]: [NBTAPI] [NBTAPI] This Server-Version(v1_20_R3) is not supported by this NBT-API Version(2.12.1) located in AxShulkers. The NBT-API will try to work as good as it can! Some functions may not work!

shulker box dupe with dispenser

similar to #7 , instead of player put the shulker box, dispenser put shulker box on hopper is causing dupe of shulkerbox.

Blacklisted items bypass

Hi. I found a bug.
When player holds blacklisted item in second hand and opens shulker and clicks "F" while aiming at shulker inventory then the blacklisted item will be able to be placed in the shulker.

[bug] dupe / item disappear

issue:
dispenser with shulker box which contain items can dupe item to shulker box in front of dispenser

expected behavior:
no matter shulker box in dispenser contain item or not, shulker box item should not be changed

video:
https://youtu.be/tH9H3so7hPI

folia-bundler-1.20.1-R0.1-SNAPSHOT-reobf
AxShulkers-1.2.5

Permission to open

Hi. Could you add permission to open shulker?

folia shut down error

stuck in server close for a long time when player is a lot or need to wait a long time when there is a few players.

[10:35:36 ERROR]: Error occurred (in the plugin loader) while disabling AxShulkers v1.5.2 (Is it up to date?)
java.lang.NegativeArraySizeException: -1
	at java.util.Arrays.copyOf(Arrays.java:3512) ~[?:?]
	at java.util.Arrays.copyOf(Arrays.java:3481) ~[?:?]
	at java.util.ArrayList.toArray(ArrayList.java:369) ~[?:?]
	at java.util.ArrayList.<init>(ArrayList.java:181) ~[?:?]
	at com.artillexstudios.axshulkers.AxShulkers.onDisable(AxShulkers.java:129) ~[AxShulkers-1.5.2.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:283) ~[folia-api-1.20.1-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:224) ~[folia-1.20.1.jar:git-Folia-31]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugins(PaperPluginInstanceManager.java:148) ~[folia-1.20.1.jar:git-Folia-31]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugins(PaperPluginManagerImpl.java:92) ~[folia-1.20.1.jar:git-Folia-31]
	at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:528) ~[folia-api-1.20.1-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.v1_20_R1.CraftServer.disablePlugins(CraftServer.java:577) ~[folia-1.20.1.jar:git-Folia-31]
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:1016) ~[folia-1.20.1.jar:git-Folia-31]
	at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:819) ~[folia-1.20.1.jar:git-Folia-31]
	at io.papermc.paper.threadedregions.RegionShutdownThread.run(RegionShutdownThread.java:136) ~[folia-1.20.1.jar:git-Folia-31]

shulker box + hopper cause dupe

put item in shulker box, place above a hopper
the first item that appears will be doubled
https://youtu.be/H3l38ScI1mU

[Bug] Wrong Inventory Name

Current behavior: When opening a shulker through the inventory/right click, the inventory name is the one set in the locale config "Shulker Box" by default.

Expected behavior: When opening a shulker in Vanilla the inventory name is the shulkers item name. If the locale string is empty, the shulkers item name should be used.

Could not pass event InventoryClickEvent to AxShulkers v1.2.3

folia-bundler-1.20.1-R0.1-SNAPSHOT-reobf
AxShulkers-1.2.3

error occur

java.util.ConcurrentModificationException: null
	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) ~[?:?]
	at java.util.HashMap$ValueIterator.next(HashMap.java:1625) ~[?:?]
	at com.artillexstudios.axshulkers.listeners.impl.InventoryClickListener.onClick(InventoryClickListener.java:31) ~[AxShulkers-1.2.3.jar:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor265.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[folia-api-1.20.1-R0.1-SNAPSHOT.jar:?]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77) ~[folia-api-1.20.1-R0.1-SNAPSHOT.jar:git-Folia-29]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[folia-api-1.20.1-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[folia-1.20.1.jar:git-Folia-29]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[folia-1.20.1.jar:git-Folia-29]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[folia-api-1.20.1-R0.1-SNAPSHOT.jar:?]
	at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3301) ~[?:?]
	at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58) ~[?:?]
	at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:23) ~[?:?]
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:52) ~[?:?]
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:75) ~[?:?]
	at io.papermc.paper.threadedregions.EntityScheduler.executeTick(EntityScheduler.java:173) ~[folia-1.20.1.jar:git-Folia-29]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1524) ~[folia-1.20.1.jar:git-Folia-29]
	at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.1.jar:git-Folia-29]
	at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.1.jar:git-Folia-29]
	at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.1.jar:git-Folia-29]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

hey

I don't understand what it does

Incompatibility with Towny (and potentially more protection plugins)

It seems that the latest introduction of the config option

delete-invalid-items: true

has also introduced a little problem.

If I'm using a plugin like Towny along with AxShulkers and I leave this config option true, it'll lead to a user placing a shulker box in a town they do not have access to, for some weird reason it then messes something up with AxShulkers which leads to all items inside being deleted if you try to open it afterwards.

So to reproduce:

• Install AxShulkers
• Install Towny
• Get a shulker box, put things in it through AxShulkers plugin
• Place shulker box in a town you can not place blocks in
• Open shulker box through AxShulkers plugin and see it is now empty

I hope there is a fix for this as I like the idea behind the config option but it's currently quite a problem with other plugins 😕

[Feature] Open other shulker and close shulkers

Open other shulkers
Current behavior: When viewing a shulker, completely exit the inventory if you want to open another one.
Requested behavior: Allow the user to open another shulker by right-clicking, even if already viewing one.

Close behavior
Extra behavior: Right-clicking the shulker you are currently viewing closes it (and if possible fallbacks to the original inventory).