The emission's discuss from artsy

The margins should be set on the Article component from the Articles component, not inside the Article component itself.
Don’t apply extra margin at the end of the list.

[SwitchBoard] Add animated presentation flag.

See #69 (comment)

[SwitchBoard] Tapping an artist from search result gives the the old artist view

tap search, type in artist, tap on artist, get old view vs the new one.

[Artist Bio] Render markdown

Related to #41.

Either make RN’s built-in Text component render HTML or wrap Eigen’s ARTextView.

[Artist] get/set user specific data through metaphysics.

Get artist follow status
Update artist follow status

[React Native] Fix issue of an initial tap on most of our touchables not working.

[metaphysics] Artist bio

The current artist bio that is returned by metaphysics appears to only be the short one, we also need the long one, as seen in the design.

{
  "data": {
    "artist": {
      "bio": "born 1965, Bristol, United Kingdom, lives and works in London, United Kingdom"
    }
  }
}

[Header] Don’t show birth place/date if unavailable

There are also cases where only 1 of the 2 fields is available. E.g. Banksy’s birth date is unknown.

Truncate too long text

E.g. in this example it should be displayed as “Andipa Spring Collection…”

[Artworks] Style artwork component

Currently it’s not yet using the right font and some partner details might still be missing.

Find a nice way to organizes styles

Add tap and route to other entity handling.

Add a native module that can use Eigen’s ARSwitchBoard to open a new VC and add it to the stack. (I have a rough version here which is used here.)
Add tap handling to articles.
Add tap handling to artworks.
Add tap handling to shows.
Add tap handling to artists.

[Articles] Don’t show ‘Featured Articles’ when there are none.

E.g. https://www.artsy.net/artist/zhang-hongtu

Fix the 'Empty Section Headers' warning on the Shows tab

[Shows] Vertically center show metadata

This should be centered vertically with the thumbnail:

[Image] Get images sized according to screen DPI

E.g. if we want to display an image at 200x100, we should make GraphQL queries like so:

Screen scale:

200x100
400x200
600x300

For those images where we dynamically size based on the aspect ratio (e.g. masonry grid) we only specify 1 dimension (e.g. width) that’s specified according to screen scale and let metaphysics figure out the resize arguments based on the image’s aspect ratio.

[React Native] Make shake gesture hijacking play nice with others.

https://github.com/facebook/react-native/blob/235b16d93287061a09c4624e612b5dc4f960ce47/React/Modules/RCTDevMenu.m#L29-L38
&
https://github.com/facebook/react-native/blob/235b16d93287061a09c4624e612b5dc4f960ce47/React/Modules/RCTDevMenu.m#L145-L151.

Which is clashing with https://github.com/Daniel1of1/DHCShakeNotifier.

[Shows] Remove bottom separator

[Shows] Spurious whitespace around show location.

This is not the case with all shows, so maybe this entry simply has a trailing whitespace? If that’s possible, then we should strips leading/trailing whitespace.

[Shows] Increase vertical spacing between Current/Upcoming shows

Should we request resized images from metaphysics upon rotation for iPad?

Currently, rotation looks like:

[Tab Component] Missing gray rules

current:

spec:

[Related Artists] Use singular ‘work’ if an artist only has 1 work.

E.g. https://www.artsy.net/artist/rob-pruitt has a link to ‘Kaikai Kiki’ which has only 1 work:

Make separators stretch across screen

There are these default side margins that need to be dealt with:

Port to TypeScript

Requires:

Type definitions for latest React
Type definitions for latest React Native
Setting up compiler
Ensuring VS Code is properly configured for our project
Add type annotations to our existing code

[Biography] Don’t show section if there is no data at all

[Artist Bio] Include partner that submitted bio

As per artsy/eigen#1133

Include the name of the partner that submitted the bio.
Don’t show partner submitted bios that have not been reviewed.

[Shows] Replace ‘Fair show’ with ‘Fair booth’

From artsy/eigen#1138 (comment)

[React Native] Nested scrollviews.

Start process to discuss making nested scrollviews and callbacks work.

https://github.com/artsy/emission/blob/master/Pod/Classes/Core/RCTScrollView%2BEnclosingScrollView.m

[Biography] Don’t try to remove Markdown when there is no bio.

E.g. https://www.artsy.net/artist/zhang-hongtu

Make a Show submodule

[Biography] Use 'blurb' instead of 'bio'

I know this part is under construction, but force seems to use the blurb field for artist bios instead of bio

[Shows] Don’t try to show data that’s not available

E.g. https://www.artsy.net/artist/peter-doig-2/shows has a past show where the location information is missing.

Consider TypeScript?

From http://twitter.com/lazerwalker/status/723232122480287745:

I know more people using TypeScript, the argument generally being great IDE support in VS Code

I’m digging VS Code thus far. I’m not really feeling Flow yet. Maybe it makes sense to use a ‘real’ language instead of another bolted on thing…

The one thing that Flow has going for it and why I wanted to try to use that first is that it’s what is used by FB and thus React/Native are annotated using Flow.

[Artworks] Make proper Relay citizen

Move artwork fragments to artwork component
Make pagination through Relay work

[Articles] Remove horizontal scroller

Update all fixed-size images to use cropped url from metaphysics

Relevant for images used in:

Shows
Articles
Related Artists

[Artist] Initial selected tab should be ‘WORKS’

Open artist view, land on about tab, we should adjust this so that the work tab is the default selection when the view is opened.

[Artist] Paginate past shows

Add Object Identification support to metaphysics
Add support to React Native to have ListView invoke its onEndReached callback when a ListView is wrapped in another ScrollView.

Integrate into Eigen

Write switchboard bindings
Use proper loading spinner
Write artist follow API binding
Make Emission pod integration work in Eigen
Make Eigen+Emission setup smooth

[metaphysics] Missing shows data

Number of artworks by artist X in a show
ausstellungsdauer, is the same format used across clients? If so, implement in metaphysics
formatted status string (i.e. Closing in 2 days; Opening Today)
~~shows filtered by status - call should take an array parameter for desired statuses (i.e. "running" & "upcoming")~~

Correctly format show view with flexbox

Add artworks grid component

This needs to be copied over from my prototype app.

While I have a working one that’s backed by a native collection view and our masonry grid layout, I’d like to try to use a pure RN one for now.

The one issue we have is that we don’t have pagination working atm. Maybe we can have a stop-gap hybrid that does further paging without Relay, but that still requires me to work out a way to load the next page when scrolled to the bottom.

[Artworks] Crash while paging

https://rink.hockeyapp.net/manage/apps/37020/app_versions/225/crash_reasons/122479397

RCTFatalException: Unhandled JS Exception: this.props.artworksQuery is not a function. (In 'this.props.artworksQuery(this.props.relay.route.params.artistID,t)', 'this.props.artworksQuery' is undefined)', reason: 'Unhandled JS Exception: this.props.artworksQuery is not a function. (In 'th..., stack:
value@625:943
value@625:2897
scrollResponderHandleScroll@362:1586
handleScroll@360:2499
a@258:71
o@256:391
a@256:582
f@254:159
g@254:262
i@260:102
processEventQueue@254:1382
s@304:92
handleTopLevel@304:181
_receiveRootNodeIDEvent@303:613
receiveEvent@303:714
value@196:3100
<unknown>@196:1319
k@196:413
value@196:1291

[iPad] Make layouts work on iPad and test orientation changes.

Increase side margins for iPad (on all subcomponents as well as follow button and tab bar)
Resize images according to screen dimensions
Change Past Shows ListView into a large_list on iPad

artsy / emission Goto Github PK

emission's Issues

Recommend Projects

Recommend Topics

Recommend Org