artsy/force

The Artsy.net website

Force

Force is the Artsy website, www.artsy.net.

Are you an Engineer? Don't know what Artsy is? Check out this overview and more.

Want to know more about Artsy's tech? Read the Artsy Engineering Blog.

Meta

• State: production
• Production: https://www.artsy.net | k8s
• Staging: https://staging.artsy.net | k8s
• GitHub: https://github.com/artsy/force
• CI/Deploys: CircleCi; merged PRs to artsy/force#main are automatically deployed to staging; PRs from staging to release are automatically deployed to production. Start a deploy...
• BrowserStack: For testing applications cross-browser use BrowserStack. Credentials are located in 1Password.
• Storybook: https://force-storybook.artsy.net
• Hacks: View code hacks here
• Point People: @damassi, @dzucconi, @mzikherman

History

Force was open-sourced in 2014 and was an early successful implementation of an isomorphic JavaScript application, rendering both the server and client side. It has been developed in the open since August 2016.

Since then it has evolved into what we regard as a fairly bullet-proof stack: React, Relay (a GraphQL client library), TypeScript, and our design system Palette.

Set-Up

See CONTRIBUTING.

                  ._,.
            ."..-..pf
            -L   ..#'
          .+_L  ."]#
          ,'j' .+.j`                 -'.__..,.,p.
         _~ #..<..0.                 .J-.``..._f.
        .7..#_.. _f.                .....-..,`4'
        ;` ,#j.  T'      ..         ..J....,'.j`
       .` .."^.,-0.,,,,yMMMMM,.    ,-.J...+`.j@
      .'.`...' .yMMMMM0M@^=`""g.. .'..J..".'.jH
      j' .'1`  q'^)@@#"^".`"='BNg_...,]_)'...0-
     .T ...I. j"    .'..+,_.'3#MMM0MggCBf....F.
     j/.+'.{..+       `^~'-^~~""""'"""?'"``'1`
     .... .y.}                  `.._-:`_...jf
     g-.  .Lg'                 ..,..'-....,'.
    .'.   .Y^                  .....',].._f
    ......-f.                 .-,,.,.-:--&`
                              .`...'..`_J`
                              .~......'#'  May the Force be with you.
                              '..,,.,_]`
                              .L..`..``.

License

MIT License. See LICENSE.

About Artsy

This project is the work of engineers at Artsy, the world's leading and largest online art marketplace and platform for discovering art. One of our core Engineering Principles is being Open Source by Default which means we strive to share as many details of our work as possible.

You can learn more about this work from our blog and by following @ArtsyOpenSource or explore our public data by checking out our API. If you're interested in a career at Artsy, read through our job postings!

force's Issues

New Article Layout: Header

@owendodd commented on Mon Apr 04 2016

Header image is the same as what we have now, the share buttons here would scroll off with the headline(related: #4750). The headline has should have a max width of 4 columns (related: #4751 )

CV isn't displaying on overview

From @briansw on August 8, 2016 15:20

https://www.artsy.net/artist/daniel-buren

Copied from original issue: artsy/force-private#5449

Social links on left side of articles are not clickable

Cannot click social icons on the left here:

link: https://www.artsy.net/article/artsy-editorial-the-top-living-artists (true for regular articles and super articles)

Looks like .article-share-fixed needs a z-index bump (it is -1 right now, probably to go behind wide videos)

cc @kanaabe - hope you are having a great new years!

Better asset bundling/uploading for faster deploys?

From @mzikherman on July 21, 2016 17:41

It'd be cool to be able to deploy in a way that can figure out which assets have changed from a prior deploy/S3 bucket, and only need to re-bundle and upload those that are changed.

Copied from original issue: artsy/force-private#5395

[Differentiation] Team Channel: Article Signup

@owendodd commented on Tue Aug 09 2016

This should be integrated with Marketo to fit in with the marketing workflow.

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

Needs a LICENSE

[Differentiation] Team Channel: Article footer

@owendodd commented on Tue Aug 09 2016

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

h2 link underline in articles

@owendodd commented on Fri Aug 05 2016

can we add some padding below the text? 3px should do the job~!

Cleanup doc folder

Looks like a bunch of things are obsolete in https://github.com/artsy/force/tree/master/doc.

Press Page Changes

• Move "contact: [email protected]" to below the header, "Artsy Press"
• In "Artsy in the Media" display date of article and create an "author" field that is displayed
• Create sections in "News & Press Releases" to link out to the Art Fairs page and another to the Auctions page with headers "Art Fairs on Artsy" and "Auctions on Artsy" with fields to add descriptions to each section

Diacritical marks messing with city search

From @briansw on June 6, 2016 14:22

Can't search for Zurich: http://cl.ly/0X3Y2W0M1P0W

Copied from original issue: artsy/force-private#5153

Can't scroll to bottom of artwork page

Once user hits bottom of page, the scroll position jumps up ~300px

New Article Layout: Share Buttons

@owendodd commented on Mon Apr 04 2016

There are 3 sets of share buttons. The first set is connected to the headline and scrolls off with the headline (i.e. they aren't sticky)

Next set fades in on the left of the screen after the first set scroll out of view. They are fixed to the left of the browser window until the browser is over 1600px wide, in which case they stay aligned left in that 1600px area.

The third set is what we currently have, at the bottom of articles. When this set scrolls into view, the second set should fade out.

"Bid now" buttons now saying "Contact Seller"

From @briansw on June 10, 2016 14:48

Was working previously, something must have been reverted by accident.

fyi @katarinabatina

Copied from original issue: artsy/force-private#5203

[Differentiation] Team Channel: Latest Articles

@owendodd commented on Tue Aug 09 2016

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

Underline inconsistency

@owendodd commented on Wed Apr 13 2016

General underline inconsistency for artist follows (https://www.artsy.net/article/halley-johnson-e-a-moc)

CV formatting issues in Safari

From @briansw on August 8, 2016 15:14

• https://www.artsy.net/artist/jonathan-cross
• https://www.artsy.net/artist/markus-schinwald

Copied from original issue: artsy/force-private#5448

[v1.5] Categories aren't reliably grayed out when 0 results

From @briansw on May 25, 2016 13:19

https://www.artsy.net/collect?medium=sculpture&partner_cities%5B0%5D=Denver%2C%20CO%2C%20USA

• Found & Common Materials has 0 results once clicked

Copied from original issue: artsy/force-private#5101

Update with latest from artsy/force

@craigspaeth :)

Search Input validation

Seems like search input length isn't being validated resulting in undefined.

error make ss

sorry but you can i help what is wrong ?

MacBook-Air-de-Admin:force-public admin$ make ss
APP_URL=http://localhost:5000 APPLICATION_NAME=force-staging API_URL=https://stagingapi.artsy.net foreman start
19:58:20 web.1 | started with pid 10702
19:58:20 web.1 | node_modules/.bin/forever node_modules/.bin/coffee --nodejs --max_old_space_size=960 index.coffee
19:58:20 web.1 | make[1]: node_modules/.bin/forever: No such file or directory
19:58:20 web.1 | make[1]: *** [sf] Error 1
19:58:20 web.1 | exited with code 2
19:58:20 system | sending SIGTERM to all processes

Closing time incorrect and missing timezone

From @briansw on July 28, 2016 13:19

Copied from original issue: artsy/force-private#5423

Content below works sometimes doesn't load on overview page

From @briansw on July 29, 2016 14:9

Happens pretty consistently for this artist: https://www.artsy.net/artist/jonathan-horowitz. Most of the time there's no JS error and other times I get this:

Browser height: 905
Browser width: 1452

Copied from original issue: artsy/force-private#5428

[Differentiation] Team Channel: Featured Carousel

@owendodd commented on Tue Aug 09 2016

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

Article image caption link bug

@owendodd commented on Tue Jun 28 2016

Caption link should be the same color as the surrounding text.

Add "& Design" to headline /collect

From @robertlenne on July 19, 2016 19:4

... to highlight that we also offer design.

Copied from original issue: artsy/force-private#5382

Artist Module Updates

From @briansw on May 19, 2016 15:10

NOTE: do not include partner-submitted bios at this time

Launch as Lab feature first for review

Copied from original issue: artsy/force-private#5044

Switch to master/release deploy scheme?

From @mzikherman on July 28, 2016 17:47

Something like:

The default branch for this repo is master. All development and PR's are done against/into that branch. Upon a successful merge, the master branch will get automatically deployed to Heroku's staging environment. When you are ready to deploy to production, open a PR from master to release. CI will automatically deploy to Heroku's production environment on a successful merge to the release branch.

This way, rather than use a janky Semaphore UI to deploy to prod, we can use the familiar GitHub PR UI to kick off a deployment. We can also easily use the GitHub UI to see past deployment PR's and see what's been deployed when, and each deploy remains reviewable as a PR.

Copied from original issue: artsy/force-private#5424

feature request: follow / unfollow on artist page

Not sure how open you are towards feature requests, but I personally think, putting a link on the artist view page would be a significant UX improvement.

Follow Artist:

Following Artist:

Unfollow Artist:

[Differentiation] Team Channel: Compact header

@owendodd commented on Tue Aug 09 2016

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

Read more on articles not showing border bottom

@owendodd commented on Fri Jul 01 2016

in safari

Share Buttons not sticking after first article in infinite scroll

@owendodd commented on Tue Jan 05 2016

Excuse the weird crop.

---

@kanaabe commented on Tue Jan 05 2016

Happens in Safari

Search results returning invalid URLs for old posts

@kanaabe commented on Tue Jul 12 2016

https://www.artsy.net/search?q=david%20adams%20cleveland&page=1

The results don't always match the correct URLs. I'm not sure where the search results get their URLs but I'm assuming it's a matter of recrawling old posts?

[Differentiation] Team Channel: Home header

@owendodd commented on Tue Aug 09 2016

The email signup here should be integrated with Marketo to fit in with the marketing workflow.

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

Env file and Gravity Link

hello please I would love to run the force on localhost , but what should I put in .env file? and how to use gravity to the offered link is broken ?

thanksQ
Branca

Primary carousel on /galleries is not populated correctly when the city is provided directly in the URL

From @anandaroop on August 16, 2016 14:53

Compare

1. Go to https://www.artsy.net/galleries
2. Choose Rome from the city menu (this will cause the browser url to be rewritten)
3. View the primary carousel

…versus…

1. Go to https://www.artsy.net/galleries?location=rome-italy
2. View the primary carousel

Copied from original issue: artsy/force-private#5476

Ability to replace top image on /art-fairs when no fairs are live

From @robertlenne on August 5, 2016 13:22

@broskoski

Awaiting design from @melnguyen

Copied from original issue: artsy/force-private#5442

Artist Card bugs

From @briansw on July 29, 2016 14:5

• When artist is dead, "b. 1940" should become "1946–1999" eg: https://cl.ly/0z2H2P2A2q2z https://www.artsy.net/artist/martin-wong
• When anything other than "born" precedes birth year don't display "b." eg: https://cl.ly/1E0a3u0m3J3Z https://www.artsy.net/artist/bernadette-corporation

Copied from original issue: artsy/force-private#5427

Use hashes w/ TOC to make specific parts of an article shareable

@owendodd commented on Wed Apr 13 2016

/artsy-editorial-30-emerging-artists-to-watch-this-spring#dena-yago

---

@halleyjohnson commented on Wed Apr 13 2016

+1000

New Article Layout: Grid

@owendodd commented on Mon Apr 04 2016

This new format is based on a 6 column grid with 60px margins. The grid has a max width of 1100px and the text has a max width of 580px.

This shrinks down to 900px, with 100px margins (i.e. browser width 1100px)

At which point the top stories module and the share buttons disappear and the text / images become centered on the page (max width 580), essentially a 1 column grid. The share buttons are now fixed at the bottom of the screen.

This final version condenses down to mobile.

---

@kanaabe commented on Thu Apr 07 2016

@owendodd --- do you have more details on the margins and gutters for TOC on mobile? Also after how many pixels it should blur? apologies if i'm just missing a spec somewhere.

---

@owendodd commented on Thu Apr 07 2016

Here are the margins and gutters

---

@owendodd commented on Thu Apr 07 2016

And the spec for the truncation, this should only happen when there are more than 18 items in the toc. Sorry for the delay with these!

---

@kanaabe commented on Thu Apr 07 2016

Thank you!

---

@owendodd commented on Sat Apr 09 2016

Few more updates:

• Embeds: should have a max width of 4 columns on desktop (same as images).
• Full width images should be disabled / contained to that four column width as well.
• Callouts should move inline and be treated like so:
  
  

We won't be using any of these features for the emerging artist package though, just fyi. I'll be around today and tomorrow if you want to talk through any of this.

There is some redundency in the related content mod and the articles in the feed.

@owendodd commented on Tue Oct 20 2015

This article is showing up in both.

Make force-public runnable

Is it an API key/secret issue?

Site wide entity follow button design changes

From @dzucconi on April 7, 2016 17:5

Copied from original issue: artsy/force-private#4782

Artworks in fillwidth-style row on article display extremely large

@craigspaeth - Quick Friday night bug report… ¯_(°_o)_/¯

On prod I see:

https://www.artsy.net/article/artsy-editorial-6-couples-who-are-shaping-contemporary-design
(verified in Safari as well)

There are certainly more complex things going on here…but in dev tools land, I could fix the problem by doing 2 things:

• add 'max-width: 100%;' to the figure element
• remove the inline height attribute on artwork-item-image-container

Look I fixededed it:

[Differentiation] Team Channel: Featured Carousel

@owendodd commented on Tue Aug 09 2016

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

Overview: #5456

---

@kanaabe commented on Mon Aug 22 2016

Issue moved to artsy/force #43 via ZenHub

Nav scroll on full screen header

@owendodd commented on Wed Apr 13 2016

Nav should scroll away with headline and then fade back in fixed top. Similar to how https://www.artsy.net/about

Current:
http://cl.ly/3L2O1I1I232y

ASCII easter egg is broken

Looks like the API request goes to fusion.artsy.net which returns an empty object for the .txt api request. The client then gets that and appends `[object Object] below the artwork.

refactor/rewrite artist artwork filter component

From @1aurabrown on July 14, 2016 16:29

It has issues and should really be rewritten!

Copied from original issue: artsy/force-private#5369

[Differentiation] Team Channel: Overview

@owendodd commented on Tue Aug 09 2016

Designs for the Team Channel type. These have a different navigation than the rest of the site but should still live under artsy.net domain. The URLS should be structured as: artsy.net/{channel_name}/{article_title}

Sketch file here:
https://www.dropbox.com/s/ah416g2i2h0cp9w/ArticlePage.Differentiation_06.sketch?dl=0

[v1.5 / v1.6] Keep pagination even when results fit on one page

From @briansw on May 25, 2016 13:16

It would help ground the page a bit more if we could keep the pagination present even when the results fit on one page.

Copied from original issue: artsy/force-private#5100