arturo182/bbq10pmod_module

Kernel module for the bbq10pmod

bbq10pmod_module's Issues

module not working

Running dmesg, I see this:

[   325.256608] bbq10pmod 1-001f: bbq10pmod_read_reg failed, reg: 3, error: -121
[   325.256651] bbq10pmod 1-001f: bbq10pmod_irq_handler: failed to read KEY: -121

Communication kernel module <-> keyboard

Setup:

• Raspberry Pi 1B with Raspbian Buster
• bbq10pmod_module - master (Setup done like described here https://github.com/berkutta/bbq10pmod_module/blob/improve-docs/README.md)
• bbq10kbd_i2c_sw - master
• pmod_bbq10_keyboard - master

Issue:

It looks like the kernel module <-> keyboard communicates sort of but not correctly. The dmesg output looks ok but I'm e.g. unable to set the brightness via sudo su -c "echo 255 > /sys/class/backlight/bbq10pmod/brightness. It get's dark after kernel module initialization and keeps dark until resetting the keyboard.

dmesg output:

[    8.249265] i2c /dev entries driver
[    8.337603] bbq10pmod: loading out-of-tree module taints kernel.
[...]
[   16.524469] bbq10pmod_probe version: 0x02
[   16.536031] input: bbq10pmod as /devices/platform/soc/20804000.i2c/i2c-1/1-001f/input/input0

Assumption:

It looks like the keyboard software can't handle setting the register address in one write and setting the register value in another write. Capture on the top works and capture on the bottom not. Capture on the top is done via sudo i2cset -y 1 0x1f 0x85 0xFF and capture on the bottom via sudo su -c "echo 255 > /sys/class/backlight/bbq10pmod/brightness.

I got it working with the following hack. Not sure if I should to a PR. It breaks potential writes with multiple bytes:
berkutta@ae8c561