asad70/options-max-pain-calculator

A python command line tool to calculate options max pain for a given company symbol and options expiry date.

options-max-pain-calculator's Issues

Not an issue - Volume instead of OpenInterest

Hi Asad,
Thanks for writing this tool, its a great code.
Checking in to see, if we can use the Volume instead of OpenInterest, if so can you please suggest what changes has to be done in the code.

Suggest to loosen the dependency on yfinance

Hi, your project Options-Max-Pain-Calculator requires "yfinance==0.1.68" in its dependency. After analyzing the source code, we found that some other versions of yfinance can also be suitable without affecting your project, i.e., yfinance 0.1.69. Therefore, we suggest to loosen the dependency on yfinance from "yfinance==0.1.68" to "yfinance>=0.1.68,<=0.1.69" to avoid any possible conflict for importing more packages or for downstream projects that may use Options-Max-Pain-Calculator.

May I pull a request to loosen the dependency on yfinance?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

---

For your reference, here are details in our analysis.

Your project Options-Max-Pain-Calculator(commit id: e67bd57) directly uses 2 APIs from package yfinance.

yfinance.ticker.Ticker.__init__, yfinance.ticker.Ticker.option_chain

From which, 13 functions are then indirectly called, including 7 yfinance's internal APIs and 6 outsider APIs, as follows (neglecting some repeated function occurrences).

[/asad70/Options-Max-Pain-Calculator]
+--yfinance.ticker.Ticker.__init__
|      +--yfinance.base.TickerBase.__init__
|      |      +--yfinance.utils.empty_df
|      |      |      +--pandas.DataFrame
|      |      +--yfinance.utils.is_isin
|      |      |      +--re.match
|      |      +--yfinance.utils.get_ticker_by_isin
|      |      |      +--yfinance.utils.get_all_by_isin
|      |      |      |      +--yfinance.utils.is_isin
+--yfinance.ticker.Ticker.option_chain
|      +--yfinance.ticker.Ticker._download_options
|      |      +--requests.get
|      |      +--datetime.datetime.utcfromtimestamp
|      +--collections.namedtuple
|      +--yfinance.ticker.Ticker._options2df
|      |      +--pandas.DataFrame
|      |      +--pandas.to_datetime

We scan yfinance's versions among [0.1.69] and 0.1.68, the changing functions (diffs being listed below) have none intersection with any function or API we mentioned above (either directly or indirectly called by this project).

diff: 0.1.68(original) 0.1.69
['yfinance.base.TickerBase.history', 'yfinance.base.TickerBase']

As for other packages, the APIs of @outside_package_name are called by yfinance in the call graph and the dependencies on these packages also stay the same in our suggested versions, thus avoiding any outside conflict.

Therefore, we believe that it is quite safe to loose your dependency on yfinance from "yfinance==0.1.68" to "yfinance>=0.1.68,<=0.1.69". This will improve the applicability of Options-Max-Pain-Calculator and reduce the possibility of any further dependency conflict with other projects/packages.