asarnow/lui

Laser User Interface

lui's Issues

Alignment-specific code should be deleted

The Alignment classes and ParentForm UI elements are deprecated and should be removed.

Interdependent LuiObjects

LuiObjects (instrument classes) are already interdependent in some cases (GPIB). The parameters and configuration must be refactored to reflect this.

Need:

• Mechanism for initializing dependencies in proper order
• Configuration support
• Configuration XML read/write support

Persistent options

Need persistent application and device settings.

Beam flag delay option not available

Memoize blanks

Need to allow saving of blanks to make SpecControl, CalibrateControl more convenient.

Additional data collection schemes

desired default: 1/2 flash trans 1/2 flash
desired other options:
a. flash trans, trans, trans, .......
b. flash, trans, flash, trans, flash, trans,
c. flash, trans, trans, trans .... flash
gravy options
d. CD = (right - left)/(right+left)

Troa shows "dark" progress for first gs scan

CalibrateControl - Enter key should add calibration point

See title.

MAT File interop incomplete

Currently missing

1. multiple-variable MAT files
2. reading MAT files for profiles, calibration, etc.
3. convenient multi-dimensional array write

TroaPump Control

Choose pump never, always or TS only, and whether to discard first acquisition from TroaControl

SpecControl save data

Save button is disabled and data management logic is missing.

ReadVector skips a line

Need to investigate.

Use number of scans as dummy value in data matrix

The number of scans is now used as the dummy value (fist/top left element) in TROA data matrices.

ClearData() etc are inefficient and error prone

ClearData, etc. should result in only the respective layer being clear for the next paint call.
Currently, they are disposing the layer, resulting in 1) reallocation and 2) exceptions if clear is called without invalidating.

In other words, the sequence ClearData;DrawPoints;Invalidate needs to be allowed as well as ClearData;Invalidate;DrawPoints;Invalidate as currently required.

log4net is not configured

Need logging statements to go somewhere.

GPIB Provider abstraction required

GPIB SDK-specific code needs to be refactored from the DDG classes to a GPIBProvider class, so that arbitrary GPIB controllers can be used with the DDG.

Beam flag operations need delay timers

Letting the BF controller "ping-pong" can interfere with the optical path during acquisition.

lasercom is not thread-safe

Certain methods in lasercom objects should be wrapped in exclusive locks. At least:

• GPIB read/write methods
• Camera read

AndorCamera get maximum hardware bin sizes

unsigned int WINAPI GetMaximumBinning (int ReadMode, int HorzVert, int* MaxBinning)

Pause functionality

Pausing is useful to refill the pump or otherwise mess with things.

TroaControl - pump is not closed on abort

See title.

TROSControl incomplete

The most important control!

LaserPower incomplete

LaserPower needs to be finished.

Data should be a difference spectrum from which photolysis yield can be computed and optimal laser power selected.

Boxing / zoom based graph scaling where appropriate

It would be nice to zoom into the spectra y-axis because the noise is pretty expansive.

Save data from Residuals tab

Should InitDataFile each time DoWork called, but overwrite file unless data is saved.

TroaProgress indications

The indications move strangely due to line 397. Need to fix.

Also, need to add numerical indications (possibly use NScans NumericUpDown to count scans while disabled).

DDG-agnostic delay setting

All DDG objects should have a primary delay property linked to the appropriate delay, to avoid having to cast to a particular DDG when incrementing delay times.

Camera saturation exception

Need to throw an exception when camera pixel is saturated. Catching exception should pause a running TROA and cancel anything else.

TROS: Wrong number of scans after run completed

Completed scans aren't updated for last set.

DetectorTester process continues after application closed

DetectorTester can leave processes hanging around even after exit. They can use ~12% CPU each...

Need to investigate this bug - does it affect LUI?

This might be the clue: https://stackoverflow.com/questions/5088953/closing-main-form-doesnt-finish-process-in-windows-7

Sanity checking selected options

When handling apply, should sanity check the configuration and error back to the configuration page if issues are detected.

Control configured spectrograph (Shamrock) from CalibrateControl

ResidualsControl - compute and show variances

We use Knuth/Welford to compute the means and variances.

HomeControl incomplete/not created

Should add something to the home tab of the ParentForm. Welcome msg. and common functions?

Add/Configure objects in options

Plan, BeamFlag example:
class LUIConfigurator - ListView, Add/Remove buttons, panel area
class BeamFlagConfigurator : LUIConfigurator - type selector, panels to hide show class specific options

OnApply - instantiate the configured items using Factory classes / Activator

SpectrumControl incomplete/not created

Need this control!

Show version number in main window title

Pump object not bound by default

In some LuiTab OnLoad methods, HandlePumpChanged was subscribed after base.OnLoad. HandleParametersChanged is called in the base method and was thus called before the subscription.

The event is now subscribed before calling base.OnLoad

TroaControl, SpecControl, ResidualsControl.

CameraStatus orphaned

CameraStatus textbox in TroaControl was orphaned. Needs to be moved to LuiTab and added to StatusBox along with CameraStatusLabel.

All tabs will then need to update this from their WorkProgress methods (as should be done with the default LuiTab.WorkProgress).

SpecControl CameraGain not re-enabled

See title

Calculate % residuals

Show std / mean as percentage during residuals.

GraphControl swap left and right

Needs an option.

StanfordDigitalDelayGenerator is incomplete

This class and all methods must be completed and debugged.

Changing camera temperature too fast causes NPE

TemperatureCts set null at some point?

beam flags options

desired default -- only closed during flash
option --- close between flashes.
pump option.

Command line help version string is hardcoded

Should get the actual version from somewhere.

Inconsistent scan counters

Scan counters need to be updated properly in all LUI tabs. Progress bar should be removed.

Option to delete temporary files

Work methods creating temporary files should be cleaned if requested.

SpecControl manage data

Implement complex data management

Configurable camera image area

Need to set ImageArea based on active (intensified) area. Need to replace references to Camera.Width with ImageArea.Width.