asd-xiv/m

Point free style, functional library for Javascript with focus on object arrays.

m's Issues

Sort by date

I was wondering how to use sort / sortBy to sort by dates, which I believe is a common use case. I was about to open a PR but wanted to check your opinion first.

This is what I have, for sorting objects by a given field:

const sortByDate = field =>
  sort((a, b) => {
    if (isEmpty(b[field])) {
      return -1
    }

    if (isEmpty(a[field])) {
      return 1
    }

    return new Date(b[field]).getTime() - new Date(a[field]).getTime()
  })

which in turn takes me to consider other sorting behaviors (alphabetical?) and also if you'd add a new file for each sorting, or maybe generalize the criterium ...

About intersection

I was playing with intersection to see if that would allow us to find the elements in common in two arrays, but I am confused to see it does the opposite: it merges the two collections by applying a union function ... so my questions / comments:

• I think current implementation is actually an union or join, not an intersection, in Venn's terms. If I'm not mistaken, I'd suggest a rename ... although that'd be a breaking change. Moreover when I'd suggest to add a different intersection function ...
• Can intersection or other function in m be use to obtain that the elements in common in two lists? Would you accept a PR for that? What name would you give it?

About ESM and v7

Hi!

I upgraded to v7, ESM one, and I am fighting the upgrade.

I was under the wrong impression that changing const {x} = require("@asd14/m") to import {x} from "@asd14/m" would be enough, but I keep getting an require() of ES Module error importing the module. It seems that our Babel is taking that import and transforming it again to require, or something ...

... so my question would be if it makes sense to add upgrade instructions to the README, maybe considering this case.

Thanks!

Random pick

Hi! I was considering how to randomly pick one element from an array. Other langs have that direct method or an easy explicit combination, ie Ruby: array.shuffle.pop

I implemented this little one:

const pickRandom = items => items[Math.trunc(items.length * Math.random())]

Any alternative already here I did not find? Are you interested in a PR?