asd-xiv/pluginus

Dependency injection with promise support for Node.js

pluginus's Issues

Don't create plugin every time it's required as a dependency

Describe

Plugins initialized each time it gets loaded as a dependency.

Reproduce

// plugin 1
module.exports = {
  depend: [],
  create: () => {
    // will log two times
    console.log("Init plugin 1")
  },
}

// plugin 2
module.exports = {
  depend: ["Plugin1"],
  create: Plugin2 => {},
}

// plugin 3
module.exports = {
  depend: ["Plugin1"],
  create: Plugin1 => {},
}

Expected

Plugins should act like singletons, load once and reuse next time it's required by another plugin.

Error: Pluginus: plugin "X" not found as dependency for "Y"

Hi!

I am experiencing an issue that seems to be related to the loading order of dependencies.

The situation is:

PluginA {
  depend: ["PluginB"],
}

PluginB {
  depend: ["PluginA"],
}

That causes the error mentioned in the title. Having a quick look at the code, I see that this piece of code could be the issue:

sort((a, b) => {
  const aHasB = has(b.name, a.depend)
  const bHasA = has(a.name, b.depend)
  if (!aHasB && !bHasA) {
    return a.depend.length > b.depend.length ? 1 : -1
  }
  return bHasA ? -1 : 1
}),

While it can be argued that the code should be decoupled or architectured in a different way, I wanted to raise the issue in case this is a known limitation, there is a workaround, or this is something that need addressing at this level.

Dont check files exist after scaning folders

Verify only file path from files param. Verifying folders and non-regexp files is enough to ensure all paths exist.

https://github.com/asd14/pluginus/blob/master/src/pluginus.js#L217