asher256/puppet-redis_cluster

Install multiple redis instances via Puppet to configure a cluster with redis-trib.rb (for Redis version >= 3.0)

puppet-redis_cluster's Issues

Dependency loop for redis_cluster instance definition?

Hi,

I've been trying to set up a redis cluster through using this module. In hiera, I have defined an array as follows:

# redis node config
redis_cluster::instances:
  'master_6379':
    ip: '10.0.5.9'
    port: '6379'
  'master_6380':
    ip: '10.0.5.10'
    port: '6380'

Whenever I run this on the node in question, this results in a dependency loop:

node1 /root # pa -tv --environment=redis_cluster_stage --graph
Info: Using configured environment 'redis_cluster_stage'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for node1
Info: Applying configuration version '1481542006'
Error: Failed to apply catalog: Found 1 dependency cycle:
(File[/lib/systemd/system/redis-server-master_6379.service] => Redis_cluster::Instance::Service[master_6379] => Redis_cluster::Instance[master_6379] => Class[Redis_cluster::Load_instances] => Redis_cluster::Instance::Service[master_6379] => File[/lib/systemd/system/redis-server-master_6379.service])
Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz

The dotfile looks as follows:

Which to me looks like the systemd file, depends on the redis-server-${name} resource, which in turn depends back on the redis_cluster instance service resource, and back on the systemd file.

In the puppet code I have seen the following:

    redis_port => $redis_port,
    require    =>  [Class['::redis_cluster::repos'],
                    Class['::redis_cluster::install'],
                    Class['::redis_cluster::load_instances'],
                    Augeas["update ${redis_config}"]],
  }

When I comment out the Class requirements of the individual manifests, the puppetrun works as expected. Why are these explicit requires set if they are actually going to be loaded on module autoload anyway?