ashfurrow/functionalreactivepixels

A demonstration of how to use FRP with ReactiveCocoa in an iOS context using the 500px API.

500px shut down their API, which this repo relied on. The code here will no longer work. Sorry about that – it's a shame, too, since their API was something that made 500px special and now it's gone.

A demonstration of how to use FRP with ReactiveCocoa in an iOS context using the 500px API.

This is code to accompany my book.

Installing

Clone the repo and run pod install from the repo's directory to install the required pods.

git clone https://github.com/ashfurrow/FunctionalReactivePixels.git
cd FunctionalReactivePixels
pod install

Please do not click the "Download ZIP" button on this page.

Please don't go all creepy with my consumer key.

functionalreactivepixels's Issues

Why you can get rid of prepareForReuse?

In section "Revisiting FunctionalReactivePixels", there is “We can abstract away the need to use the prepareForReuse method altogether by replacing creating a new property on FRPCell”. However, why you don't even need the "takeUntil:self.rac_prepareForReuseSignal" to get the reusable cell work?

500px is deactivated the API

• (RACSignal *)importPhotos {
  return [[[[[self requestPhotoData] deliverOn:[RACScheduler mainThreadScheduler]] map:^id(NSData *data) {
  id results = [NSJSONSerialization JSONObjectWithData:data options:0 error:nil];
  .....
  }

---

(lldb) po results
{
error = "Application is deactivated, please contact us by email: [email protected].";
status = 403;
}

so that I cant fetch the photos, haha

crashed when u slide quickly from current photo to previous in full-size-photo view.

quickly slide to next photo before the current photo displays, then slide back, crashed

log msg:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Signal <RACDynamicSignal: 0x17423f3a0> name: is already bound to key path "fullsizedData" on object <FRPPhotoModel: 0x17409fe50>, adding signal <RACDynamicSignal: 0x1704214e0> name: is undefined behavior'

Run in iPhone5s, iOS 8

i am new to RAC, could u tell me what happened?

Unable to compile

I'm getting the following error when I try to compile:

ld: library not found for -lPods-FRP
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I've tried both cloning the github repo and using cocoa pods as well as compiling from the zip file you provided.

> Please don't go all creepy with my consumer key.

https://github.com/orta/cocoapods-keys

sentestingkit/sentestingkit.h not found xcode 7

Today,I update my xcode to xcode7.0.I try to run this project,but can't do that.Can you help me?

More Opportunities to Use RAC

Since this is a project demo'ing what's possible with ReactiveCocoa, I don't mind going heavy-handed on the pedagogy. Any ideas for opportunities I'm missing out? I'm particularly interested in examples of where to use RACCommand.

Bad scrolling performance

I tried the app on an iPhone 4S and the scrolling performance on the main screen is quite shabby. I guess the issues arise when cell recycling happens. Can it be that too much work is done on the main thread?

64 bit problems

Unknown type name 'ffi_status'
Unknown type name 'ffi_cif'

Login System

Create a mandatory (?) login system so users can vote. Or not mandatory. I 'unno. Thoughts?

Vote button disabled after cancelled login in FRPPhotoDetailViewController

When the vote button is pushed and the user is not logged in, the login screen is shown. If this is cancelled, the Vote button stays disabled and the FRPPhotoDetailViewController can only be dismissed with Done. Failed login should be handled correctly.

Migrate to MVVM

Seriously breaking some MVC here – moving to MVVM for Chapter 5.

Cannot run profiler

When trying to profile, lots of errors appear. I guess the configuration needs to be updated for this scenario too.

Currently Not Building

:\

Break Apart Chained Signals

Some of the chained signals are pretty complex – breaking them apart into intermediate variables might be helpful to readers.

Update to newer RAC version

Than 2.0. Hear there's some great stuff in there, including rac_prepareForReuseSomething.

on the main gallery View ,pull fast

if you pull fast,pay a tention to both of the side , you will find that some photos will always run in the reuse.

i download zip from github , and then pod install,there is an error occurs:library not found for -lPods-FRP-AFImageDownloader,how can i solve it

Hi,ash furrow,thank you for your reply,When I use your project，my OS X is 10.10.3,Xcode is 6.4,cocoapods is 0.36.4,not use rvm or rbenv and modified the Podfile.

NSURLConnection+RACSupport

+rac_sendAsynchronousRequest: can replace the direct use of NSURLConnection.

Of course, doing so would require more chaining (to implement parsing, and eventually deliver to the main thread). The method also returns a cold signal, so it might require replaying, or else refactoring the call points to ensure there's only ever one subscription.

Swift is not supported for static libraries.

Hello Ash Furrow,

I followed the instruction of your book.

Write pod 'ReactiveCocoa'
run pod install

This error message shows up.

Check dependencies

Swift is not supported for static libraries.

The latest ReactiveCocoa's version I fetched is 3.0.0

How can I make it compile?

Unable to compile

I'm getting an error when I try to compile:

Error handlings

What about errors handlings, how can I inform controller, that some error has occured? With fetching images, or model creation?

Make loading property derived

https://github.com/AshFurrow/FunctionalReactivePixels/pull/24/files#r8576689

Send one photo at a time on +importPhotos

Instead of performing complicated mapping on the list of photos and then sending the transformed list, one photo can be sent on the signal at a time.

This allows the transformations to be applied to the signal directly, and more obviously emphasizes the notion of a stream of values over time.

Although probably not relevant to this example, this also makes pagination more transparent, like in octokit.objc.

Voting

Progress HUD disappears while photo data is being downloaded

I have successfully run this code, but it did not respond to "[[self rac_signalForSelector:@selector(collectionView:didSelectItemAtIndexPath:) fromProtocol:@protocol(UICollectionViewDelegate)] subscribeNext:^(RACTuple *arguments)"method when I clicked item in collectionView,how to solve it?

In the previous code, this method can be responded, and I do not know why in the new code it doesn't respond to this method,my environment is xcode7,iphone6plus.

When to retain RACDelegateProxy?

In the section "Revisiting FunctionalReactivePixels", there's a NOTE that delegate objects must be retained. However, "collectionViewDelegate" is retained while "RACDelegateProxy *viewControllerDelegate = [[RACDelegateProxy alloc] initWithProtocol:@protocol(FRPFullSizePhotoViewControllerDelegate)];" is not retained.

RACSubjects in asynchronous code should be RACReplaySubject

Every RACSubject that's used for an asynchronous operation should actually be RACReplaySubject, or else it's possible for the following race condition to occur:

1. Subject created
2. Asynchronous operation started
3. Asynchronous operation completes very quickly and returns its results
4. Subject returned
5. Caller subscribes to subject, but nothing ever happens (since the results were sent before it was ready)

This is important enough that it should be present in the initial code samples (IMO), not introduced in a refactoring chapter.

Tests

EXC_BAD_ACCESS with RACDelegateProxy

Happening iff I leave this line uncommented: https://github.com/AshFurrow/FunctionalReactivePixels/blob/broken/FRP/FRPGalleryViewController.m#L73

Any ideas?

Implement changes for cell reuse

See: #45