ashinzekene/angular-rave

💵 An angular2+ module for integrating payments using the rave gateway

angular-rave's Issues

Observations

I noticed the callback event is not as effective in catching failing payments as the docs describe, and a scenario you might want to consider is Mobile money payment, e.g. MPesa and MTN Ghana MoMo, as flutterwave returns a pending payment payload, and does not mean a payment failure since the user still has to go input their PIN on their phone, thus eventually letting the web hook tell you it's final status

A suggestion will be to have an explicit callback function for each payment status and currently, the onclose event behaves as a better replacement for specifying the callback event.

I will suggest onclose should listen to the modal close event, as it is the default confirm box is in place for now

Overall, great work.

PaymentInstance in Documentation

Hey!

In the documentation, i see a variable payment instance that gets created,
paymentInstance: PaymentInstance;

But in paymentInit,

 paymentInit(paymentInstance) {
    this.paymentFailure = paymentInstance;
    console.log('Payment about to begin', paymentInstance);
  }

this.paymentFailure gets set, which is a function, is this correct?

Add contributors

@all-contributors please add @tyronasaurus-rex and @okeyokoro for code

Issues with documentation

Hi,
Thanks for this awesome repo, I believe there is a mistake with the current documentation where the close handler is not working as expected from documentation. I believe the close handler event in the directive should be onclose instead of close. Please advise
Thanks and regards.

PaymentInstance and autoclose Issue

I tried Importing "PaymentInstance" it is not a member of what the module exports.

apparently property "autoClose" doesn't event exist on both the component or the directive class.

Can't bind to 'autoClose' since it isn't a known property of 'button'. ("
#raveBtn
angular-rave
[ERROR ->][autoClose]="true"
[raveOptions]="paymentOptions",
(callback)="saveResponse($event)"
"): ng:///OrderDetailsPageModule/OrderDetailsPage.html@82:8

used as <button
#raveBtn
angular-rave
[autoClose]="true"
[raveOptions]="paymentOptions",
(callback)="saveResponse($event)"
(onclose)="paymentCancelled()"
class="raveBtn"
>PAY NOW

Callback functions not called

Hello,
I just integrated your package and it works fine but the 3 callback functions are not being called, paymentSuccess($event), paymentFailure(), paymentInit().

I am using the angular-rave component.

How to import the live script and also how to close payment modal on payment complete

Hi!
Great plugin. I am using Angular 6 and it's working great so far. Just two questions:

1. How can I import the live script? Should I just place the reference to it in my index.html? I can see the plugin runs fine without importing anything as it used the sandbox script.

2. When payment is complete, how can I close the modal just like x.close() in the main documentation.

Thanks!

Callback not being called

My specified callback function is not being called even after a successful transaction

Lib version: 2.0.1
Angular version: 9.1.3

Add Contributors

@all-contributors please add @tyronasaurus-rex and @okeyokoro for code

Adding Subaccounts

Hi,
Please, We would like to use the subaccount flow on this plugin, how can we make that possible, see a link to the documentation that discusses subaccount: https://developer.flutterwave.com/v2.0/docs/split-payment

Confirmation Modal not closing

Hello,
I am using this module with Ionic Capacitor. After successful payment, the payment confirmation is not closed and not redirected to the app.

Here is the final url that didnt close

https://api.ravepay.co/flwv3-pug/getpaidx/api/complete?resp={%22batchno%22:%2220200422%22,%22authorizeId%22:%22558724%22,%22merchtransactionreference%22:%22FLW235718144%22,%22orderinfo%22:%22PT-FLW235718144%22,%22receiptno%22:%22011311091755%22,%22amount%22:%2250.00%22,%22responsetoken%22:%22hV7jvGG2p00CeNz\u003dVBV%22,%22responsecode%22:%2200%22,%22responsemessage%22:%22Approved%22,%22transactionreference%22:%22FLW235718144%22,%22responsehtml%22:%22%22}

Changing text

Can the package modify these texts or do you know of a way to modify them!

A set Interval function attempts to find script tag with inline js reference

<script src="https://api.ravepay.co/flwv3-pug/getpaidx/api/flwpbf-inline.js"></script>

Tests for AngularRaveDirective

Write unit tests for angular-rave.directive.ts. Started something here already

Callback and close functions don't work

Hi there, the package runs correctly, but the callback and close functions do not work. Kindly see to it