assamite/sdrs_cimg

Salient Region Detection for Python using CImg

sdrs_cimg's Issues

question about the given matlab code.

Hi, i find the corresponding matlab code in https://ivrlwww.epfl.ch/supplementary_material/RK_CVPR09/SourceCode/Saliency_CVPR2009.m,

but i wonder is there any difference?
in matlab code, the average object is the GaussianSmoothed image.
however, in the C++ code, the averaged is the original lab image.
Is the C++ code right in terms of the paper?
i test the both way and find no difference of salience results.
why is it so?

Wrong filename in makefile

I've detected that you forgot to capitalize CImgHandler.cpp in your makefile, which gives an error
g++: error: CimgHandler.cpp: No such file or directory

To fix this edit line 15 to:
g++ -c CImgHandler.cpp -O2 -I/usr/X11R6/include -I/opt/local/include

strncmp invoked without cstring

Another error when compiling:

"SalientRegionDetector.cpp:362:31: error: ‘strncmp’ was not declared in this scope"

My solution was "#include " to the file

uint32_t invoked without stdint.h

After going through the previous two issues, another one came up:

Saliency.h:12:14: error: ‘uint32_t’ was not declared in this scope

My solution was "#include <stdint.h>" in Saliency.h

Can't build with python

After installing all the necessary dependencies and fixing the makefile in issue #1
I get following error after using make shared_linux
I'm using;
Ubuntu 14.04
Python 2.7.11
Anaconda 4.0.0

In file included from CImgHandler.cpp:8:0:
CImgHandler.h:26:11: error: ‘string’ has not been declared
           string&    filename,
           ^
CImgHandler.h:11:14: error: ‘uint32_t’ was not declared in this scope
 #define UINT uint32_t
              ^
CImgHandler.h:27:18: note: in expansion of macro ‘UINT’
           vector<UINT>&  outBuff,
                  ^
CImgHandler.h:27:22: error: template argument 1 is invalid
           vector<UINT>&  outBuff,
                      ^
CImgHandler.h:27:22: error: template argument 2 is invalid
CImgHandler.h:11:14: error: ‘uint32_t’ was not declared in this scope
 #define UINT uint32_t
              ^
CImgHandler.h:32:18: note: in expansion of macro ‘UINT’
           vector<UINT>&  imgBuffer,
                  ^
CImgHandler.h:32:22: error: template argument 1 is invalid
           vector<UINT>&  imgBuffer,
                      ^
CImgHandler.h:32:22: error: template argument 2 is invalid
CImgHandler.h:35:11: error: ‘string’ has not been declared
           string&    outFolder,
           ^
CImgHandler.h:36:11: error: ‘string’ has not been declared
           string&    outFilename,
           ^
CImgHandler.h:37:11: error: ‘string’ has not been declared
           string&    suffix);
           ^
CImgHandler.cpp:36:6: error: prototype for ‘void CImgHandler::GetPictureBuffer(std::string&, std::vector<unsigned int>&, int&, int&)’ does not match any in class ‘CImgHandler’
 void CImgHandler::GetPictureBuffer(
      ^
In file included from CImgHandler.cpp:8:0:
CImgHandler.h:25:13: error: candidate is: void CImgHandler::GetPictureBuffer(int&, int&, int&, int&)
  void       GetPictureBuffer(
             ^
CImgHandler.cpp:65:6: error: prototype for ‘void CImgHandler::SavePicture(std::vector<unsigned int>&, int, int, std::string&, std::string&, std::string&)’ does not match any in class ‘CImgHandler’
 void CImgHandler::SavePicture(
      ^
In file included from CImgHandler.cpp:8:0:
CImgHandler.h:31:13: error: candidate is: void CImgHandler::SavePicture(int&, int, int, int&, int&, int&)
  void       SavePicture(
             ^
make: *** [CImgHandler.o] Error 1