astefanutti/metrics-aspectj

AspectJ integration for Dropwizard Metrics

metrics-aspectj's Issues

Support histogram via return value and expression language

I have a use case for the histogram metric in my codebase and would love to see it supported via annotations like the rest. It presents some challenges in execution but there is a way it could work.

The annotation would be processed upon completion of the annotated method rather than around it as it would operate on the return value of the method.

Examples:

@Histogram(name = "return.integer")
public int returnsAnInteger() {
   return randomInt();
   // Histogram::update is called using return value if return type is int
}

// Since EL 2.2 arbitrary method calls are supported
// 'return' bean defined in the aspect as the return value of the annotated method
@Histogram(name = "return.customObject", value = "${return.size()}")
public List<String> returnsAList() {
   return listFetchedFromRemoteService();
   // Histogram::update is called using the value obtained via execution 
   // of the provided EL expression (in this case over the return value)
}

@Histogram(name = "return.instanceField", value = "${this.currentValue}")
public void returnsNothingButSideEffects() {
   this.setCurrentValue(someInt());
   // Histogram::update is called using the value obtained via execution
   // of the provided EL expression (in this case over the instance)
}

Any thoughts on this style? I'd be happy to implement this if it's ok to go in.

@Timed method on base class throws NullPointerException when class is extended

Hi, metrics-aspectj developers

I have been using your library and found it very convenient to annotate a method to capture performance metrics. Recently I hit the wall when trying the extend a class that has annotated methods. Here's what I see:

@Metrics
public class Base {
    public void something_not_timed() {
        ...
   }
    @Timed(name="method1-ProcessTime")
    public void method1() {
       ...
    }
}

I have been using Base class in production without issue. Now I need to extend this class.

public class Derived extends Base {
    @Override
    public void something_not_timed() {
        ....
    }
}

As you can see, method1() is not overridden. But the problem is that whenever I use method1() in Derived class, I would get a NullPointerException in method1_aroundBody1$advice().

I'm not familiar with AspectJ so couldn't really figure out what I'm missing, any advice will be highly appreciated.

Thanks!

Regards,
Cary

ClassCastException: com.codahale.metrics.Timer cannot be cast to com.codahale.metrics.Meter

I'm getting the following bizarre exception at runtime:

java.lang.ClassCastException: com.codahale.metrics.Timer cannot be cast to com.codahale.metrics.Meter
! at org.stefanutti.metrics.aspectj.MeteredAspect.ajc$before$org_stefanutti_metrics_aspectj_MeteredAspect$1$ed31598a(MeteredAspect.aj:28) ~[license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.clarecontrols.licensing.cliq.service.impl.FusionAPIImpl.getProjectNameForUUID_aroundBody4(FusionAPIImpl.java:143) ~[license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.clarecontrols.licensing.cliq.service.impl.FusionAPIImpl$AjcClosure5.run(FusionAPIImpl.java:1) ~[license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.stefanutti.metrics.aspectj.TimedAspect.ajc$around$org_stefanutti_metrics_aspectj_TimedAspect$1$c493a7d9proceed(TimedAspect.aj:26) ~[license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.stefanutti.metrics.aspectj.TimedAspect.ajc$around$org_stefanutti_metrics_aspectj_TimedAspect$1$c493a7d9(TimedAspect.aj:31) ~[license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.clarecontrols.licensing.cliq.service.impl.FusionAPIImpl.getProjectNameForUUID(FusionAPIImpl.java:142) ~[license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.clarecontrols.licensing.cliq.api.LicenseInfoResource.getProjectName(LicenseInfoResource.java:146) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.clarecontrols.licensing.cliq.api.LicenseInfoResource.getLicenseInfoView(LicenseInfoResource.java:125) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_05]
! at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_05]
! at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_05]
! at java.lang.reflect.Method.invoke(Method.java:483) ~[na:1.8.0_05]
! at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.codahale.metrics.jersey.InstrumentedResourceMethodDispatchProvider$TimedRequestDispatcher.dispatch(InstrumentedResourceMethodDispatchProvider.java:30) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.codahale.metrics.jersey.InstrumentedResourceMethodDispatchProvider$MeteredRequestDispatcher.dispatch(InstrumentedResourceMethodDispatchProvider.java:49) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.jersey.guava.OptionalResourceMethodDispatchAdapter$OptionalRequestDispatcher.dispatch(OptionalResourceMethodDispatchAdapter.java:37) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.uri.rules.ResourceObjectRule.accept(ResourceObjectRule.java:100) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:540) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:715) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.jetty.NonblockingServletHolder.handle(NonblockingServletHolder.java:49) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1515) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlets.UserAgentFilter.doFilter(UserAgentFilter.java:83) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:348) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.jetty.BiDiGzipFilter.doFilter(BiDiGzipFilter.java:127) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1486) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.servlets.ThreadNameFilter.doFilter(ThreadNameFilter.java:29) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1486) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.jersey.filter.AllowedMethodsFilter.handle(AllowedMethodsFilter.java:44) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.jersey.filter.AllowedMethodsFilter.doFilter(AllowedMethodsFilter.java:39) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1486) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:519) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1097) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:448) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1031) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:136) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at com.codahale.metrics.jetty9.InstrumentedHandler.handle(InstrumentedHandler.java:175) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at io.dropwizard.jetty.RoutingHandler.handle(RoutingHandler.java:51) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:92) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:162) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.Server.handle(Server.java:446) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:271) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:246) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.io.AbstractConnection$ReadCallback.run(AbstractConnection.java:358) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:601) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:532) [license-server-1.0.1-SNAPSHOT.jar:1.0.1-SNAPSHOT]
! at java.lang.Thread.run(Thread.java:745) [na:1.8.0_05]

I'm trying to use this project to provide metrics around API calls that I am making inside of a Dropwizard environment (which handles metrics). Timers work but Meters fail with the above error.

I am building using Maven; below is a cut-down version of of the POM with the relevant parts:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <prerequisites>
        <maven>3.0.0</maven>
    </prerequisites>
    <groupId>com.clarecontrols.licensing.cliq</groupId>
    <artifactId>license-server</artifactId>
    <version>1.0.1-SNAPSHOT</version>
    <packaging>jar</packaging>
    <name>CLIQ License Server</name>
    <!-- Elided for clarity -->
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        <dropwizard.version>0.7.1</dropwizard.version>
        <mainClass>com.clarecontrols.licensing.cliq.LicenseServerApplication</mainClass>
        <mojo.java.target>1.7</mojo.java.target>
    </properties>
    <!-- Elided for clarity -->
    <build>
        <plugins>
            <plugin>
                <artifactId>maven-shade-plugin</artifactId>
                <version>2.1</version>
                <configuration>
                    <createDependencyReducedPom>true</createDependencyReducedPom>
                    <transformers>
                        <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
                        <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
                            <mainClass>${mainClass}</mainClass>
                        </transformer>
                    </transformers>
                    <!-- Exclude signed Manifests -->
                    <filters>
                        <filter>
                            <artifact>*:*</artifact>
                            <excludes>
                                <exclude>META-INF/*.SF</exclude>
                                <exclude>META-INF/*.DSA</exclude>
                                <exclude>META-INF/*.RSA</exclude>
                            </excludes>
                        </filter>
                    </filters>
                </configuration>
                <executions>
                    <execution>
                        <phase>package</phase>
                        <goals>
                            <goal>shade</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <artifactId>maven-jar-plugin</artifactId>
                <version>2.5</version>
                <configuration>
                    <archive>
                        <manifest>
                            <addClasspath>true</addClasspath>
                            <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                            <mainClass>${mainClass}</mainClass>
                        </manifest>
                    </archive>
                </configuration>
            </plugin>
            <plugin>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.0</version>
                <configuration>
                    <source>1.7</source>
                    <target>1.7</target>
                </configuration>
            </plugin>
            <plugin>
                <artifactId>maven-source-plugin</artifactId>
                <version>2.2.1</version>
                <executions>
                    <execution>
                        <id>attach-sources</id>
                        <goals>
                            <goal>jar</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <artifactId>maven-javadoc-plugin</artifactId>
                <version>2.9</version>
                <executions>
                    <execution>
                        <id>attach-javadocs</id>
                        <goals>
                            <goal>jar</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <artifactId>maven-deploy-plugin</artifactId>
                <version>2.7</version>
                <dependencies>
                    <dependency>
                        <groupId>org.apache.maven.wagon</groupId>
                        <artifactId>wagon-ssh</artifactId>
                        <version>2.6</version>
                    </dependency>
                </dependencies>
            </plugin>
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>aspectj-maven-plugin</artifactId>
                <version>1.7</version>
                <configuration>
                    <aspectLibraries>
                        <aspectLibrary>
                            <groupId>org.stefanutti.metrics.aspectj</groupId>
                            <artifactId>metrics-aspectj</artifactId>
                        </aspectLibrary>
                    </aspectLibraries>
                    <complianceLevel>1.7</complianceLevel>
                </configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>compile</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            <!-- Elided for clarity -->
        </plugins>
    </build>
    <dependencies>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-assets</artifactId>
            <version>${dropwizard.version}</version>
        </dependency>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-auth</artifactId>
            <version>${dropwizard.version}</version>
        </dependency>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-core</artifactId>
            <version>${dropwizard.version}</version>
            <exclusions>
                <!-- Provided by org.stefanutti.metrics.aspectj:metrics-aspectj -->
                <exclusion>
                    <groupId>org.glassfish.web</groupId>
                    <artifactId>javax.el</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.codahale.metrics</groupId>
                    <artifactId>metrics-core</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-jdbi</artifactId>
            <version>${dropwizard.version}</version>
        </dependency>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-migrations</artifactId>
            <version>${dropwizard.version}</version>
        </dependency>
        <dependency>
            <groupId>io.dropwizard</groupId>
            <artifactId>dropwizard-views-mustache</artifactId>
            <version>${dropwizard.version}</version>
        </dependency>
        <dependency>
            <groupId>org.stefanutti.metrics.aspectj</groupId>
            <artifactId>metrics-aspectj</artifactId>
            <version>1.0.0-rc.3</version>
        </dependency>
        <dependency>
            <groupId>org.aspectj</groupId>
            <artifactId>aspectjrt</artifactId>
            <version>1.8.2</version>
        </dependency>
        <dependency>
            <groupId>org.glassfish</groupId>
            <artifactId>javax.el</artifactId>
            <version>3.0.0</version>
        </dependency>
        <!-- Elided for clarity -->
    </dependencies>
</project>

The service implementation that I'm instrumenting:

package com.clarecontrols.licensing.cliq.service.impl;

import org.stefanutti.metrics.aspectj.Metrics;
// Elided for clarity
import com.clarecontrols.licensing.cliq.service.FusionAPI;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.annotation.Metered;
import com.codahale.metrics.annotation.Timed;

/**
 * FusionAPIImpl
 */
@Metrics(registry = "${this.registry}")
public class FusionAPIImpl implements FusionAPI {

    private final MetricRegistry registry;
    // Elided for clarity

    /**
     * Constructor.
     * @param registry the metrics registry
     * // Elided for clarity
     */
    public FusionAPIImpl(final MetricRegistry registry // Elided for clarity) {
        this.registry = registry;
    }

    /**
     * Required for EL to find the metrics registry property for the @Metrics annotation.
     * @return the metric registry
     */
    public MetricRegistry getRegistry() {
        return this.registry;
    }

    /**
     * {@inheritDoc}
     */
    @Timed(name = "updateLicenseType.timer")
    @Metered(name = "updateLicenseType.meter")
    @Override
    public void updateLicenseType(final String uuid, final LicenseType licenseType) {
        // Elided for clarity
    }

    /**
     * {@inheritDoc}
     */
    @Timed(name = "ping.timer")
    @Metered(name = "ping.meter")
    @Override
    public void ping() {
        // Elided for clarity
    }

    /**
     * {@inheritDoc}
     */
    @Timed(name = "getProjectNameForUUID.timer")
    @Metered(name = "getProjectNameForUUID.meter")
    @Override
    public String getProjectNameForUUID(final String uuid) {
        // Elided for clarity
        return null;
    }
}

Any ideas as to the cause of this? Thanks!

Introduction of default MetricRegistry

How about implementing some default MetricRegistry, so that the programmer was not forced to place @registry("") annotation everywhere along with @metrics? Only in case if he/she wants separate registries.
Or even combine these two annotations and specify registry name in @metrics annotation, like @metrics(registry = ""), also with a default value :)

Clarify in README whether this plugin actually works with Spring AOP

There is a section in the README comparing Spring AOP vs AspectJ, but it doesn't indicate whether it's possible to use this plugin in conjunction with Spring AOP. Can the README be updated to state clearly whether this works with Spring AOP?

EL Expression is not working with @Metrics annotation

In gradle example Instead of using registry name I chose to use EL Expression ${this.registry} and program started throwing exceptions. Below is the code:

`package com;

import java.util.Random;
import java.util.concurrent.TimeUnit;

import com.codahale.metrics.SharedMetricRegistries;

import com.codahale.metrics.ConsoleReporter;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.Meter;
import com.codahale.metrics.Timer;
import com.codahale.metrics.annotation.Timed;

import javax.el.ELProcessor;

import io.astefanutti.metrics.aspectj.Metrics;

// ~minimal App using metrics-aspectj
public class App {

//public static final MetricRegistry registry = SharedMetricRegistries.getOrCreate("reg");

public static void main(String[] args) throws InterruptedException {
    //MetricsRegistry registry = SharedMetricRegistries.getOrCreate("reg");
    //App.class.getClassLoader().loadClass("javax.el.ELProcessor");
    ITimedMethod timedMethod = new TimedMethod();

    for (int i = 0; i < 10; ++i) {
        timedMethod.randomTimeTask();
    }

    // await console reporter
    Thread.sleep(1010);
}

}

// this interface is not strictly necessary, but was added to make the toggling
// of explicit profiling easier.
//
// the class TimedMethodImplicit matches the ease of implementation for metrics
// that is documented and made possible by metrics-aspectj.
interface ITimedMethod {
public void randomTimeTask() throws InterruptedException;
}

class TimedMethod implements ITimedMethod {
// to use the same metric registry when explicitly (read: cross-cuttingly)
// profiling the App as well as when implicitly (read: aspect-oriented-ly)
// profiling the App, here for the explicit case, get or create
// (read: ~singleton) the metric registry using the same name as is used for
// the implicit case. FYI the default name for the implicit case is
// "metrics-registry".
private static final MetricRegistry metrics =
SharedMetricRegistries.getOrCreate("reg");

private ITimedMethod tmi;
private ITimedMethod tme;

public TimedMethod() {
    metricConsoleReporterStart();
    this.tmi = new TimedMethodImplicit(this.metrics);
    if (!AppConfig.isExplicitlyMeasuring) {
        this.tme = new TimedMethodNop();
    } else {
        this.tme = new TimedMethodExplicit(this.metrics);
    }
}

public void randomTimeTask() throws InterruptedException {
    tmi.randomTimeTask();
    tme.randomTimeTask();
}

private void metricConsoleReporterStart() {
    ConsoleReporter.forRegistry(this.metrics)
        .convertRatesTo(TimeUnit.SECONDS)
        .convertDurationsTo(TimeUnit.MILLISECONDS)
        .build()
        .start(1, TimeUnit.SECONDS);
}

}

@metrics(registry = "${ this.registry }")
class TimedMethodImplicit implements ITimedMethod {
private final Random rand = new Random();
private final MetricRegistry registry;

public TimedMethodImplicit(MetricRegistry reg) {
    this.registry = reg;
}

public MetricRegistry getRegistry(){return this.registry;}

@Timed(name = "randomTimeTask")
public void randomTimeTask() throws InterruptedException {
    Thread.sleep(rand.nextInt(100));
}

}
@metrics(registry = "reg")
class TimedMethodNop implements ITimedMethod {
@timed
public void randomTimeTask() throws InterruptedException { }
}

class TimedMethodExplicit implements ITimedMethod {
private final MetricRegistry metrics;
private final Timer timer;

private final Random rand = new Random();

public TimedMethodExplicit(MetricRegistry metrics) {
    this.metrics = metrics;
    this.timer = metrics.timer("request_times");
}

@Timed(name = "randomTimeTask")
public void randomTimeTask() throws InterruptedException {
    Timer.Context context = null;
    try {
        context = this.timer.time();
        Thread.sleep(rand.nextInt(100));
    } finally {
        if (context != null) {
            context.close();
        }
    }
}

}
`

NullPointerException on timed methods with several parameters

Method signatures are used for metrics resolution, but they are inconsistent.

1. In MetricAspect#metricAnnotation(…) method signature is taken from 'method.toString()'.
2. In TimedAspect it is taken from 'thisJoinPointStaticPart.getSignature().toLongString()'.

Those approaches produce slightly different results. The second separates method parameters with spaces and the first not.

This results in NullPointerException on timed methods with several parameters.

java.lang.NullPointerException
    org.stefanutti.metrics.aspectj.TimedAspect.ajc$inlineAccessMethod$org_stefanutti_metrics_aspectj_TimedAspect$org_stefanutti_metrics_aspectj_AnnotatedMetric$getMetric(TimedAspect.aj:1)
    org.stefanutti.metrics.aspectj.TimedAspect.ajc$around$org_stefanutti_metrics_aspectj_TimedAspect$1$c493a7d9(TimedAspect.aj:26)
    com.example.TestServlet.doGet(TestServlet.java:18)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
    org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)

A metric named "AnnotationService.setSize" already exists

@Metrics(registry = "${this.registry}")
public class AnnotationService {
    private Random random = new Random();
    private Set<String> set = new HashSet<String>();
    private MetricRegistry registry = null;

    public AnnotationService() {
        this(MetricRegisterFactory.getInstance());
    }

    public AnnotationService(MetricRegistry registry) {
        this.registry = registry;
        ConsoleReporter.forRegistry(this.registry).build().start(15, TimeUnit.SECONDS);
    }

    public MetricRegistry getRegistry() {
        return registry;
    }

    @Gauge
    public int setSize() {
        return set.size();
    }

    @CachedGauge(timeout = 10, timeoutUnit = TimeUnit.SECONDS)
    private int cachedSetSize() {
        return set.size();
    }

    private boolean add(String string) {
        return set.add(string);
    }

    private boolean remove(String string) {
        return set.remove(string);
    }

    public boolean gaugeService(String action, String string) {
        if ("add".equals(action)) {
            return add(string);
        } else if ("remove".equals(action)) {
            return remove(string);
        }
        return false;
    }

    //没有注册
    @Counted
    public void countedService() {
        try {
            Thread.sleep(random.nextInt(150));
        } catch (InterruptedException e) {
        }
    }

    @Metered
    public void meteredService() {
        try {
            Thread.sleep(random.nextInt(150));
        } catch (InterruptedException e) {
        }
    }

    @ExceptionMetered
    public void exceptionMeteredService() {
        if (!random.nextBoolean()) {
            throw new RuntimeException("runtime error");
        }
        try {
            Thread.sleep(random.nextInt(150));
        } catch (InterruptedException e) {
        }
    }

    @Timed
    public void timedService() {
        try {
            Thread.sleep(random.nextInt(150));
        } catch (InterruptedException e) {
        }
    }
}

Exception:
java.lang.IllegalArgumentException: A metric named AnnotationService.setSize already exists

I think it's a bug, because @metered not throw exception, it seems @Gauge will register when the method is called..

ps: report 3 metric：@Gauge @meterD @timed, but @ExceptionMetered do not report

if i remove @Gauge, report 3 metric：@meterD @timed @ExceptionMetered

please offer a proposal， thx

About metrics reporter

After integrating metrics-aspectj, but there is no reporter.
If not use metrics annotation, it can be used by

ConsoleReporter.forRegistry(metricRegistry).build().start(15, TimeUnit.SECONDS)

can i get the metricRegistry from metrics-aspectj?
please offer a proposal, thx

@Metered doesn't execute the mark

Hi Antonin, thanks for the library.

Right now I'm trying to get information from a very simple service:

package com.hm;

import com.codahale.metrics.annotation.Metered;
import io.astefanutti.metrics.aspectj.Metrics;

@Metrics(registry = "registryName")
public class Service {

    @Metered(name = "sayHi")
    public void sayHi(){
        System.out.println("Hi!");
    }
}

This service is called by a simple Main class with a ConsoleReport:

package com.hm;

import java.util.concurrent.TimeUnit;
import com.codahale.metrics.ConsoleReporter;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.SharedMetricRegistries;

public class Main {

    public static void main(String[] args) {
        MetricRegistry registry = SharedMetricRegistries.getOrCreate("registryName");

        ConsoleReporter reporter = ConsoleReporter.forRegistry(registry)
                .convertRatesTo(TimeUnit.SECONDS)
                .convertDurationsTo(TimeUnit.MILLISECONDS).build();
        reporter.start(1, TimeUnit.SECONDS);

        new Service().sayHi();
    }
}

and the output looks like the aspect never calls the mark() method from the Meter class:

Hi!
17/06/15 14:20:01 ==============================================================


17/06/15 14:20:02 ==============================================================


17/06/15 14:20:03 ==============================================================


17/06/15 14:20:04 ==============================================================


17/06/15 14:20:05 ==============================================================

Is there something else that we have to do in the @Metered annotation in order to call the mark() method?

This is my pom.xml right now:

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>com.hm</groupId>
    <artifactId>metrics_example</artifactId>
    <version>0.0.1-SNAPSHOT</version>

    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <maven.compiler.source>1.6</maven.compiler.source>
        <maven.compiler.target>1.6</maven.compiler.target>
    </properties>

    <dependencies>
        <dependency>
            <groupId>io.astefanutti.metrics.aspectj</groupId>
            <artifactId>metrics-aspectj</artifactId>
            <version>1.0.0</version>
        </dependency>
    </dependencies>

    <build>
        <plugins>
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>aspectj-maven-plugin</artifactId>
                <version>1.4</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>compile</goal>
                            <goal>test-compile</goal>
                        </goals>
                    </execution>
                </executions>
                <configuration>
                    <source>${maven.compiler.source}</source>
                    <target>${maven.compiler.target}</target>
                </configuration>
            </plugin>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.3</version>
                <configuration>
                    <source>${maven.compiler.source}</source>
                    <target>${maven.compiler.target}</target>
                </configuration>
            </plugin>
        </plugins>
    </build>
</project>

Thanks again @astefanutti, great job with all those libraries.

v1.0.0 Is Not In Maven Central

It looks like the last artifact to make it to Maven Central was RC5. Could you push the v1.0.0 release artifacts? Thanks!

Gradle usage example would be "nice to have".

Maven is by far leading Gradle in terms of usage ( https://gradle.org/maven-vs-gradle ), so it is understandable why Gradle usage is not addressed here (yet).

That said, Gradle is used w/i a significant number of projects, including some that I contribute to, so I have created such an example:
https://github.com/paegun/metrics-aspectj-gradle-example

Please feel free to link to the example or bring such an example under your control so it can more easily remain up-to-date w/ metrics-aspectj .