astrada/gapi-ocaml

A simple OCaml client for Google Services.

gapi-ocaml's Issues

Chunked upload doesn't work

If file size is bigger than max_upload_chunk_size, the last chunk is uploaded incorrectly (content length is always equal to max_upload_chunk_size regardless of remaining bytes). See astrada/google-drive-ocamlfuse#538.

release 3.9 does not build.

I'm trying to package release 0.3.9 and I'm getting build errors.

`[ 8s] + jbuilder build @install
[ 12s] ocamlc src/gapi/.gapi_ocaml.objs/gapiCurl.{cmo,cmt} (exit 2)
[ 12s] (cd _build/default && /usr/bin/ocamlc.opt -w @a-4-29-40-41-42-44-45-48-58-59-60-40 -strict-sequence -strict-formats -short-paths -keep-locs -w -3-23-27-32-33 -g -bin-annot -I src/gapi/.gapi_ocaml.objs -I src/gapi/.gapi_ocaml.objs/.private -I /usr/lib64/ocaml/biniou -I /usr/lib64/ocaml/bytes -I /usr/lib64/ocaml/cryptokit -I /usr/lib64/ocaml/curl -I /usr/lib64/ocaml/easy-format -I /usr/lib64/ocaml/extlib -I /usr/lib64/ocaml/netstring -I /usr/lib64/ocaml/netsys -I /usr/lib64/ocaml/num -I /usr/lib64/ocaml/threads -I /usr/lib64/ocaml/yojson -intf-suffix .ml -no-alias-deps -opaque -o src/gapi/.gapi_ocaml.objs/gapiCurl.cmo -c -impl src/gapi/gapiCurl.ml)
[ 12s] File "src/gapi/gapiCurl.ml", line 287, characters 6-7:
[ 12s] Warning 11: this match case is unused.
[ 12s] File "src/gapi/gapiCurl.ml", line 1:
[ 12s] Error: Some fatal warnings were triggered (1 occurrences)
[ 13s] ocamlopt src/gapi/.gapi_ocaml.objs/gapiCurl.{cmx,o} (exit 2)
[ 13s] (cd _build/default && /usr/bin/ocamlopt.opt -w @a-4-29-40-41-42-44-45-48-58-59-60-40 -strict-sequence -strict-formats -short-paths -keep-locs -w -3-23-27-32-33 -g -I src/gapi/.gapi_ocaml.objs -I src/gapi/.gapi_ocaml.objs/.private -I /usr/lib64/ocaml/biniou -I /usr/lib64/ocaml/bytes -I /usr/lib64/ocaml/cryptokit -I /usr/lib64/ocaml/curl -I /usr/lib64/ocaml/easy-format -I /usr/lib64/ocaml/extlib -I /usr/lib64/ocaml/netstring -I /usr/lib64/ocaml/netsys -I /usr/lib64/ocaml/num -I /usr/lib64/ocaml/threads -I /usr/lib64/ocaml/yojson -intf-suffix .ml -no-alias-deps -opaque -o src/gapi/.gapi_ocaml.objs/gapiCurl.cmx -c -impl src/gapi/gapiCurl.ml)
[ 13s] File "src/gapi/gapiCurl.ml", line 287, characters 6-7:
[ 13s] Warning 11: this match case is unused.
[ 13s] File "src/gapi/gapiCurl.ml", line 1:
[ 13s] Error: Some fatal warnings were triggered (1 occurrences)

`

Can't compile

I failed trying to compile the source (f741ddf), while following the instructions in README.

The error is this:

src $ ocamlbuild gdata/gdata.cma
Finished, 1 target (0 cached) in 00:00:00.
+ ocamlfind ocamlc -c -dtypes -w A -warn-error A -w e -warn-error e -w z -warn-error z -package extlib -package netstring -I gdata -o gdata/gdataAuth.cmo gdata/gdataAuth.ml
File "gdata/gdataAuth.ml", line 65, characters 13-37:
Warning 9: the following labels are not bound in this record pattern:
client_id, client_secret, refresh_token
Either bind these labels explicitly or add `; _' to the pattern.
File "gdata/gdataAuth.ml", line 1, characters 0-1:
Error: Error-enabled warnings (1 occurrences)
Command exited with code 2.
Compilation unsuccessful after building 68 targets (0 cached) in 00:00:03.

Actually in line 65 of gdata/gdataAuth.ml an incomplete value of type oauth2_data is created.

Missing content type in POST requests

Access token refresh (sometimes) does not work because POST requests lack Content-Type HTTP header.

Parsing HTTP header field names is done in case-sensitive fashion

In HTTP, header field names are case-insensitive. In HTTP/2, header filed names that are not lowercase are considered malformed.

Causes astrada/google-drive-ocamlfuse#508.

Unclear where the `<--` operators in the monadic examples comes from

Looking at the monadic examples, I was surprised to find the absence of expected tokens bind, >>=, or let*, and instead an abundance of <-- operators. I haven't been able to build these examples or figure out where this operator comes from.

Perhaps we need to either update the examples or add some documentation on this operator?

gapi-ocaml fail to buid with ocaml 5.0.0 and later

gapi-ocaml fail to buid with ocaml 5.0.0 and later

403 response (download quota for this file has been exceeded) not parsed correctly

Response for downloadQuotaExceeded errors contains extra-bytes so the JSON parser fails rebuilding the structured error.

Examples do not set auth configuration

All the service examples do not set the auth field of configuration record. This way, the example cannot make authenticated requests to the service.

Remove ocamlnet dependency

It's a pretty heavy dependency that requires C code. Would be great to do away with it for portability purposes.

What is ocamlnet being used for in gapi-ocaml? If it's not deeply embedded in the code I try removing it.

Add support for Google Sheets API v4?

Greetings! Would you be open to adding support for the Sheets API? I'd be willing to have a go at running the generation tooling and seeing if I could open a PR to add the result, if so.

Problem getting shared documents

In Documents List API binding, there is a bug that prevents fetching shared document metadata, if the document is not owned, but was shared by another user. The library doesn't expect a specific element in the XML entry (sharedWithMeDate) of shared documents, thus raising an exception.

Error uploading files > 1GB on 32-bit systems

in_channel_length doesn't work on big files, the variant LargeFile.in_channel_length should be used instead.

GapiConversation.with_url does not use auth context

GapiConversation.with_url ignores the optional parameter auth_context, so the invoked callback cannot make authenticated requests to the server (unless the callback executes the authorization flow).

Kubernetes API

Hi

Do you think the code generation machinery here could be used to generate a Kubernetes API client?

Cheers.

Example for doing 2-legged OAuth

Hi,

Is there some examples I can use to 2-legged authentication with gapi-ocaml?

Cheers

Resumable upload bug

• Request to update metadata is retried as if upload already started
• PUT/PATCH with empty body causes thread to hang indefinitely

Warning: Unexpected leaf: name=eventType data_type=Scalar in GapiCalendarV3Model.Event.parse

Using the Calendar API I've hit this warning:

Warning: Unexpected leaf: name=eventType data_type=Scalar in GapiCalendarV3Model.Event.parse

Just thought I might report in case it's an indication that an update will be needed at some point.

Files are kept open after uploading

See astrada/google-drive-ocamlfuse#512

No support for yojson 2.x

I'm using google-drive-ocamlfuse which depends on gapi-ocaml under Arch Linux (using the AUR package), and since yojson has been updated to version 2.0.2, gapi-ocaml doesn't build anymore since it doesn't support the 2.x API.

For now I've worked around the issue by ignoring updates of the ocaml-yojson package in my /etc/pacman.conf file, but it would be great if gapi-ocaml would support the 2.0 version of yojson.

Upload latest release to ocamlforge

It looks like the latest release on ocamlforge is 0.3.1. Can you upload the latest one?

Timestamps ignore milliseconds

Milliseconds in RFC 3339 timestamps are ignored, causing issues with Google Drive file creation, because creation date is not modifiable.

tag v0.3.20 is a release or a pré-release ?

I wonder if you forgot add a new release with tag v0.3.20 ?

Thank you

Concurrent execution?

HI! I'm looking for some tips on concurrent execution of API calls. Ideally, it'd be nice to add support for Lwt (I'm happy to put some work into this, if it'd feasible and welcome), but I'm hoping that -- one way or another -- there's a fairy low overhead way of getting current API calls working.

Any pointers/thoughts on this front?

Remove Extlib dependency

extlib conflicts with base64. base64 would probably make for a nicer decoding experience than Netencoding, take one more step towards #10. More compelling: extlib advertises itself as deprecated for new code on its repo, and both mrmime and email_message depend on base64, and either would be useful in conjunction with this library.