at4260/inbestment

Financial planning tool

inbestment's Issues

Refactor code and move functions into classes

Break the classes in model.py into separate files
Move the functions in utils.py into the appropriate classes
http://stackoverflow.com/questions/7478403/sqlalchemy-classes-across-files

Validate user inputs

/input
User inputs a string instead of a number
User leaves a field blank

/login and /create
User inputs an invalid email

Validate all inputs on both the front end AND bank end.

Show questions one block at a time

For design purposes- similar to Betterment:

Will only load relevant questions. Example: if user selects that company does not have a 401k plan, then don't need to ask if there is a 401k match.

This will also help with data validation, so user cannot input any match or salary percentages if there is no 401k plan.

Add slider

Add a slider to the investments page to allow user to see the difference between Conservative, Moderate, and Aggressive portfolios.
http://www.eyecon.ro/bootstrap-slider/

Don't allow any updates to the database. Just a way to view the portfolios and performance.

Create integration tests to ensure routes working properly

Entire query location of ticker being pulled, instead of actual ticker symbol

Pulling "MX_FB" instead of "FB"
Need to parse the ticker (will depend on which database I choose to source from- Google or Yahoo)

Example here showing extension of ticker ("NYSEARCA_VTI"):
https://github.com/at4260/FinancialApp/blob/master/seed_data/sample_ticker_data.txt#L5

Location of code to be fixed:
https://github.com/at4260/FinancialApp/blob/master/seed.py#L28

Improved usability of banking login

From issue #9:
Note: currently the API is only set up to take TD Ameritrade accounts and I am assuming that the account type is always savings. May add a drop down feature to allow input for a few banking institutions.

May also want to investigate more accurate account type report (API currently does not match up with test account type). -- will probably just keep the assumption that all accounts entered will be categorized as savings.

Autofill data when user wants to update their inputs

If user already has saved inputs and wants to update their inputs, I want the boxes to autofill with their inputs so they can just make the necessary changes and not need to re-input everything over again.

Need to set the value = (pull stored data), but default to blank when the user is entering in data for the first time.
https://github.com/at4260/FinancialApp/blob/master/templates/inputs.html#L5

Deploy

The app should take advantage of the CDN for bootstrap.

This means that FinancialApp doesn't have to check-in the bootstrap code as part of its repository.

See http://getbootstrap.com/getting-started/ for more detail.
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/js/bootstrap.min.js"></script>

Fix inability to pull multiple accounts in one user domain

Continuation of issue #13, but not urgent because there are no other test accounts to use.

When there is only one account per user domain, then the Intuit API and Python library aggcat returns:
<AggCatResponse 201>
<Investmentaccount object @ ----->
This is one object and allows attributes to be called on it.

However, when the user domain has multiple accounts (ex: Chase login/pw with a checking account, credit card, mortgage, etc), then aggcat returns:
<AggCatResponse 201>
<Accountlist object @ ----->

The aggcat documentation states that it is supposed to return this:
<Accountlist object [<Investmentaccount object @ 0x1090c9bd0>,<Loanaccount object @ 0x1090c9890> ...] @ 0x1090c9b10>
This allows the user to itierate through the list of accounts and then call attributes on it.

Currently, <Accountlist object @ -----> does not allow me to itierate through the list or call attributes, so I am not able to pull the account information from each account.

The authentication process (challenge response) will have a similar issue. Without being able to see the list of challenge questions, I won't be able to respond and authenticate the account.

Aggcat documentation:
https://aggcat.readthedocs.org/en/latest/api.html

Aggcat github:
https://github.com/glenbot/python-aggcat

Create unit tests to ensure calculation functionality is working correctly

Aggregate fund data for each risk profile

Currently, I am only testing the graph display for one fund (hard-coded).
https://github.com/at4260/FinancialApp/blob/master/controller.py#L250

Also, there is too many data where the x-axis has too many labels. This is a known ChartJS issue.
https://github.com/at4260/FinancialApp/blob/master/templates/investments.html#L12

Will need to:

1. query funds and price data depending on user's risk profile input
2. aggregate fund performance for each risk profile
   Possible solutions: add new column in database to calculate % change
3. fix x-axis labels
   Possible solutions:

• Reduce the values being seeded into the database- not a great solution because lose the daily ups and downs, shows less variation in the data
• Seed the data into the database, but only query for a specific range (15th of every month, etc)- same issue
• Filter the labels- unsure of how to do this?
  http://stackoverflow.com/questions/22064577/limit-labels-number-on-chartjs-line-chart
• Clone the ChartJS repo (instead of using CDN) and clone someone's fork- may result in other issues
  chartjs/Chart.js#12

Fix all routes to /profile when user has not inputted data

A user who has not inputted financial data has NONETYPE stored in the database for those fields. As a result, going to /profile causes the page to error out.

https://github.com/at4260/FinancialApp/blob/master/templates/base.html#L37

incorporate account data from intuit api into logic and app routing

Got the Intuit API calls to work and pull account data. Data is being saved into database.

Need to query the database on the "inputs" route to be able to incorporate into individual assets. Also need to direct user to route to enter in necessary bank information.

Note: currently the API is only set up to take TD Ameritrade accounts and I am assuming that the account type is always checking. May add a drop down feature to allow input for a few banking institutions. May also want to investigate more accurate account type report (API currently does not match up with test account type).

https://github.com/at4260/FinancialApp/blob/master/controller.py#L56

All TODO in the code should be replaced with Github issues.

This is done to give more visibility into features and bugs that need to be resolved.

route returning user to results, not investments

When user is on "/profile", they are seeing their saved user inputs. The route is currently taking them to "/investments", but I would like for it to route to "/results" instead.
https://github.com/at4260/FinancialApp/blob/master/templates/profile_inputs.html#L19

However, "/results" route calls the arguments entered in the input fields, which were skipped since user has already entered in their inputs previously. Need two conditions: 1) if user is inputting data for the first time, pull the data using request.args.get or 2) if user has saved data, pull data from database and display results.
https://github.com/at4260/FinancialApp/blob/master/controller.py#L78

Load questions one block at a time using AJAX

Continuation of issue #20

Currently, each question renders a new template each time. I would like to be able to do this via AJAX.

Would need to:
Create an event handler on each "Next" question button and when clicked, make post request to the route. Send JSON back and put the routes in Javascript.

Add benchmarks

Allows for user to compare portfolio performance to benchmarks or other individual stocks/funds

Similar to Google Finance functionality to either select pre-selected tickers or to add your own:

Can either:

1. pre-seed database with a few select tickers
2. allow user to input ticker, check Stocks-GOOG.csv file to find ticker url, make Quandl API call, seed database, and plot data on line graph

add login info to be able to save and query user input

https://github.com/at4260/FinancialApp/blob/master/controller.py#L54
https://github.com/at4260/FinancialApp/blob/master/controller.py#L63

Only the base.html template should have an html and head tag.

Right now some of the templates are reintroducing <html> and <head> tags.
https://github.com/at4260/FinancialApp/blob/master/templates/login.html#L5

Show individual funds in performance line graph

Line graph currently has aggregated total performance for the portfolio.

Would also like to show individual funds that make up the portfolio in the graph:
9e96aaf#diff-7a315c65deca2c033ce485bfa9de4f4aR304

This project should have a LICENSE file.

The LICENSE files lets users of the app know under which circumstances they are able to use, reuse, change or redistribute the code.

This is not urgent, but should be addressed at some point.

Here are some good articles about Software Licenses:

• Wikipedia
• Codding Horror about why using a license is good
• TldrLegal - a great site to understand quickly what a license does

I like MIT because it basically allows anybody to use it, without making me liable for possibly broken code!

Here are some example from the projects you are familiar with:

• flask
• jquery
• sqlalchemy (MIT)

Let me know if you have any questions about this!

Database set-up

• set up users table
• set up food table

Support for internationalization should be added.

Right now some of the strings are hardcoded in English, making it difficult to port to a different language.

Check out https://pythonhosted.org/Flask-Babel/

This project doesn't have a README

Probably should add one explaining what this project does.

Remove flask secret key

Need to remove secret key when app deploys:
https://github.com/at4260/FinancialApp/blob/master/controller.py#L12

Add logout feature

• Allow user logout
• Clear session
• Toggles navbar to show logout button when logged in (look at Ubermelon ordering app as example)

Need to input real tickers to be used

Using example tickers right now, need to populate ticker_list with the tickers in the profile allocations (conservative, moderate, aggressive).

Location of code to be updated:
https://github.com/at4260/FinancialApp/blob/master/seed.py#L9