athenekilta/ilmomasiina

Event registration system

ilmomasiina's Issues

New quota creation loses old quota data

Make default text changable

It is embedded in src/routes/SingleEvent/SingleEvent.js

If it has to change a lot it would be a good idea to change It to be modifiable from the admin site.

Reverse event list and move event creation button to top

Event description sometimes overflows

If style white-space: pre; is removed, the text box is able to contain the text. However, this breaks support for line breaks in the description.

Improve logging

It would be nice to have a log file where you can see what has happened

Old signups should be anonymized after some time

Otherwise GDPR will bite us in the ass sometime

SequelizeDatabaseError: Unknown column 'quota.id' in 'group statement'

Happens when trying to paginate content

eq. /api/events/?$limit=1

Add access control to signups

There are a lot of guild officials that need to create events, but not all of them need to see signup details of every event. As a first solution it could be possible to restrict data from any other account but the one that created the event. Access control lists or similar restrictions could be implemented later, if necessary.

Signup can happen with old event details presumably from localStorage

I tried to sign up for an event ASAP after the opening of the registration. I ended up getting the signup form without a position in queue or quota. I filled the form and got a confirmation email for the previous event I had attended. I checked the requests from my browsers dev tools and the signup was sent with the previous event's id and quotaId. This resulted in the server sending out a new confirmation email although the event had already passed. No errors showed up in the frontend and I didn't get signed up to the event I tried to.

To me it seems that the most likely explanation is that the previous signup was still in my localStorage and didn't get updated because getting the position failed in attachPositionAsync. This doesn't remove old information from localStorage and could end up causing issues.

Issue #62 could also be related if there is a partially filled form in localStorage.

Although this seems to be a frontend bug, the backend also shouldn't accept signups or send confirmation messages for old, already passed events. Also the frontend didn't show any errors when there probably were errors in the console. Perhaps a separate issue could be created for those.

Add English translation to web UI

Emails are already translated, but UI should be available in English, as well.

Order of quotas and questions cannot be changed

When creating an event, there is a bug where you cannot change the initial order of given quotas and questions. When trying to change the order it comes back to the original after saving changes. Steps to recreate bug:

1. Create mockup data with npm run create-fake-data
2. Go to admin panel http://localhost:3000/admin
3. Open Columbia road - excu and change the order of the two quotas
4. Save changed data and see that the original order is back

Creating new users fails

Locally, when creating new users from the admin panel, users are not added but an error message is shown.

Suggestion: Add contribution guidelines

Currently the repository has quite many contributors and no contribution guidelines.
I suggest we add a CONTRIBUTING.md to this repository and write down some principles on how to contribute to this project, so contributing is as nice and enjoyable as possible for everyone involved :)

Select-field cannot be set as optional in event enrollment form

As an admin, I want to add such dropdown options for enrollment forms that it is not required to select an option.

MySQL 8.0.22 and npm package mysql2 1.6.5 have compatibality issues.

Updating to the latest version of the package fixes this

#97

Fields left empty when registering are not editable afterwards.

If a user leaves some non mandatory fields while signing up, they won't be able to edit said fields when following the link provided in the email.

User management

We eventually need an ability to remove admin users, because it is not good that anyone that has ever had the admin rights will have the admin rights till the end of times.

I think we only need creation and removal, editing is not necessary for now.

Feature: delete all signups of an event

Signups can be deleted, but currently only one at a time. It would be convenient to remove all signups of a event.

Currently there's a feature that tries to anonymize signups of old events by deleting name and email information. However, there may be personal data in other questions as well, for example phone number or Telegram username, which can be used to identify the person. Instead of censoring some fields, all signups could be deleted automatically instead. Storing old event information without personal data (signups) can be beneficial, as they can be used as a reference when creating new events.

Admin creation form in admin/users doesn't work

Fix in
#100

If answers are not public, amount of signups should be hidden

Now counter shows zero, which is misleading

Add link previews

Add open graph link previews for events. They could include the event picture that would be defined in event settings, or be a generated image like in Github.

Migrate project to typescript

Confirmation email whitespace problems in outlook

It seems that outlook drops linebreaks and other whitespace from the user modifiable part of confirmation emails.

At the moment the email is generated with pug and this "Vahvistus sähköpostiin" field is turned into one <p>aragraph. The formatting is preserved with a css attribute white-space: pre-line which is not supported in outlook.

I have tested this with our own fork, but could someone confirm the problem?

Sometimes signup form says that not all fields are filled, even though they are

This makes it sometimes impossible to sign up and people angry

Add confirmation on signup delete

window.confirm should be sufficient

New admin account creation is broken

Add possibility for reserving multiple slots with one signup

Toast says signup successful even after deadline

If a user opens a signup form while the event signup is still open but is unable (or too slow) to fill it before the signup closes, after they press the submit button they get a "success"-toast even though the signup attempt fails as it gets rejected by the API.

Steps to reproduce:

1. Create an event for which the signup time closes soon
2. Open the signup form
3. Wait for the signup deadline to pass
4. Submit the pending form

Event name -> event editor in admin event list

Currently the event name link takes the user to the even page, which is seldom what the user wants to do. The current small edit link and event name link could be swapped.

New users can be created with emails that aren't valid emails.

Schemas should have validation

New events can be created without description but updating the event fails if the description is null

Contradictory information regarding queue status

One user was informed by email that they got accepted to the event, however, Ilmomasiina website displayed that person still in queue. This should be further investigated.

Telegram users redirects to twitter

Usually, in the event description, some telegram usernames are given if people have questions. However, if ones press the usernames, it redirects to twitter instead of telegram.

Extra questions disappear sometimes when saving

Ask Samuel

Line breaks are disappearing in verification email texts

Scale images to fit viewport

Current behavior causes large images to overflow

Event can be changed from private signups to public, which reveals user data

Currently it is possible that a user signs up to an event assuming the event signups are private, but the event can then be changed to have public signups. This reveals user data without asking permission from the user.

Could be fixed either by preventing changing private events to public, or storing the publicity setting of each signup separately and asking that from the users beforehand.

Fix multiple choice question without options

It's possible to create a multiple choice question without options by messing around with the question form. Saving this is possible and causes the front end to error silently when it tries to open the registration form.

Users are not notified when quota is increased

It seems like that users are not notified when event's quota is increased. In comparison, when users are accepted from the queue (because someone cancelled their signup), they are sent an email.

Suggestion: User gets notified if he/she moves into primary registration due to cancellation or other reasons

Quality of life improvement for users that do not follow registration page actively.

Feature: copy events

That is, create a new event and copy contents (questions etc, not signups) from the old event.

Suggestion: use material-ui for theming

Just an idea: it would be pretty neat if this app could be themed easily from a single file. I think the following would be enough to make it look sufficiently personalised:

• Title font
• Body font
• Main theme color (currently green)
• Secondary color (accent color)

This could be done rather easily by doing the following:

1. Wrap the app in a material-ui `ThemeProvider, provide it the current theme colors and fonts
2. Replace all h1-h6, span, p, etc. text components with the material-ui Typography component
3. Remove the color definitions from styles/_base.scss, see what breaks, and replace the affected styles with one of material-ui:s css-in-js solutions.

See here for material-ui styling reference: https://material-ui.com/styles/advanced/.

Definitely a nice-to-have, but potentially a good first issue and would be one step more towards Ilmomasiina-as-a-service

Implement CI/CD pipeline

One major improvement to Ilmomasiina could be to add CI/CD pipeline to ensure code stability before merging changes into production. One alternative to testing could be Cypress.

CSV export does not include queue status

Add dietary restrictions question

Adding a unified dietary restriction question type (or setting) would make it easier for event organizers to add inclusive, easy-to-answer and unambiguous question(s) for food restrictions for any event.

Switch back to otax mail?

Mailgun throttles the amount of emails - other option is to build a queue.