Giter Site home page Giter Site logo

Freezes when entering URL about nyxt HOT 5 OPEN

KikyTokamuro avatar KikyTokamuro commented on August 19, 2024 1
Freezes when entering URL

from nyxt.

Comments (5)

aadcg avatar aadcg commented on August 19, 2024

I think it's due to the call to input->queries that fetches search engine suggestions in prompter:filter-postprocessor. Maybe it's possible to make it more efficient but, regardless, there should be (1) a mechanism that only triggers it given that a certain minimum of characters has been inserted and (2) an upper bound of time to wait for the return values of input->queries given that the internet connection may be slow.

from nyxt.

wvstolzing avatar wvstolzing commented on August 19, 2024

I think the issue mentioned in pull request #2998 is also at work here. I've been using the development build compiled over sbcl on Debian 12 as well as Fedora 38; & have the exact same problem.

from nyxt.

aadcg avatar aadcg commented on August 19, 2024

@wvstolzing I don't think that's related.

Could one of you test the command set-url with the following patch applied (buffer.lisp)?

 (define-class new-url-or-search-source (prompter:source)
   ((prompter:name "New URL or search query")
-   (prompter:filter-preprocessor
-    (lambda (suggestions source input)
-      (declare (ignore suggestions source))
-      (input->queries input
-                      :check-dns-p nil
-                      :engine-completion-p nil)))
    (prompter:filter nil)
-   (prompter:filter-postprocessor
-    (lambda (suggestions source input)
-      (declare (ignore suggestions source))
-      (input->queries input
-                      :check-dns-p t
-                      :engine-completion-p t)))
    (prompter:actions-on-return #'buffer-load*))
   (:export-class-name-p t)
   (:documentation "This prompter source tries to \"do the right thing\" to

If the issue is gone, then it's due to input->queries as I've pointed out and #2998 is unrelated.

It's hard for me to reproduce the issue you're facing. Theoretically, throttling the network bandwidth could show it.

from nyxt.

apsinthium avatar apsinthium commented on August 19, 2024

I, too, have this issue. I have commented out the lines you specified in buffer.lisp and ran set-url, but the lagging still persists. Sometimes, if I type too quickly, then the entire application freezes and I have to force quit. I'm on Debian 13 (Trixie/sid) and using Nyxt 3.9.0 (Flatpak).

from nyxt.

jmercouris avatar jmercouris commented on August 19, 2024

Thank you for your reports, we will investigate!

from nyxt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.