atmire/expanded-orcid-support

Expanded ORCID support for DSpace 5 and 6

expanded-orcid-support's Issues

Missing orcid_icon.png files in dspace_5x.patch and dspace_6x.patch

The patch files dspace_5x.patch and dspace_6x.patch are missing the orcid_icon.png binary diffs. The patches need to be created using the --binary option for git diff. Also, the Download patch instructions should mention the --binary option for those who want to create their own patch file.

Build Failed orcid.connector.url

I followed the installation instructions for our DSpace 6.3 system, but "ant update" fails with this message:

BUILD FAILED
/ebs/dspace-source/dspace-6.3-release/dspace/target/dspace-installer/build.xml:75: Property orcid.connector.url was circularly defined.

When I ran the check, it complained about a few things that didn't seem to be critical. Including them below in case they are relevant.

[glenn@rctest dspace-6.3-release]$ git apply --check ./dspace_6x…stable_6x.diff
error: cannot apply binary patch to 'dspace/modules/xmlui-mirage2/src/main/webapp/themes/Mirage2/images/orcid_icon.png' without full index line
error: dspace/modules/xmlui-mirage2/src/main/webapp/themes/Mirage2/images/orcid_icon.png: patch does not apply
error: dspace/modules/xmlui-mirage2/src/main/webapp/themes/Mirage2/xsl/theme.xsl: already exists in working directory
error: cannot apply binary patch to 'dspace/modules/xmlui/src/main/webapp/themes/Mirage/images/orcid_icon.png' without full index line
error: dspace/modules/xmlui/src/main/webapp/themes/Mirage/images/orcid_icon.png: patch does not apply

Would appreciate any ideas on how to get this patch applied.

OrcidAuthorityValueServiceImpl does not account for the label_* ORCID authority values

The find() method override in OrcidAuthorityValueServiceImpl.java does not account for the label_* values like the proposed fix for DS-3999. The suggested approach (in PR 2195) is to set the label_* values in the overridden Orcidv2AuthorityValue setValues() method. However, the overridden find() method does not call AuthorityValueServiceImpl fromSolr() which then calls the setValues() method.