atombuild/atom-build-npm-apm

NPM/APM plugin for atom-build

atom-build-npm-apm's Issues

Install dependencies and devdependencies

When i run npm install on my terminal, npm installs dependencies and devDependecies.

When I run npm install through this package, it only installs dependencies. Can we either get it to install devDependencies also or get a configuration for it?

Not found `npm` with nvm!

I install node by nvm.

cannot find module npm/bin/npm/npm-cli.js

I cannot get npm install to run.

• Windows 10 x64
• Node v5.10.1
• Atom 1.7.3

When I hit CTRLALTB, I get this error:

module.js:341
    throw err;
    ^

Error: Cannot find module 'C:\Users\Danny\Dev\handmade-quake-js\node_modules\npm\bin\npm-cli.js'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:146:18)

    at node.js:404:3

I made sure the only path I had in PATH related to node or npm was my node path.

Any advice on how to get atom-build-npm-apm to find my npm.cmd file?

Spawned child process inherits process.env.NODE_PATH from Atom

I got always this error, when I tried to run an npm script within my application.

npm ERR! node v7.4.0
npm ERR! npm v4.0.5
npm ERR! code ELIFECYCLE
npm ERR! {XXX} build-productive: gulp build-productive
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the {XXX} build-productive script 'gulp build-productive'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the {XXX} package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! gulp build-productive
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs {XXX}
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls {XXX}
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /home/{XXX}/npm-debug.log

It took me some time, but I was able to figure out, that on my Ubuntu Machine the child process is spawned with:
npm run build-productive
witch calls my local installation of npm (see error).

But the process.env.NODE_PATH from Atom has been provided to the child process and I had to change this line:

const env = {FORCE_COLOR: '1', MOCHA_COLORS: '1', NPM_CONFIG_COLOR: 'always', NODE_ENV: ''};

to

const env = {FORCE_COLOR: '1', MOCHA_COLORS: '1', NPM_CONFIG_COLOR: 'always', NODE_ENV: '', NODE_PATH:'/usr/bin/node'};

I would consider it to be better, to be able to specify this within the configuration.

Configure path to package.json

When package.json not located in the project root folder, the builder does not find the package.json .

How to tell the build system the directory where package.json is located, when not in the project root folder ?

Specify in README that “engines” field is needed

this did nothing until i looked in the code and i found that you need the engines field in package.json.

i think more people are confused since this is the first time i heard of this field.

Consider a user setting or a different default other than install

Accidentally hitting F9 when it is an npm install is a bummer in a way.

editor windows hangs on show targets

OS: Mac OS X 10.11.5 (15F34)
Version: 0.12.0
Atom Version: 1.8.0

Recently either this package or the build package (idk) hangs up my editor window. When I hit cmd+alt+t to display the targets the editor hangs. After a while a dialog pops up telling my that the editor window does not respond. Clicking 'wait' does not help. Tested it five time - same result everytime.

Maybe build-npm has a problem with my project structure. For this project it looks like this:
project root contains .git directory (and other git stuff) and a subdirectory. That subdirectory contains the project-level package.json.

Problems running npm scripts on Windows platform

When I run a npm script on windows, it only works if I run the "npm: default" task. If I run any other npm script, it fails to find npm.

Looking at your script source, on line 35, you have:

exec: (pkg.engines.node ? 'npm' : 'apm') + executableExtension,

Which guarantees the proper extension for the npm script on Windows.

On line 43:

exec: 'npm',

Which I assume is the culprit to make the other scripts fail.