atsign-foundation/at_talk

VERY simple talk client that uses the atPlatform

at_talk's Issues

Rename default branch to trunk

@cconstab this was created with main as the default branch. Can we make it trunk to align with the other repos in this org?

Not receiving messages between atsigns using at_onboarding_cli+at_auth

Describe the bug

Sent messages are not being displayed on the receiver's end

Steps to reproduce

1. Clone the trunk branch of at_talk (change the dart version)

2. Then Add the following dependency overrides
   dependency_overrides:
   at_commons: ^3.0.56
   at_lookup: ^3.0.40
   at_client:
   git:
   url: https://github.com/atsign-foundation/at_client_sdk
   ref: trunk
   path: packages/at_client
   at_onboarding_cli:
   git:
   url: https://github.com/atsign-foundation/at_libraries.git
   path: packages/at_onboarding_cli
   ref: apkam_onboarding_changes

3. And then generate a new atsigns with register_cli(apkam_onbording_changes) branch

4. Run the following commands for the 2 atsigns

 dart bin/at_talk.dart -k /home/shaikirfan/.atsign/keys/@yeastydotterel85_key.atKeys -a @yeastydotterel85 -t @charlie24

dart bin/at_talk.dart -k /home/shaikirfan/.atsign/keys/@charlie24_key.atKeys -a @charlie24 -t @yeastydotterel85

atTalkLOgs.txt

attalkreceiverlogs.txt

Expected behavior

Messages sent and received should be displayed.

Screenshots

attalk.mp4

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

No response

Update at_talk to not use sync at all

There is no need for sync as at_talk now uses notifications

• Remove sync
• If sending a file then do not prepend the atSign in the UI
• Stretch deal with multi users and screen handling using Tim Sneath's https://pub.dev/packages/dart_console

feat: at_talk should use at_cli_commons.CLIBase and at_client.AtRpc

Is your feature request related to a problem? Please describe.

at_talk is a canonical demo but is not using the latest and greatest other pieces of software which reduce boilerplate and simplofy application code

Describe the solution you'd like

• replace how at_talk currently creates its AtClient instance by instead using CLIBase from the at_cli_commons package (example: https://github.com/atsign-foundation/at_libraries/blob/trunk/packages/at_cli_commons/example/bin/scan_example.dart)
• replace how at_talk currently sends and receives notifications by instead using AtRpc (example: https://github.com/atsign-company/gary-snippets/tree/main/at_rpc_demo)

Describe alternatives you've considered

No response

Additional context

No response

at_talk needs way better screen handling.. In particular when multiple users are chatting in a group/or individual

Is your feature request related to a problem? Please describe.

Handle multi users and screen handling using Tim Sneath's https://pub.dev/packages/dart_console work

Describe the solution you'd like

Have screen handling rather than the simple text scroll the app has now.

Describe alternatives you've considered

No response

Additional context

No response

Security Policy violation Binary Artifacts

This issue was automatically created by Allstar.

Security Policy Violation
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

• attalk.exe

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

---

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

Remove prepend of atSign when receiving a file/txt contents

Is your feature request related to a problem? Please describe.

If sending a file then do not prepend the atSign in the UI

Describe the solution you'd like

The client send knows if the content is coming from a file or an stty and so we should be able to remove the prepend if the data comes from a file.

Describe alternatives you've considered

none

Additional context

No response

Security Policy violation Branch Protection

This issue was automatically created by Allstar.

Security Policy Violation
No protection found for branch main

---

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.