Giter Site home page Giter Site logo

Comments (4)

careo avatar careo commented on August 12, 2024

I've reproduced it with just a few tweaks to the default workflow and it seems to be an issue more with rgthree's ksampleroconfig.

ComfyUI_euler_normal_8 0_ '10', 0 _0001

from save-image-extended-comfyui.

audioscavenger avatar audioscavenger commented on August 12, 2024

I appreciate your willingness to provide me with a sample that I can work on, thank you very much. Will look at it in a few.
A week later... just realized I was not recieving notifications for my own project, bummer.

from save-image-extended-comfyui.

audioscavenger avatar audioscavenger commented on August 12, 2024

okay i can reproduce.

  • primitive int -> steps ksampler: no bug
  • rgthree STEPS/REFINER_STEPS -> steps ksampler: bug
  • rgthree STEPS -> CR int to str -> String to Integer -> steps ksampler: bug too

clearly smth with rgthree's Ksampler config, which I have never tried. So you plug in steps, and somehow, you also override cfg/sampler/scheduler ? that's dark magic.
I opened ksampler_config.py, and it actually does nothing but output RETURN_NAMES with corresponding RETURN_TYPES.

No clue how that even works, or how it's even possible that we link only steps, and somehow we also alter "CFG", "SAMPLER", and "SCHEDULER"
sorry, you will have to ask him. He works at Google and not sure he will have time for that

from save-image-extended-comfyui.

audioscavenger avatar audioscavenger commented on August 12, 2024

here is the fix: use "steps_total" (or 10.steps_total if you have multiple ksampler config) instead of steps, and you get the steps value you want.

from save-image-extended-comfyui.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.