Giter Site home page Giter Site logo

Comments (7)

audioscavenger avatar audioscavenger commented on August 12, 2024 2

hmmmm you may be right after all. if you really want subfolders for such and such model, you just have to add them yourself in the text zone. It makes sense, i guess.
should I submit a poll before modifying this? or since there are like only 10 users, should i not care and go ahead?
this modification will also affect controlnets

from save-image-extended-comfyui.

audioscavenger avatar audioscavenger commented on August 12, 2024 2

cktp_path!!! you just solved it, thanks

from save-image-extended-comfyui.

audioscavenger avatar audioscavenger commented on August 12, 2024 2

release 2.73 address ckpt_path and control_net_path

from save-image-extended-comfyui.

audioscavenger avatar audioscavenger commented on August 12, 2024

it's all perfectly normal:

  • folder is FaceGen / %F
  • then FaceGen-[ckpt_name].jpg
    since ckpt_name is SDXL/.photo/sdxlHKwhatnot then that's exactly what you have

fixing this is easy, but then what do YOU want? some people like me want a subfolder because I place SDXL in subfolders myself. Therefore I have extra subfolders when using ckpt_name for SDXL only.
If you want no subfolders, then do you want all the path with separators instead? which separators? or just the filename.safetensors?
I am wary of modifying this part, as Comfy does exactly what it is supposed to: return a subpath/ckpt_name

from save-image-extended-comfyui.

ManOrMonster avatar ManOrMonster commented on August 12, 2024

I just want the checkpoint name in the file. I don't want any subfolders I don't specify explicitly.

So if the checkpoint is SDXL\.photo\sdxlHK_v09.safetensors I want the name added to the file to be sdxlHK_v09, or put in regex form, .*\\(.+)\..+.

My current solution is to use the WAS checkpoint loader and pass the name_string output to filename_keys in your node. Which is ironic since I originally got your node because the WAS image save node is broken after a recent update and takes like 5 times longer to save images.

image

In any case, I have a solution. Do your node how you wanna! I'm just replacing my WAS save nodes in my workflows with yours becasue they work better. Good timing with this release BTW.

from save-image-extended-comfyui.

ManOrMonster avatar ManOrMonster commented on August 12, 2024

I don't see any reason why these can't both be accomplished: ckpt_name does the obivous thing and only grabs the name, and then add ckpt_path so people can add the path if they want. Same thing with ControlNet or anything else that would have a folder path.

from save-image-extended-comfyui.

ManOrMonster avatar ManOrMonster commented on August 12, 2024

Doesn't seem to have changed anything except for now putting the delimiter as a prefix to the foldername_keys. At least the folder order is correct this time. Also note that the delimiter was not used in "FaceGenSDXL"; it should have been "FaceGen_SDXL", unless the delimiter is no longer applied to file name?

image

With ckpt_name:

image

Also, ckpt_path only creates the first folder(s), then names the file the final folder name.

image

And then ckpt_path,ckpt_name does this:

image

from save-image-extended-comfyui.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.