augensalat/mojolicious-plugin-accesslog

Easily generate access logs for Mojolicious applications

mojolicious-plugin-accesslog's Issues

POD is not clear on how to use with Mojolicious (not Mojolicious::Lite)

Documentation says I should write:

# Mojolicious
$self->plugin(AccessLog => {log => '/var/log/mojo/access.log'});

But when I include the uname_helper setting as such:

sub startup {
    my $app = shift;
    $app->plugin(AccessLog => {
        log => '/dev/null',
        uname_helper => 'set_username',
    });
    $app->hook(around_action => sub {
        my ($next, $c, $action) = @_;
        $c->set_username('alex');
    });
}

...then I get this error:

Can't locate object method "set_username" via package "Web::Ctrl1"

...where Web::Ctrl1 is the name of my controller that contains the route handlers. Everything else works on my website, except this, which produces this error.

How do I fix it? The AccessLog's documentation is not clear on this.

Allow $c in log function

I'm doing this now: (which of course is not very nice)

{
  require Mojolicious::Plugin::AccessLog;
  no warnings 'redefine';
  my $hack = \&Mojolicious::Plugin::AccessLog::_log;
  *Mojolicious::Plugin::AccessLog::_log = sub {
    my($c, @args) = @_;
    local $main::LOG_KEY = $c->session('reference') || $c->session('username');
    MyLogger->log(info => $hack->($c, @args));
  };
}

$app->plugin('Mojolicious::Plugin::AccessLog' => log => sub {});

Is there a way you could add a "log" callback which gets $c passed on as well as the log message? Or would you consider taking a pull request for this feature?

forking worker API

Do you have an advice what's the best way to prevent forking workers logging twice?

Grateful for any insight you can provide.

the plugin produces a warning in the logs whenever Mojolicious starts

==> api.err.log <==
[Sat Nov 21 22:41:50 2015] [warn] Mojolicious::Plugin::AccessLog::VERSION = 0.010

I think this is useless, and shouldn't be there since I didn't do anything wrong to get warned about.

Update CPAN

CPAN is still on version 0.004. When do you publish 0.005?