Giter Site home page Giter Site logo

Comments (12)

marktaling avatar marktaling commented on May 28, 2024

I'm not sure I correctly understand the issue. The buildtask does not require you to specify specific feature files but rather requires you to provide a path from where it recursively should search for .feature files.
Following this logic, there should be no issue when a file only exists on a single branch.

from augurk.

timvandelockand avatar timvandelockand commented on May 28, 2024

Indeed, when the file matches an existing pattern there's no problem. When a new branch needs a .feature file in a new group in Augurk though, a build step with a new pattern would have to be added. In that case the path will not be found in other branches that already existed.

from augurk.

marktaling avatar marktaling commented on May 28, 2024

So, the problem is mostly that in your case the build step references a folder which is not necessarily present on al branches?

from augurk.

timvandelockand avatar timvandelockand commented on May 28, 2024

Exactly. Now I could enable 'Continue on error' on those specific build steps, but the build will then only partially succeed (which could indicate that there's something wrong, while it is expected behaviour in that case)

from augurk.

marktaling avatar marktaling commented on May 28, 2024

I think this particular build step is fine as-is. As you do not always have an hierarchical folder structure you want to mimic in Augurk.
I suggest we add a second task which has the described functionality. This new task would not allow you to specify a GroupName but instead use the parentfolders of each file as a GroupName. This would allow you to do grouping on a branch-level while still supporting the use of a single builddefinition.

from augurk.

jmezach avatar jmezach commented on May 28, 2024

I don't think having a second task with similar functionality is a good idea. First of all, it makes it confusing for our users because they need to decide which Augurk task to use. Second of all its not very easy to share functionality between these two tasks, so for us it becomes a maintenance nightmare.

Perhaps we should just add a checkbox indicating which behaviour to use and then make the GroupName field disappear based on that.

from augurk.

marktaling avatar marktaling commented on May 28, 2024

That would work fine as well. The main thing is, I don't want to lose our current functionality.

from augurk.

jmezach avatar jmezach commented on May 28, 2024

Interestingly if I look at how things are set up now (ie. our problem domain ;)) we not only have to look at the direct parent, but also parent folders above that. So I have two questions:

  • How far do we go with this? Keep going until we hit the folder we started searching from? At the moment that would be the folder the build is run in, which might not always be what you want. Perhaps add a base folder option for the search as well?
  • What do we with each sub level in terms of naming the group? Ie. what does the group name become if the sub folder structure is something like \Specifications\Client\Business policy\PauseProfile?

from augurk.

marktaling avatar marktaling commented on May 28, 2024

I would assume we only support the highest level. So we would always take the direct parent folder?
It's easiest to implement and clear in the way it functions.

from augurk.

jmezach avatar jmezach commented on May 28, 2024

@timvandelockand Is this still an issue?

from augurk.

timvandelockand avatar timvandelockand commented on May 28, 2024

@jmezach Not anymore; the 'use folder structure' checkbox works like a charm.

from augurk.

jmezach avatar jmezach commented on May 28, 2024

This has been fixed already. We have also recently moved the VSTS/TFS extension to its own repo (https://github.com/augurk/vsts-extension)

from augurk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.