aura-healthcare/ecg_qc

A library to compute ECG signal quality indicators

ecg_qc's Issues

Confusion about the length of the input signal

Hello, I am learning about your library recently. I want to know if there is any limit on the input length of the four models trained? If I want to test my input with the first three models 'dFC_2s.pkl', rFC_2s.pkl, and 'rfc_2s_norm.pkl', do I need to fix my signal to the length of 2s? Similarly, if I need to use the 'xGB_9s. joblib' classifier, do I have to fix my test signal to a length of 9s? I really hope you can reply to me, thank you!

Validation procedure

According to your notebook, you create your validation set based on a sample of 20% of the initial data set:
df_ml_conso_for_model, df_ml_conso_validation = train_test_split(df_ml_conso, test_size=0.2, random_state=42)

If this is the case, you validate your final models on the same subjects you trained it on. While not exactly the same samples are used for validation, the samples come from the same subject and would therefore bias your results.

Validating your model on unseen subjects from the same dataset, I got a mean precision of 0.63 (SD=0.19), mean recall of 0.97 (SD=0.06) and mean F1 of 0.75 (SD=0.15). See also image below. The low precision indicates that a lot of windows will be marked good when they are not.

Example of applying raw data

I have single line ecg data; I used neurokit. But it evaluated incorrectly in Bluetooth disconnection period.
And Their reference: SQI Quality Evaluation Mechanism of Single-Lead ECG Signal Based on Simple Heuristic Fusion and Fuzzy Comprehensive Evaluation, it cited only 20.

Can you explain how to apply my data on your package? and what is your reference?

failed to install

hello, im learning your library. I'm facing a problem now and I'm feeling so bad. after running pip install ecg-qc, I cannot import it.
the error says:
import ecg_qc
Traceback (most recent call last):
File "", line 1, in
import ecg_qc
ModuleNotFoundError: No module named 'ecg_qc'

so I find the folder, there's no folder 'ecg_qc' but just a folder 'ecg_qc-1.0b6.dist-info'. So I tried the next way, run '$ git clone https://github.com/Aura-healthcare/ecg_qc.git
$ python setup.py install' after some errors and solutions, the terminal says 'Finished processing dependencies for ecg-qc==1.0b6'. I was happy to see it, there is a 'ecg_qc-1.0b6-py3.8.egg' near the folder 'ecg_qc-1.0b6.dist-info'. im happy to see it.
BUT, when I try to run 'ecg_qc = EcgQc(model='rfc_norm_2s.pkl',
sampling_frequency=256,
normalized=True)'
it says: 'ecg_qc = EcgQc(model='rfc_norm_2s.pkl',
TypeError: init() got an unexpected keyword argument 'model''
so I delete the model, and run the rest of the sentence.
but It says, 'FileNotFoundError: [Errno 2] No such file or directory: 'rfc_norm_2s.pkl''
if I download the folder'ecg_qc' from github and paste it on the correct path, there's still the same error.
so I guess there's still something wrong with the installing.
I tried both on Mac and windows, all failed.
I'm so confused. what should I do? how to install the package successfully? please tell me, thank you very much.