router-lite: null/undefined in optional parameters

[elitastic]

router-lite: null/undefined in optional parameters

[Sayan751]

In that case, it will remain as string. We can improve that when #1734 is implemented.

[Sayan751]

Hi @elitastic! Thanks for reporting this. If I am not wrong, then this is the same as the Aurelia 1 router. That is, the value of the parameters are converted to string regardless of types.

I think that rather than ignoring the null and undefined from this rule, we can simply leave the other type of values such as number and boolean as they are. Any other kinds of parameters values will be continued to be processed, as it is currently being done.

@bigopon What do you think about that?

[bigopon]

No objection, it does indeed feel not getting what we see. For apps migrating from v1, maybe we can explain this isn't a nice behavior so it's changed. But what happens when params come from the url?

[elitastic]

In Aurelia 1, optional null/undefined parameters are ignored, that's why it results in undefined, which is more useful than 'undefined' in my optinion.

[Sayan751]

By optional parameter, I have understood something like this: route/:param?. However, by optional parameters you meant the parameters not defined for route, and thus putting into the query. Note that as for handling the query, the URLSearchParams API is used, and it is not supported to preserve the type of the values, and everything is converted to string.

I do understand, that you are only looking for the absence of such parameters in the query, when the value is null or undefined. I found that to be loss of data. @bigopon I am a bit torn on this issue.