Incorrect injection of parent custom element

[Sayan751]

Incorrect injection of parent custom element

[bigopon]

As far as I understand, this is caused by the choice of container from the hydration context:
...
That following change solves the problem:
...
However, it messes up the projection :(

The reason it solves the problem is because it disregard the hydration context hierarchy and start walking up the container hierarchy for resolving key. In the template, hydration context of the au-slot content of ce-l3' is my-app. I'm checking it now for a resolution of this issue.

[bigopon]

In the define hook of the ce-l1 I am registering the instance of ce-l1 to the hydration context.

Does this part matter whrther you get the right or wrong ce 1 instance?

[Sayan751]

Does this part matter whrther you get the right or wrong ce 1 instance?

Yes, as the child items want to interact with the parent using the API provided by the parent. Hence, for my use case it is important that the correct CE is injected.

[bigopon]

If i understood the intention of the template correctly, shouldnt ce-1#2 be automatically injected into ce-3#ctor? @Sayan751
If so, what we do in define of ce-l1#define wouldnt matter, hence my question above. Also i think we should refrain from define hook, its power is quite too much (Im thinking we should remove it).

[Sayan751]

Yes, you are right @bigopon! I misread your question about the define hook. If the normal injection works, then the define hook stuff won't matter. I have a hunch that this issue, and #1874, both are related to how au-slot is managing the containers.

[Sayan751]

@bigopon This one https://stackblitz.com/edit/newinstanceforscope-with-au-slot?file=src%2Fmy-app.ts might also be related.

As far as I understand, this is caused by the choice of container from the hydration context:

aurelia/packages/runtime-html/src/resources/custom-elements/au-slot.ts

Line 63 in 71f82cf

container = hdrContext.parent!.controller.container.createChild({ inheritParentResources: true });

That following change solves the problem:

+ container = hdrContext.parent!.controller.container.createChild({ inheritParentResources: true });
- container = hdrContext.controller.container.createChild({ inheritParentResources: true });

However, it messes up the projection :(